diff mbox

[dpdk-dev] net/liquidio: fix uninitialized variable

Message ID 1505442779-15698-1-git-send-email-wang.yong19@zte.com.cn (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yong Wang Sept. 15, 2017, 2:32 a.m. UTC 
  In func lio_dev_link_update(), "link.link_autoneg" is used in func call
lio_dev_atomic_write_link_status(), but is uninitialized.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/liquidio/lio_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shijith Thotton Sept. 15, 2017, 11:27 a.m. UTC | #1 
On Thu, Sep 14, 2017 at 10:32:59PM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  drivers/net/liquidio/lio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..a5a71f8 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
>  	link.link_status = ETH_LINK_DOWN;
>  	link.link_speed = ETH_SPEED_NUM_NONE;
>  	link.link_duplex = ETH_LINK_HALF_DUPLEX;
> +	link.link_autoneg = ETH_LINK_FIXED;

Thanks for noting. Proper value would be ETH_LINK_AUTONEG as we negotiate speed
in firmware.

>  	memset(&old, 0, sizeof(old));
>  
>  	/* Return what we found */
> -- 
> 1.8.3.1
>
diff mbox

Patch

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 479936a..a5a71f8 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -939,6 +939,7 @@  struct rte_lio_xstats_name_off {
 	link.link_status = ETH_LINK_DOWN;
 	link.link_speed = ETH_SPEED_NUM_NONE;
 	link.link_duplex = ETH_LINK_HALF_DUPLEX;
+	link.link_autoneg = ETH_LINK_FIXED;
 	memset(&old, 0, sizeof(old));
 
 	/* Return what we found */