From patchwork Tue Sep 5 13:27:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 28383 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9CBAA2C2F; Tue, 5 Sep 2017 15:27:55 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 415EF2C17 for ; Tue, 5 Sep 2017 15:27:52 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2017 06:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,480,1498546800"; d="scan'208";a="147655457" Received: from silpixa00398672.ir.intel.com ([10.237.223.128]) by fmsmga005.fm.intel.com with ESMTP; 05 Sep 2017 06:27:50 -0700 From: Harry van Haaren To: dev@dpdk.org Cc: bruce.richardson@intel.com, Harry van Haaren Date: Tue, 5 Sep 2017 14:27:58 +0100 Message-Id: <1504618078-76742-1-git-send-email-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504616613-46803-1-git-send-email-harry.van.haaren@intel.com> References: <1504616613-46803-1-git-send-email-harry.van.haaren@intel.com> Subject: [dpdk-dev] [PATCH v2] buildtools: zero elf info variable in pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit zeros out the elf_info struct at startup of the pmdinfogen code. If it is not zeroed, later in the code gcc produces "may be unused" prints. Clang does not report any issue. This issue is only observed when compiling pmdinfogen as an optimized build, hence this warning is not disabled in the existing Makefile. This commit enables a simplification in the meson build system, removing the requirement for "-Wno-maybe-uninitialized". Signed-off-by: Harry van Haaren Acked-by: Bruce Richardson --- v2: - Added note to commit message about optimized compiles (Bruce) --- buildtools/pmdinfogen/pmdinfogen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c index ba1a12e..e73fc76 100644 --- a/buildtools/pmdinfogen/pmdinfogen.c +++ b/buildtools/pmdinfogen/pmdinfogen.c @@ -397,7 +397,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile) int main(int argc, char **argv) { - struct elf_info info; + struct elf_info info = {0}; int rc = 1; if (argc < 3) {