[dpdk-dev] net/i40e: remove unused and incorrect definition

Message ID 1504463858-20767-1-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jingjing Wu Sept. 3, 2017, 6:37 p.m. UTC
  Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/base/i40e_osdep.h | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Bruce Richardson Sept. 4, 2017, 9:14 a.m. UTC | #1
On Mon, Sep 04, 2017 at 02:37:38AM +0800, Jingjing Wu wrote:
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
>  drivers/net/i40e/base/i40e_osdep.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h
> index c57ecde..fbcb729 100644
> --- a/drivers/net/i40e/base/i40e_osdep.h
> +++ b/drivers/net/i40e/base/i40e_osdep.h
> @@ -99,7 +99,6 @@ typedef enum i40e_status_code i40e_status;
>  #define max(a,b) RTE_MAX(a,b)
>  
>  #define FIELD_SIZEOF(t, f) (sizeof(((t*)0)->f))
> -#define ASSERT(x) if(!(x)) rte_panic("IXGBE: x")
>  
>  #define DEBUGOUT(S)        PMD_DRV_LOG_RAW(DEBUG, S)
>  #define DEBUGOUT1(S, A...) PMD_DRV_LOG_RAW(DEBUG, S, ##A)
> -- 
> 2.7.4
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
Ferruh Yigit Sept. 5, 2017, 3:51 p.m. UTC | #2
On 9/4/2017 10:14 AM, Bruce Richardson wrote:
> On Mon, Sep 04, 2017 at 02:37:38AM +0800, Jingjing Wu wrote:
>> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h
index c57ecde..fbcb729 100644
--- a/drivers/net/i40e/base/i40e_osdep.h
+++ b/drivers/net/i40e/base/i40e_osdep.h
@@ -99,7 +99,6 @@  typedef enum i40e_status_code i40e_status;
 #define max(a,b) RTE_MAX(a,b)
 
 #define FIELD_SIZEOF(t, f) (sizeof(((t*)0)->f))
-#define ASSERT(x) if(!(x)) rte_panic("IXGBE: x")
 
 #define DEBUGOUT(S)        PMD_DRV_LOG_RAW(DEBUG, S)
 #define DEBUGOUT1(S, A...) PMD_DRV_LOG_RAW(DEBUG, S, ##A)