From patchwork Sun Sep 3 15:26:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 28309 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4E8AD7CBB; Sun, 3 Sep 2017 17:27:18 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 6EF1F7CAF; Sun, 3 Sep 2017 17:27:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0yHt1DA2GVK6fTpz2zPxtPy5hIBpJ+kX4gHHDSAbL0I=; b=E1BYX5odnDoeY2800G2UI2ehcOpVZZcbqiVGyiNSklJ5UNWqS5npODxGjz4NkL32wQkSkyF8zY97Fxi70MwWHFL6T0WmZjXcnp7g96fWJsjq2OL61Pmo4LwQ+8yXK7jPiqtu5BfIvh/2/O++/z+pgM4NyvYULmNdn6k/Zq1t82M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM5PR0502MB3044.eurprd05.prod.outlook.com (2603:10a6:203:a1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Sun, 3 Sep 2017 15:27:15 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org, stable@dpdk.org Date: Sun, 3 Sep 2017 18:26:45 +0300 Message-Id: <1504452405-63569-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0102CA0035.eurprd01.prod.exchangelabs.com (2603:10a6:802::48) To AM5PR0502MB3044.eurprd05.prod.outlook.com (2603:10a6:203:a1::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6449ab76-cd5e-4f42-ed1f-08d4f2e0424a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM5PR0502MB3044; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0502MB3044; 3:OL1kpIoyCUekGteKPN6pPySFQDZmRSxDtfOsq9XcGlgooDcWOfFd5Wy2tJZvurhPsX5aA6cOH3HzyYLE9Sl8FMt4a25mLgGisbyGaZM6cF8knBzfc6nj4Z2mptByfK8gLLURWFGriQXAsUMEHsLqKHPKGnXcGm055LPHAr0CiV2HgKqreRHmGSFBgGbaKl//Whgc4pU+H5xmIyD52v8XFCiw3ItsxdBgFB7l24soumJEOZevTkTIW0TjqlpPrC9q; 25:MNx/Qv9gED5dpTzii9JuP/2HEyYhzwNx1WQBxDNzJ8wVyCtN3ClIauz7b51jC6GX42obZ8rlkChGhH8AgldS2NXr2lj4VxGql2FAV5K7kwm+Eah61EHXRsP49M6+SWHeM4MwZOhcBkNoLiZXE9koCNCHsccUro+rpSsRA/rkPG2O/dcjimIAl8ffRQENA+00+MFnkwwXulXvggglgUtwadjXY/oAy4naoF5x0L2H88jpsegE0ckdtAfNfNcqZ3cs9EO98hD9VZikmNclBahEsi4+P3V4+ZOxAmxlvSbel+mWome3yWlnTUc0/O93fJ2mwY0R89nVdMpqXZ3oKrmelQ==; 31:BLig7GFR18L4qJ/V2dtLrdXhcLc5tzZc2wgbmlzrdSxfrCzrBBBFySRaAnqRQIXp4c4aRGiNIpT9KHac7V5VPavRSYgjRM0NRcD6U+BU0K6Yf8HmobzJBq6k+hDADus+qsbgNRYMA2KB8uRFKzSveMPox6mUur8t48P3j32gkmsU0chdH+Zg35TqC7ldQ9xkBVestbdRIgeSX0tmQ77ualYeGes10wFlQ90sjYwLWJY= X-MS-TrafficTypeDiagnostic: AM5PR0502MB3044: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0502MB3044; 20:74iBy6e2FbgrAauUf+J7GTBpUVCiukjmLmPlkJB9n0BYohHJB54rXVBObvrWStwNYQGVCX12I8GgN8yaRbTTgbKyPDAfbBUPswnIhzqheccYXEIqUdlzKT3Sm9vgmv7TS8KmUZ58fZ0okvvFhEfoHEeEzJm/N/sjqC5/6FN2Qg/hyiL3UNi1N4KSmPDVm5N+SUV18xh1WZ8T/6ky8dHhPGx4e21N+/b2FMGeEU5ZJHr9xUMoQzUiSbIS6Kvk7ubWv+zsE2+STz8QLmcGYoXcPIiZIiy5KLnBbRSMllJetds6PUc0iKHHuMvU8Y1VCKhnm1rSdKcf0heFmcOTwrsz3WiKPHk06DUE1YxnrPpvk2Qs90IhdpZ742ODPhKLdjkjFZtKuwmM+nfwjUVLV56HlsqsC9i0OsODuhG8ZPX23VQe4UfCuBTdrHJwUtdJrLn9RyFsYYvdPkyCuOyOqFoT/cMjyyBWvURQEgD9ifPriz9J9kOYt1heeNxsYoutkIsb; 4:kjAH5+r1RfwK6Uq5b9Z0ZQgOY/ZFCdO4O3Y5PBZgdFKNVSV/jmpfCGmWYjj+dG1i2y8LY6eWLVVKdEwh7PguPYvI+NrcCEAB9MlSKV9UDxk+GqR//P40S+15b3nNSMMKAyks9+1h5UBGJhBDpVKWTGTPZobSBs7EIrHB5K4ekKmcb7QG4kqS0mSVPDlb601MJx7/Bi2X3NWo/msNtTc4A7EfWdYAUlXQrx8Y86k25hrqgRNIYwAsifMn6k3q82Xl X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM5PR0502MB3044; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM5PR0502MB3044; X-Forefront-PRVS: 041963B986 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(189002)(199003)(47776003)(8676002)(189998001)(66066001)(478600001)(68736007)(6116002)(50226002)(97736004)(5003940100001)(48376002)(55016002)(50466002)(25786009)(4326008)(69596002)(81166006)(81156014)(3846002)(42186005)(106356001)(7736002)(21086003)(7350300001)(86362001)(33026002)(105586002)(305945005)(5660300001)(50986999)(2906002)(36756003)(53936002)(33646002)(6666003)(6916009)(101416001)(110136004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0502MB3044; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0502MB3044; 23:JZDl9NaAaM4zxKP3IyIWck6RNTNbYuIDOxJVKQ7?= Bup1kz/1JsQqQRmLaqLW6q/vrIQHU8KxMM/7Rg4CV6NdXWaliqXipkz4oC5KUlfVaSeaqQh29TECAp97zubpSI0ljVpTapQZY9uJ3dBK2v9hN3PlxmDLqBDvXEGv3bKJ2UApyiDTyhsL5oW6pLdJ/6liWsoy9iNx2VTRg77nDyE6pr0n2Oz4tKI89zP0IIxpMK9Qru71zMPgO0b4nlkpfGs9VTxC0Vl/Utuhso4WZ7GQiQdYI9KQ1FG2qxoBl05kXN1FchVBFfjwdOhBGAqoOO+WQ5YXVg4Yaipx8Q1LI84ymDNxFYDSq2ogjdZt5nfiF9gpoefrPdDL8372YQryijxM7eR7pphEOnO4YO6Fp/SDqjacJjrif6bFU6fDMrq0HzZrb6NrflPufuY7stCbB1cULnq74d27ww9Zd4cDWYG4D0KetJX7/7GlifgoqjeYRyLchiybrWAeYTgNQvW9rvhBGG+zsWTXgRCogJW5W/HolMXUzeZ6/Lnf2JxGy/v/FjQKMhIrT9vSHF5UZCp57SMuO5gytsR3wwp4KCKXz1YZC1WhFJBrBF665rN989Y9vDmq6eTiHzTEEg0pbU0Kd/6jklxnxPdY7xRRqj1xOpWZ7bdPB2vNX717ijCQPe3pVdpPbs73zOrvLylUXJFrfATVIn6XCs4u9nhg2f/Kux8I/oxqgbqB3+MujiO9+/D2SELMqs4JgQIy8Q3KuUwxZ6AInmnSbf0FaN4pyA/yRGOezXVuJi4HsLRlcigVw9sW1Uj/vEAhllR4BKXIKG+54Ve3c8zmdCON6okTl1b7lLHv6QsX2ZXPZm8+mCLSrpAfsHWLbnUqqtQWd1xF2ksS2dkO26DvZj8/BdyHeoPFQ4/IO/udbEJhPDTJvGwj+dHj4FctSCXmFWclGXhRWKAzJdjt1RF/Q5TNJp/cvgeWghc5D97WUxCLqGVqdcEX4sGinoBpnbFQ5Vh9KlNjy7BfLOjib6BV5fH8EyAjEt5whEA60GwaHyK8ZS7oRPihoyt+HO/YboJw2R1gtAy1dej0pzux3JF7+rHjslRi8eiJhtU/hKQ== X-Microsoft-Exchange-Diagnostics: 1; AM5PR0502MB3044; 6:CubZomZN+TJVSKswYQoV1P7pN8uYnS6fAoxHayVCq2/3ISXq477maWJGQnI6c2yU7LMVTqbZtCzuiOhkuuiAfR1HZ/AYytq+Q9M0I0ipXzhhoWd/DPzAVnLDrL6sp5/zZ/4jAL/THuQsfg9k65Neyye8TKxUe4HvxWrIc98QyKt2rMf3hriIEScx9tqbMqdhoNR54Aeb/iAnLgUTWLCrLPg4NM1NwRK0kpSVr00noaQ50okInSBWgb2ub6qLgznlNtoWj+LA7xC7jxhqwbCwQ1wAHXHwRsViVYUgnu+Tl3DN7PLvG7WDxHIxuOhORsihnuWNZuH9zaQTdhp6Tep4tg==; 5:SW+J3PBGYBVA7PoF/1QqSc12tYU3gcr2mwATqC+NuhPUFbV5r8hikFDRTWmMyaVJoeSH64ijr/Mg3W8OGi+yx1bVBrreERUFEpOzXsb85r3GdOyxgkyMxdAh4FT5w+u/YSHx0c2KVamUGUu/kf3bkQ==; 24:L4VyZW39pHoPutF+eB9rE1I4GFe/3Z0f/Rjo1YhV6I8+Sq3wnBZaUrWvMM5aqTFqloBwpUNmjRL6fdVatDc3ay4n487VFeay65lZ+t8Pc10=; 7:jy/Zmd7keGLB1P/YUbQlypcwt0TcNyroviVgojBh4Nr8DYuBvE92GDwSaLuuC4GdU4HQCiTP24fppeleJDcyCSeRUK6UHHpfeSBUAhKPe5qyNuTfhd2MMVW0V5OfXh6ParpY74xTPfdlrnKWEmRG5JyXC8L2paJk1EiAG0/6o5Oie+tzyILtldy5UDeY+r+NimFCFVw/YovfdiLa2ehPiQqizrLUeZd8bmQ+dYyR7BM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2017 15:27:15.8166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0502MB3044 Subject: [dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The corrupted code don't reply error in case of MAC address adding failure while failsafe PMD was trying to apply configuration to the sub device. Hence, the application may get unwanted packets. The fix adds error report for this case. Fixes: ebea83f899d8 ("net/failsafe: add plug-in support") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c index a3a8cce..fb9bbce 100644 --- a/drivers/net/failsafe/failsafe_ether.c +++ b/drivers/net/failsafe/failsafe_ether.c @@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev, ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea); ERROR("Adding MAC address %s failed", ea_fmt); + return ret; } } /* VLAN filter */