From patchwork Thu Aug 17 14:19:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 27629 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B97D97D93; Thu, 17 Aug 2017 16:20:16 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00074.outbound.protection.outlook.com [40.107.0.74]) by dpdk.org (Postfix) with ESMTP id 34A267CAE; Thu, 17 Aug 2017 16:20:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AFJ4g2UP0gq4ETXhnmTF+NHTjWoTdc6m0dnWTgi5kqM=; b=Y5mm3RDPwuvxaqncWMr5T0sXTrptOSnKTRZqmtm6PM4ip7olh/ZCh2K95dluY+o8ubJZzuJhwBD+mKyNKJv7nmp6SiB9rrTyqBEhnAMVsqZ2+fkImY/5cmXhOUxbE7NdkGmFfAZIIfviPG2pDqtE3t5cpU2+uUNi4fdJ1LSEog8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM5PR0502MB3043.eurprd05.prod.outlook.com (2603:10a6:203:a1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Thu, 17 Aug 2017 14:20:12 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org, Ori Kam , stable@dpdk.org Date: Thu, 17 Aug 2017 17:19:41 +0300 Message-Id: <1502979581-27282-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR0201CA0029.eurprd02.prod.outlook.com (2603:10a6:4:3f::39) To AM5PR0502MB3043.eurprd05.prod.outlook.com (2603:10a6:203:a1::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb9913e8-7532-44a6-4b2f-08d4e57b137e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM5PR0502MB3043; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0502MB3043; 3:Va2qUAnZiqfzKMIMC1FfzxnyWVjj8VyHNPM2z6LevT4Nn77HxyDM9uq9NXPCuuQSkCXszh0mNlHZGmFXeetdozkeVxLoQtzBxCMWLGrYG+zLvG25jujJs/RyC8NxLpyPI6dv8TKLUAAAjVCC0jVMqwGXnz2CzoG6FvFCLrZLktrtwjhxKmlszL+qbpgex3e4oQs2KxWonmZNjlUXNYV7r3HPsnWjgBYatA8HJgy8byiTGsaIYTPYcFDTnbtFU2R1; 25:ZWrPFGSEaYIcu+Rjka/EvQv1U6xR/j/tKqTYWY8L1enStU7Q/x7exrx5U071fPLKchlyT275Fc48W60o7AWnV/FRkYLStO42Cs3NjtvMtqTMtqxbdgIulnuttcAOtRRtuM9M1lLVMjGolKY3UG4QvRu3BHY5aCdvZfruUE3RUIiLBwkUCoitm0lsaGX0e9VcdHCq1BVIppyjyWBBa9dI2MhQt1sKRFNTSCJtteQuhvxwTHCZiV1T+bilg/j/vLaLN5O4I2CS3Zvv/6lDuU/lJPtwQL4ZtHI//dvTk1br2KTnsOvQn1NfdtN9pvQlIrp7E+W2x95+sLzQDtYjuCxJOg==; 31:SagPs5LKWcdfRCkrTBgrgNnLHWS0AzAqoBsX91gquFBQgBbMN6X23l0MFVYRbiE2Dl0VNP/Q0W6mQgFaeJxEQQBD2J0zzrxI6kEW28WxUxI1sQDS6N4Namfflut3eI1pU8JfmTiqOH0zmx841Kq0GTVKa7Z1KE+0h8UqriIlOW9lbD6+RpIXzOj666pLqDXAmlBGnuBDtWs+l46AVXQeIqMGEQC2ZFpYLRoega8D9xY= X-MS-TrafficTypeDiagnostic: AM5PR0502MB3043: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0502MB3043; 20:joKa2NFrqT5pkXvRL98MYIJczgenKugSQdiXoo2ESL6CuSjyO9JntHTg1ZdsUA5Gdaj0Zd2wnLv9DnrWpc85gsUUEo1qEQoxR8VCvCfDJ9355Gp3ApEW19RJ4vGzoQXbEU0ruuPPsNBdFBIAgxw1mDkLcNvubEUbEN6h5+8QfyolubB1B5JrgNGzIcB1CwMBc6JXUJNcyeyuI5dPl3rMB03EHPcCo/Jh9DKdonYVDP+qxkkylCkJSMxUdh3r3XczMSQ9o3cLOnUV0c2EwpKzXah543knYFpSCqBWD2YaV9RmtCBRpZlVXaO4lZBMc4k9rBZr28chwtpXE0HvYiCWbR+GMz2vWYBdaSncCr60/L4UfuG6+VCwDQJlEXbCg8whostxb7+zvFBnqOGpcDwVWoxQ3teHwCbgW3UcQjJ5meU5xwhrIqnXlH+bzVZDSR95QAUL3y+0Y2pytpcU8nXDOynLi65UdXJ1Po86Jqbk1BsyBuV5bOa2USrdFdqGDPhx; 4:Z4AmChvBugNYSgYLJlCLMqvuFrZ2BJZCGQ6+gsCIkdCowqtrCeCxz8NsImTrEIGMKfaP526CeEAX5AeAYkJMwBruH6AjPoPGkJ9zfbrhknbuhmmoLu9FbH32fHOHZfqsI7gsHc3T29zkfXtexVZMzLEGd52/foGvQsj7nlGiiVLt6F0HhrMXOjAOp/St5auxJJ13md2WAKBQ3L397O38QuNxZNEmCcN3kNWfnCaPV7KRpM7tWWXLPQ5Wn/YfVOJI X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM5PR0502MB3043; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM5PR0502MB3043; X-Forefront-PRVS: 0402872DA1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(189002)(199003)(50986999)(7736002)(106356001)(97736004)(7350300001)(33026002)(42186005)(101416001)(86362001)(110136004)(81156014)(66066001)(55016002)(305945005)(47776003)(6666003)(105586002)(4326008)(48376002)(50226002)(5003940100001)(3846002)(6116002)(53936002)(8676002)(25786009)(69596002)(81166006)(50466002)(2906002)(6916009)(478600001)(68736007)(36756003)(21086003)(189998001)(5660300001)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0502MB3043; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0502MB3043; 23:tDkR5PzwLrX0NCBSmlahTjwGm4YWYriha5WMEj9?= gfwonnIvc/uQfCOQI4lFSA0eZMnToi3RDv357mYNf30H3pVajAbB+M+3ghb5bMxM3yn4g3zPBXqdHilS3H6qCjZe1uwXvGOT2Gbw/yoltAvGs/9s1Ir8z0cJaXctN19QEFJ8IWGAO94+6piSalQRIqKY8ohKjmSM5ZrAQ/H3gisWRM7aLDWKI/fsruStTIkLDfICpQUv/6yPMv1HzVhrQ5wm/g+4btNEDpki9y8fb5ZZSLvaSxb3xQM8ne5ovNy/jm+pW8j9zl3CWC1IlWi65ZBlGK3F5NQprPw8eIaM/kvWe/Nh9Y3IaU//a3q5x0Os3MmCe6OIyORqChnDBghFRSjbWjhd4SeAeQfdBYDTuWsxKWA3Sw8V+JhsYwOibxhz/VucjN9xWK26LaSgdjnxkFMSU8PxXZ2gAtiFVaEaUTyxzC/S2RjhEHr5aPtmn0Gqv0IeKDuecgUGq9G/swewNPi1mM57ZO2f/w6lZYtE+hlKRse02RgZ5iSMW1TLj08KALG/58MZM0X+W0t/g1YGyUoU6CbwKqOklviT5I3WdQdgKWnkxKUpwDpY5gax99Vs9hdsWRH0JFx5fVM8QVT4Ey3EUqjQzh+SpSwS6aQZbnQdMa3bWdXmFdd9LN/S3Wkdlk0VZWlcGsxGP6HD4yOjIkWt0KzPJA0e3ZzGzmDmPgCQ6o4puEghav/DPGn7TkJ1nD438FK5TTlaNwu7enf6awHDq+eZbjcsTvM8xMrJKeBmLd+IjUfGlKX3KVRK6Ulg5h01NVxHa5vz79Ipk1dgxfzaf69S4JXNxUmHqEALu6/u0cJEykrksyW03mYvPSgFiUblUPCxwYRjjWxIaAWtNw0CLJMK23wVqcvQ6Tm5Sq88/u7Hbuux3EFWO9Gc/jPojcjAKXCBr86l5n17XECQQhLq7zPPxA79+JkkMfyv23SWIIXgBsdxPCXKDS66zsdMrH5TUHtbytWdXPqfFwIX+viQ8g8dZo5jSc2OcR6mtqoTDf3EJpaZhAnjZwAnZwQOjccmDQVx1EW1zwr0x963cdFV7ANMHSFROk3B41yjvA9VjkA== X-Microsoft-Exchange-Diagnostics: 1; AM5PR0502MB3043; 6:MULFdKHuwHtc5G5di/95kT7SZR7DwD5LV3llCkyQMEfF0LvlPOL/rX4NNxSUC5zUx318OwMH67/+7RHhrDgv4depiV9KGKHNJWufBRQOPT1YxYRMX4sClMWebnF7WH86f+FtLfV22Q23BG/Q3riCtmw5CSkz7NcjSVAEo3WCRgSVq4D4SiYK0u0zJaZ2ga9ZGyz04YabuYn+z/ZuedxHr87wIDkuFUbbGQ7NJQz0kuNB//qXgzlD+s7HXrLEXP72w0ZNRCOFggLxgrupi8fIfNObi/VzrdtnaIw2D6wzmOHepQq7XYHZD0ImIjBHbINXcIWy/4n9s9VPO8m9JWtVhg==; 5:4kXxFHHRIOxlIkHBxl+o05oohH4d0kKuOLmabPnjZqoW8tqR179rS7iX8jaf0aLCK+bss0y93EXArm6cZLFOgl4yt5TCxEj7+Zltn7GZwPnrbqjnfrt1p7DmST0+rcnKtt0gHb8MtEyFbexpL7bH/A==; 24:NC/GsSzTtrPBN9+qvvsSs4ZlO6XoEnTjbbseFO4zjpwBZ4+qbnmDK63SjICW0zLXybkS8lyMoZc85UrfVvaFxdA73jC+aRQLMrHUCC6ApeM=; 7:SYz/ytyoE1yIRaRqiL2Y+kyhzkyBY3HWx6JvRIQ2rngqu/kngk9bPsOkluKSpx7TEgnJsm2RDvmDk4CZRAmXl9mE8Xfctu+/b7tIw0HLy+iYNeg9uSUngySqMLiIO++wQQRTAD3qOPSzB129RzW7Bi9EzESOZNQBHVEjoijUF9LX89QmfUBBe6JqZYgbJ/05mXripFjBjBe8hGWGT+HdkbrdmUAQkP1Jjxd5D2NmhNc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2017 14:20:12.8427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0502MB3043 Subject: [dpdk-dev] [PATCH] net/failsafe: fix parameters parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The corrupted code used wrongly snprintf return value as the number of characters actually copied, in spite of the meanning is the number of characters which would be generated for the given input. It caused to remain zerod bytes between the failsafe command line non sub device parameters indicates end of string. Hence, when rte_kvargs_parse tried to parse all parameters, it got end of string after the first one and the others weren't parsed. So, if the mac parameters was the first in command line it was taken while hotplug_poll was left default, and vice versa. The fix updates the buffer index by dedicated variable contains the copy size, by the way uses memcpy instead of snprintf which is good enouth for this copy scenario. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_args.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index 1f22416..0a98b04 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -271,7 +271,7 @@ static int fs_remove_sub_devices_definition(char params[DEVARGS_MAXLEN]) { char buffer[DEVARGS_MAXLEN] = {0}; - size_t a, b; + size_t a, b, temp; int i; a = 0; @@ -286,12 +286,14 @@ fs_remove_sub_devices_definition(char params[DEVARGS_MAXLEN]) ERROR("Invalid parameter"); return -EINVAL; } - if (params[b] == ',' || params[b] == '\0') - i += snprintf(&buffer[i], b - a + 1, "%s", ¶ms[a]); - if (params[b] == '(') { - size_t start = b; + if (params[b] == ',' || params[b] == '\0') { + temp = b - a + 1; + memcpy(&buffer[i], ¶ms[a], temp); + i += temp; + } else if (params[b] == '(') { + temp = b; b += closing_paren(¶ms[b]); - if (b == start) + if (b == temp) return -EINVAL; b += 1; if (params[b] == '\0')