From patchwork Thu Jun 22 11:20:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Wang X-Patchwork-Id: 25610 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4D11B548B; Thu, 22 Jun 2017 04:34:54 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BE16D532C; Thu, 22 Jun 2017 04:34:52 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2017 19:34:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,371,1493708400"; d="scan'208";a="100312348" Received: from dpdk-wangxiao.sh.intel.com ([10.239.129.170]) by orsmga004.jf.intel.com with ESMTP; 21 Jun 2017 19:34:50 -0700 From: Xiao Wang To: jing.d.chen@intel.com Cc: dev@dpdk.org, stable@dpdk.org, Xiao Wang Date: Thu, 22 Jun 2017 04:20:03 -0700 Message-Id: <1498130403-121027-1-git-send-email-xiao.w.wang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> References: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> Subject: [dpdk-dev] [PATCH v2] net/fm10k: initialize link status in device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fm10k host driver can't manage PHY directly and provides a fake link status by always reporting LINK_UP. We should initialize link status in device start, otherwise application will get LINK_DOWN status when LSC configured. Fixes: 9ae6068c86da ("fm10k: add dev start/stop") Cc: stable@dpdk.org Signed-off-by: Xiao Wang --- v2: * Rewrite commit message, add information about fm10k PHY. * Always do link_update in dev_start. --- drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 7172a0f..c5c4712 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -84,6 +84,8 @@ static void fm10k_MAC_filter_set(struct rte_eth_dev *dev, static void fm10k_set_rx_function(struct rte_eth_dev *dev); static void fm10k_set_tx_function(struct rte_eth_dev *dev); static int fm10k_check_ftag(struct rte_devargs *devargs); +static int fm10k_link_update(struct rte_eth_dev *dev, + __rte_unused int wait_to_complete); struct fm10k_xstats_name_off { char name[RTE_ETH_XSTATS_NAME_SIZE]; @@ -1166,6 +1168,8 @@ static inline int fm10k_glort_valid(struct fm10k_hw *hw) if (!(dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG)) fm10k_vlan_filter_set(dev, hw->mac.default_vid, true); + fm10k_link_update(dev, 0); + return 0; }