From patchwork Mon Jun 12 09:07:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yong Wang X-Patchwork-Id: 25266 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 729882A58; Mon, 12 Jun 2017 11:18:16 +0200 (CEST) Received: from out1.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id 560599E3 for ; Mon, 12 Jun 2017 11:18:12 +0200 (CEST) X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170612170305 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with SMTP; 12 Jun 2017 09:03:05 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v5C9HgSi010414; Mon, 12 Jun 2017 17:17:42 +0800 (GMT-8) (envelope-from wang.yong19@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017061217174447-1280465 ; Mon, 12 Jun 2017 17:17:44 +0800 From: Yong Wang To: helin.zhang@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, Yong Wang Date: Mon, 12 Jun 2017 05:07:00 -0400 Message-Id: <1497258420-11814-1-git-send-email-wang.yong19@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-06-12 17:17:44, Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-06-12 17:17:42, Serialize complete at 2017-06-12 17:17:42 X-MAIL: mse01.zte.com.cn v5C9HgSi010414 X-HQIP: 127.0.0.1 Subject: [dpdk-dev] [PATCH] net/i40e: fix param check to avoid division by 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0, 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by adding a check to parameter 'enabled_tcmap'. Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index c18a93b..d41b213 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4257,6 +4257,11 @@ enum i40e_status_code int i, total_tc = 0; uint16_t qpnum_per_tc, bsf, qp_idx; + if (enabled_tcmap == 0) { + PMD_DRV_LOG(ERR, "Error! enabled tcmap shouldn't be 0"); + return I40E_ERR_PARAM; + } + ret = validate_tcmap_parameter(vsi, enabled_tcmap); if (ret != I40E_SUCCESS) return ret;