diff mbox

[dpdk-dev] net/ring: fix adding MAC addresses

Message ID 1495804685-26501-1-git-send-email-ciwillia@brocade.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Chas Williams May 26, 2017, 1:18 p.m. UTC 
  When .mac_addr_add() was changed to allow a return code, ring was changed
to return -ENOTSUP.  This changes the behavior of the rte_ring driver in
a way that does not maintain backward compatibility.  Additionally, if
the intent is to return -ENOTSUP, you could simply not define the stubs.

Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")

Signed-off-by: Chas Williams <ciwillia@brocade.com>
---
 drivers/net/ring/rte_eth_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit May 30, 2017, 12:45 p.m. UTC | #1 
On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
> When .mac_addr_add() was changed to allow a return code, ring was changed
> to return -ENOTSUP.  This changes the behavior of the rte_ring driver in
> a way that does not maintain backward compatibility.  Additionally, if
> the intent is to return -ENOTSUP, you could simply not define the stubs.
> 
> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
> 
> Signed-off-by: Chas Williams <ciwillia@brocade.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit May 30, 2017, 12:49 p.m. UTC | #2 
On 5/30/2017 1:45 PM, Ferruh Yigit wrote:
> On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
>> When .mac_addr_add() was changed to allow a return code, ring was changed
>> to return -ENOTSUP.  This changes the behavior of the rte_ring driver in
>> a way that does not maintain backward compatibility.  Additionally, if
>> the intent is to return -ENOTSUP, you could simply not define the stubs.
>>
>> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
>>
>> Signed-off-by: Chas Williams <ciwillia@brocade.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 87d2258..d4dce95 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -230,7 +230,7 @@  eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused,
 	uint32_t index __rte_unused,
 	uint32_t vmdq __rte_unused)
 {
-	return -ENOTSUP;
+	return 0;
 }
 
 static void