From patchwork Tue May 16 16:14:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Miller X-Patchwork-Id: 24326 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 111EA3245; Tue, 16 May 2017 18:14:34 +0200 (CEST) Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by dpdk.org (Postfix) with ESMTP id 4569D2BFF for ; Tue, 16 May 2017 18:14:30 +0200 (CEST) Received: by mail-qt0-f196.google.com with SMTP id l39so21493269qtb.1 for ; Tue, 16 May 2017 09:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KUfN+Vumo1xCMChKORRnEUlbFbKVuksh4yOgoWC7K6s=; b=L74V3qchPtEfgZ0vVc0b3TJY2+9bxq0dM5Re2faIWyL3qam5U9KnJgviiXJk/JNdfJ HibwLLrU3b/LFN6Zs+uL3y7zUPxAeknN6jQRFknZhLLq8xFsFmBKjnxZCZDMeCOoZfSY q1SoQIAmrMGBxP7Ec7hnt+zg9bA1gB3IQy1O6RnYayTgNW06DlKQotiEfehgQ4tge2Qv /WbLPVCYCs+XBgoBSelioyPnhZLyA5jPTlGzTmKzhmFhFItPvmkVfw9yU9pQp+nV9KQz nYfSlvWzqnKXhDtoKuaDxO5t7KXuAPRGahkvSETUOCX043gtq4+U6A/8MYv+PbtfBc77 pk6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KUfN+Vumo1xCMChKORRnEUlbFbKVuksh4yOgoWC7K6s=; b=JyM1ADHIXwevceME6QuCeLqlNbytYYtafnmFq2tCibeVa3+nxHk8y5ck854++VwYgX Et8wpWF//mEClcw55dJil5yKHTjbz0GHVlzaHaQKyhFfGxap0IsYx33OrS8FKzZ8jgvC EmaYGR6uM59GsF/vvcUUU+fBMLGBobNcnQSAMYYkxmFR2A9sd5p0SP4VvXMhhKAzCtVf YLcFCrPSEc7SggVPS3bs3WDmNBvX0sOg/4pffIDsUt7Oe6tZZ00bHsenaEnC03i20uTa EzqoIvYmfcBNr3DZFcWJ3U5DIz/84ESKuqOwsw/rgJN9bKkdyHebroPdp7XsI2HjHHnm PwMw== X-Gm-Message-State: AODbwcAt4Am3VoVoD9hW3L0pKbjPg3JYk+QsLfmVAwv0OChYbP2TH+Bf SkIxiY02Ks3x4A== X-Received: by 10.200.51.70 with SMTP id u6mr10837215qta.122.1494951269775; Tue, 16 May 2017 09:14:29 -0700 (PDT) Received: from LOT3.Home (h69-21-89-58.cntcnh.dsl.dynamic.tds.net. [69.21.89.58]) by smtp.gmail.com with ESMTPSA id y31sm11181852qtb.27.2017.05.16.09.14.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 May 2017 09:14:29 -0700 (PDT) From: John Miller To: dev@dpdk.org Cc: ed.czeck@atomicrules.com, shepard.siegel@atomicrules.com, John Miller Date: Tue, 16 May 2017 12:14:18 -0400 Message-Id: <1494951258-11232-4-git-send-email-john.miller@atomicrules.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> References: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> Subject: [dpdk-dev] [PATCH 4/4] net/ark: fix return value of null not checked X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 144517 Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville") Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index f8fb359..017817e 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -899,6 +899,12 @@ static void eth_ark_macaddr_remove(struct rte_eth_dev *dev, int size = 0; int first = 1; + if (file == NULL) { + PMD_DRV_LOG(ERR, "Unable to open " + "config file %s\n", value); + return -1; + } + while (fgets(line, sizeof(line), file)) { size += strlen(line); if (size >= ARK_MAX_ARG_LEN) {