From patchwork Tue May 16 16:14:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Miller X-Patchwork-Id: 24325 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 461662C16; Tue, 16 May 2017 18:14:31 +0200 (CEST) Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by dpdk.org (Postfix) with ESMTP id D0AF22A62 for ; Tue, 16 May 2017 18:14:27 +0200 (CEST) Received: by mail-qk0-f196.google.com with SMTP id k74so23554269qke.2 for ; Tue, 16 May 2017 09:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xN92fKhKt8klu+yAbEgfboRHY6K61l/bOKBnp46L8Yg=; b=Dm7GnH0u0ivKhBbxE84KHGmsACvx/JFdIo4rfft3lk6EKc6S9q1n6iSPYQVbcbDvvs 5N3ZOkoAnbBwO6QLNW39khvBbXf5dINNBpbQ1jVFAlo5LXkc9SCwnfObMzMen5+9QPLq U1xUtEF0+FvLt+5GX+qQzXdQZ6h08Cp0yM/5eZgGKc86XDQlqZbBLpcjWH5BS49bKM4D 10M7S1LssOV8R8nDbPC2aarNndPy8Cr5G11lmz1Et1vYvOYE3Qxm9lk8BoTYFFhXcj4U Ws73YBMSADVMepip5m1b8IpaFZ74z9XAQxvJQf1dzynG9eoCyvMr22ZPPpMRY7u1eV2F yZ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xN92fKhKt8klu+yAbEgfboRHY6K61l/bOKBnp46L8Yg=; b=Hz/wUg2LXjAI3WTUpqfD3NH0PtSkmO9pIQe2fjbfzZY9HCv6ZkpYIqsF4Ch79Msmpv 7a7qcDLPOx51qFi42EBAOoOJpNfZA/xmK3blt1QjDh8NLBCpxdRPWBj071CXUXKSxH7k zvkaBZ4lgXVN4S8Xlt2FExLYPhTZ7sB/byUly3qpBsl6dcx7csBj/MTl1LRgzNFMpPuJ 4MDWeFWFSHyYM65kK3q2Aa0T+qfr7NhFYOQ80appvBRhWW5B/ml7oFEwhwBBlaXzCoZq MfVWN15RFpGyQTv9EjM+E/dwexwnnBKvYO9ae4DBszC9kQY6DzDKM/TCVKe1HkQ+MMba r0sQ== X-Gm-Message-State: AODbwcDLPg0SBBJlOygIajdszXqpndXqt0eliydeZQQwqs/tzo1f1ZA8 gGhDmPPKclI05Q== X-Received: by 10.55.214.7 with SMTP id t7mr10131791qki.170.1494951267263; Tue, 16 May 2017 09:14:27 -0700 (PDT) Received: from LOT3.Home (h69-21-89-58.cntcnh.dsl.dynamic.tds.net. [69.21.89.58]) by smtp.gmail.com with ESMTPSA id y31sm11181852qtb.27.2017.05.16.09.14.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 May 2017 09:14:26 -0700 (PDT) From: John Miller To: dev@dpdk.org Cc: ed.czeck@atomicrules.com, shepard.siegel@atomicrules.com, John Miller Date: Tue, 16 May 2017 12:14:17 -0400 Message-Id: <1494951258-11232-3-git-send-email-john.miller@atomicrules.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> References: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> Subject: [dpdk-dev] [PATCH 3/4] net/ark: fix null pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 144520 Fixes: 727b3fe292bc ("net/ark: integrate PMD") Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index 9143fc4..f8fb359 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -516,11 +516,7 @@ static void eth_ark_macaddr_remove(struct rte_eth_dev *dev, dev->dev_ops = NULL; dev->rx_pkt_burst = NULL; dev->tx_pkt_burst = NULL; - if (dev->data->mac_addrs) - rte_free(dev->data->mac_addrs); - if (dev->data) - rte_free(dev->data); - + rte_free(dev->data->mac_addrs); return 0; }