From patchwork Wed Mar 1 17:44:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allain Legacy X-Patchwork-Id: 21025 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 20EE02BAA; Wed, 1 Mar 2017 18:44:34 +0100 (CET) Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by dpdk.org (Postfix) with ESMTP id 673602B9D for ; Wed, 1 Mar 2017 18:44:28 +0100 (CET) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v21HiQ9n001341 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Wed, 1 Mar 2017 09:44:26 -0800 Received: from yow-cgts4-lx.wrs.com (128.224.145.137) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.294.0; Wed, 1 Mar 2017 09:44:25 -0800 From: Allain Legacy To: CC: Date: Wed, 1 Mar 2017 12:44:19 -0500 Message-ID: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [128.224.145.137] Subject: [dpdk-dev] [PATCH] devtools: add long lines to the list of options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The checkpatch.pl tool is flagging warnings on long debug log strings. Since splitting these strings makes it difficult to search for logs it is preferred to allow these as exceptions to the long line rule. The addition of the LONG_LINE_STRINGS to the list of exceptions will allow lines that end with a string to exceed the maximum line length, but lines that end with variables or other constructs will still be flagged as errors. Also, lines that make use of PRIx64 with string concatenation will still be flagged if the beginning of the last string fragment begins after the 80 character threshold. Signed-off-by: Allain Legacy --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 78e155e..26ff419 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ -NEW_TYPEDEFS,COMPARISON_TO_NULL" +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING" print_usage () { cat <<- END_OF_HELP