diff mbox

[dpdk-dev,2/2] net/ena: fix return of hash control flushing

Message ID 1487075863-3056-2-git-send-email-wang.yong19@zte.com.cn (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yong Wang Feb. 14, 2017, 12:37 p.m. UTC 
  In function ena_com_set_hash_ctrl(), the return value is assigned to
"ret" variable, but it is not returned. Fix it by adding the return.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/ena/base/ena_com.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Medala March 14, 2017, 5:59 p.m. UTC | #1 
Acked-by: Jan Medala <jan@semihalf.com>

  Jan

2017-02-14 13:37 GMT+01:00 Yong Wang <wang.yong19@zte.com.cn>:

> In function ena_com_set_hash_ctrl(), the return value is assigned to
> "ret" variable, but it is not returned. Fix it by adding the return.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  drivers/net/ena/base/ena_com.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_
> com.c
> index 39356d2..38a0587 100644
> --- a/drivers/net/ena/base/ena_com.c
> +++ b/drivers/net/ena/base/ena_com.c
> @@ -2278,7 +2278,7 @@ int ena_com_set_hash_ctrl(struct ena_com_dev
> *ena_dev)
>                                             sizeof(resp));
>         if (unlikely(ret)) {
>                 ena_trc_err("Failed to set hash input. error: %d\n", ret);
> -               ret = ENA_COM_INVAL;
> +               return ENA_COM_INVAL;
>         }
>
>         return 0;
> --
> 1.8.3.1
>
>
>
Ferruh Yigit March 14, 2017, 6:11 p.m. UTC | #2 
On 3/14/2017 5:59 PM, Jan Mędala wrote:
<...>
>> In function ena_com_set_hash_ctrl(), the return value is assigned to
>> "ret" variable, but it is not returned. Fix it by adding the return.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

> Acked-by: Jan Medala <jan@semihalf.com>

    Fixes: 99ecfbf845b3 ("ena: import communication layer")
    Cc: stable@dpdk.org

Series applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index 39356d2..38a0587 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -2278,7 +2278,7 @@  int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
 					    sizeof(resp));
 	if (unlikely(ret)) {
 		ena_trc_err("Failed to set hash input. error: %d\n", ret);
-		ret = ENA_COM_INVAL;
+		return ENA_COM_INVAL;
 	}
 
 	return 0;