diff mbox

[dpdk-dev,v2] examples/vhost: fix the wrong initialization of lcore_ids

Message ID 1484125186-31667-1-git-send-email-wang.yong19@zte.com.cn (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Yong Wang Jan. 11, 2017, 8:59 a.m. UTC 
  when "TAILQ_INIT()" was added to the loop of "for (lcore_id = 0; ...)"
statement, the assignment to "lcore_ids" was removed out of the loop.
It changed the original initialization of "lcore_ids".

Fix it by introducing two braces.

Fixes: 45657a5c6861 ("examples/vhost: use tailq to link vhost devices")

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

v2:
* fix the coding style error of '++'.
---
 examples/vhost/main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Yuanhan Liu Jan. 12, 2017, 3:06 a.m. UTC | #1 
On Wed, Jan 11, 2017 at 03:59:46AM -0500, Yong Wang wrote:
> when "TAILQ_INIT()" was added to the loop of "for (lcore_id = 0; ...)"
> statement, the assignment to "lcore_ids" was removed out of the loop.
> It changed the original initialization of "lcore_ids".

opps.... and nice catch! Thanks.
> 
> Fix it by introducing two braces.
> 
> Fixes: 45657a5c6861 ("examples/vhost: use tailq to link vhost devices")
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

Applied to dpdk-next-virtio.

	--yliu
diff mbox

Patch

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index ac1f6e2..91853ec 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1436,11 +1436,12 @@  static inline void __attribute__((always_inline))
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "Invalid argument\n");
 
-	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++)
+	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
 		TAILQ_INIT(&lcore_info[lcore_id].vdev_list);
 
 		if (rte_lcore_is_enabled(lcore_id))
-			lcore_ids[core_id ++] = lcore_id;
+			lcore_ids[core_id++] = lcore_id;
+	}
 
 	if (rte_lcore_count() > RTE_MAX_LCORE)
 		rte_exit(EXIT_FAILURE,"Not enough cores\n");