From patchwork Tue Jan 10 18:42:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Remy Horton X-Patchwork-Id: 19093 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8879A5424; Tue, 10 Jan 2017 19:42:49 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2E987282 for ; Tue, 10 Jan 2017 19:42:47 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 10 Jan 2017 10:42:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208";a="47541881" Received: from rhorton-mobl.ger.corp.intel.com (HELO VM.ger.corp.intel.com) ([10.252.2.241]) by orsmga004.jf.intel.com with ESMTP; 10 Jan 2017 10:42:45 -0800 From: Remy Horton To: dev@dpdk.org, Thomas Monjalon Date: Wed, 11 Jan 2017 02:42:44 +0800 Message-Id: <1484073764-15001-1-git-send-email-remy.horton@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Even though only primary processes should setup PMDs, secondary processes were also blanket zeroing ethernet device memory. The result was NULL dereference crashes in multi-process setups. Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Signed-off-by: Remy Horton --- doc/guides/rel_notes/release_17_02.rst | 6 ++++++ lib/librte_ether/rte_ethdev.c | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst index 180af82..20a4ced 100644 --- a/doc/guides/rel_notes/release_17_02.rst +++ b/doc/guides/rel_notes/release_17_02.rst @@ -72,6 +72,12 @@ Resolved Issues EAL ~~~ +* **ethdev: Fixed crash with multi-processing.** + + Even though only primary processes should setup PMDs, secondary + processes were also blanket zeroing ethernet device memory. The + result was NULL dereference crashes in multi-process setups. + Drivers ~~~~~~~ diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 9dea1f1..a681982 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -212,7 +212,8 @@ rte_eth_dev_allocate(const char *name) eth_dev = &rte_eth_devices[port_id]; eth_dev->data = &rte_eth_dev_data[port_id]; - memset(eth_dev->data, 0, sizeof(*eth_dev->data)); + if (rte_eal_process_type() == RTE_PROC_PRIMARY) + memset(eth_dev->data, 0, sizeof(*eth_dev->data)); snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name); eth_dev->data->port_id = port_id; eth_dev->data->mtu = ETHER_MTU;