From patchwork Wed Nov 30 12:32:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yong Wang X-Patchwork-Id: 17341 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 165215582; Wed, 30 Nov 2016 12:32:07 +0100 (CET) Received: from mx5.zte.com.cn (mx5.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 849774A59 for ; Wed, 30 Nov 2016 12:32:03 +0100 (CET) X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20161130193100 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 30 Nov 2016 11:31:00 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id uAUBVr2v021156; Wed, 30 Nov 2016 19:31:53 +0800 (GMT-8) (envelope-from wang.yong19@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2016113019315877-156715 ; Wed, 30 Nov 2016 19:31:58 +0800 From: Yong Wang To: harish.patil@qlogic.com Cc: dev@dpdk.org, Yong Wang Date: Wed, 30 Nov 2016 07:32:09 -0500 Message-Id: <1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2016-11-30 19:31:59, Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2016-11-30 19:31:34, Serialize complete at 2016-11-30 19:31:34 X-MAIL: mse01.zte.com.cn uAUBVr2v021156 X-HQIP: 127.0.0.1 Subject: [dpdk-dev] [PATCH] net/qede: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Current code does not close 'fd' on function exit, leaking resources. Signed-off-by: Yong Wang Acked-by: Harish Patil --- drivers/net/qede/qede_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index ab22409..b666e1c 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev) if (fstat(fd, &st) < 0) { DP_NOTICE(edev, false, "Can't stat firmware file\n"); + close(fd); return -1; } @@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev) if (edev->fw_len < 104) { DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n", edev->fw_len); + close(fd); return -EINVAL; } + close(fd); return 0; } #endif