| Message ID | 1473850242-29734-1-git-send-email-lboccass@brocade.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi <lboccass@brocade.com> wrote: > RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it > impossible to override via an environment variable, and forces users > to pass it inline in the make call. > Use ?= instead to have it pick up the environment variable as well. > > Cc: <stable@dpdk.org> > Signed-off-by: Luca Boccassi <lboccass@brocade.com> > Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
2016-09-14 12:54, Christian Ehrhardt: > On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi <lboccass@brocade.com> > wrote: > > > RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it > > impossible to override via an environment variable, and forces users > > to pass it inline in the make call. > > Use ?= instead to have it pick up the environment variable as well. > > > > Cc: <stable@dpdk.org> > > Signed-off-by: Luca Boccassi <lboccass@brocade.com> > > Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> I'm surprised you need to pass it via an environment variable. Applied, thanks
diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk index 28982a5..21ee0ca 100644 --- a/mk/rte.vars.mk +++ b/mk/rte.vars.mk @@ -104,7 +104,7 @@ export RTE_TOOLCHAIN # developer build automatically enabled in a git tree ifneq ($(wildcard $(RTE_SDK)/.git),) -RTE_DEVEL_BUILD := y +RTE_DEVEL_BUILD ?= y endif # SRCDIR is the current source directory
RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it impossible to override via an environment variable, and forces users to pass it inline in the make call. Use ?= instead to have it pick up the environment variable as well. Cc: <stable@dpdk.org> Signed-off-by: Luca Boccassi <lboccass@brocade.com> --- mk/rte.vars.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)