From patchwork Thu Sep 8 12:33:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 15701 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B04C53792; Thu, 8 Sep 2016 14:33:07 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 049FB376C for ; Thu, 8 Sep 2016 14:33:05 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 08 Sep 2016 05:33:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.30,300,1470726000"; d="scan'208"; a="1037027102" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 08 Sep 2016 05:33:04 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u88CX3dR025183; Thu, 8 Sep 2016 13:33:03 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id u88CX3fg027487; Thu, 8 Sep 2016 13:33:03 +0100 Received: (from fyigit@localhost) by sivswdev02.ir.intel.com with id u88CX2Nd027483; Thu, 8 Sep 2016 13:33:02 +0100 X-Authentication-Warning: sivswdev02.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f From: Ferruh Yigit To: dev@dpdk.org Cc: Thomas Monjalon Date: Thu, 8 Sep 2016 13:33:01 +0100 Message-Id: <1473337981-27378-1-git-send-email-ferruh.yigit@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] mk: remove module compilation noise X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following log generated by Linux kernel Makefiles: (cat /dev/null; echo kernel/.../build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko;) > .../build/lib/librte_eal/linuxapp/igb_uio/modules.order This happens because $(Q) used for both Linux and DPDK makefiles and DPDK unsets this variable when V=0, which makes Linux verbose. More details: rte.modules calls kernel makefile with V=0 argument kernel makefile includes igb_uio/Makefile, which includes rte.vars.mk rte.vars.mk unsets Q when V=0 Signed-off-by: Ferruh Yigit --- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.module.mk b/mk/rte.module.mk index 53ed4fe..10cb667 100644 --- a/mk/rte.module.mk +++ b/mk/rte.module.mk @@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ - CC="$(KERNELCC)" CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) + CC="$(KERNELCC)" CROSS_COMPILE=$(CROSS) V=$(if $V,1,) # install module in $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko