From patchwork Wed Sep 7 14:08:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 15669 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 3D03291B4; Wed, 7 Sep 2016 16:10:16 +0200 (CEST) Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0053.outbound.protection.outlook.com [104.47.38.53]) by dpdk.org (Postfix) with ESMTP id 80C0F91B0 for ; Wed, 7 Sep 2016 16:10:13 +0200 (CEST) Received: from BN3PR0301CA0067.namprd03.prod.outlook.com (10.160.152.163) by BN6PR03MB2436.namprd03.prod.outlook.com (10.168.223.14) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9; Wed, 7 Sep 2016 14:10:11 +0000 Received: from BN1BFFO11FD008.protection.gbl (2a01:111:f400:7c10::1:146) by BN3PR0301CA0067.outlook.office365.com (2a01:111:e400:401e::35) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9 via Frontend Transport; Wed, 7 Sep 2016 14:10:12 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none; rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD008.mail.protection.outlook.com (10.58.144.71) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Wed, 7 Sep 2016 14:10:11 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u87E8BD1013556; Wed, 7 Sep 2016 07:10:08 -0700 From: Shreyansh Jain To: CC: , Shreyansh Jain , "Jan Viktorin" Date: Wed, 7 Sep 2016 19:38:08 +0530 Message-ID: <1473257297-7221-17-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131177310112174999; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(47776003)(36756003)(106466001)(8666005)(105606002)(356003)(97736004)(7846002)(8936002)(81166006)(76176999)(19580405001)(110136002)(19580395003)(81156014)(50986999)(86362001)(575784001)(2351001)(8676002)(5660300001)(33646002)(50226002)(229853001)(77096005)(85426001)(626004)(92566002)(189998001)(586003)(87936001)(305945005)(68736007)(2950100001)(5003940100001)(4326007)(48376002)(50466002)(104016004)(2906002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2436; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD008; 1:CVp54V1HkHGUCelWCO1DhdCN0uSO5t69fPQaOcMPzzaq0F4sQRWNFEQlUA+aJA5zW5fai/MV9P0qdoKtltDwdGD/sOY7WB9DkFczp4RJrXSuHmg6xzLJU6kqYm+IQXZz95IYP/u4L0ApQhawE0LF3NWVFXkMmjA967A9uZX9vlzhkY19BbM30kQw7QlK0N4iwh0rQNuj4+OnFsesOPy/TaK0Jivflyq3ft5wZ2TiYceuHcAorCEhr5UhW95rASx0gP38yw8u1jjzxZmdYHKAHDG+SKCYQSG+JSEZAdQWNDiSKvchx+EhSFV3Fh1+kfGiWLT9BXHnOxlojnLtNWt1onUwqyLnNmy9c5dD0Upf2WNOgIba3F8WvGZSqcM14RYTlaEDmsPMkw+t0qKlspjAzmHeK4xv/r4SQkNBbVKGP1pUTITdsEOi5P4DlO9n5PqEuwNMt20PflPVhr7tl1Fzt/ouEK0SgDOtDYcy68qhhUu+nIff3q/M3y3lFUOG96yQ9ZLnVoSm28A1Vo7BZDv/bPcA8iyZqoRIlBEUDkxoT/beiNWLWsFHg0VQ6eoMKWmjRDnzDUsJPBMs9JCCqc66y2fYrz+DUlw17xdUcvoSTre9r1VXdC/BWx26EgUfYkXs MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 0fd65d66-65aa-4d71-d397-08d3d728ae4a X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 2:16uA84WEVZvOihMTaXLNia/qGCZUpVbjtT7dIyrPXWPTaOBD4PFxWZGo6dTSVtpesFX6xCtr/xevrE2BMuqAbB0BaaS4O8RAmNoFozYjSi6P+f0GPuQ7TFfqNp4IvF1/fTL+dD57PTrKVLjRvgEJYVTY4aDKfsLImD/wTddHCwbDQOLHA9eeEc2rtV3BegKl; 3:kmelQZ/xTaROXRLxAJytDXi2vF4yomEFUZjsxEnbr4L21XrVCaZy681J0PGRo5MMYzFF7I+PXjfJ8McQIwcjJ00Hg3cCFq5izqUsKIZaULDUTWq7GngM256v7LPiX0t9VMB9yaVfG2iBkDsy1Pmy7aZgwHZAnd83Ycf39r5NZz5rn0yrjVPaLhHTeD5cHnbQutuO5NzZwbZ+JUj58lVa6nHW7efxjlVVhSMtPAo9AVE=; 25:bm67yBGGSgrWwH4IuCasYjmYiGDp2E4J2Cji+JIbC43RuFpQUfYbKS9cLaF54koCbJ3nss3AFGwUY2eAc3Nd0GmI3HTmhuMzI5wbCT9fZfCE0crTwjgd9vfdPcrh21svw72dkXtbXualG0A2zmetq2s2oyLqSdp+595v+Ycv3N60Dl7qiGgDvh2DHyRvGS4CNI8p7wMSe6J6zj4jf3nFXBuf1LuQGco0q7NdgGxjh0z+GkfIwRS2RpIHVSsZyWooW8BYY67G1YnlSDHq7hrdXVa5kharPCY70yQot9nQPwoIBcA8XKVlbvfPUYsORBbl2esqGu0mT8qi0u2AW1gjkiicPJ4mZv/CsCn5pi+DSbjjNonCJbmS+6KO4lMJLrjXn394j3BM539GbDdkdfRQ5l5kC3xYrotgoqw/2yAhNlU= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR03MB2436; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 31:UI7tsb6ZXSFjRDhACkhgOb3cm80vQK7jP+9TkwoO2vsa1+x6q2NWQy079PvCl6UqGC5+kV93kx1uZyF2wM2Vh8HzPwiGsbOse6R+hqhb/5Jzqe+qa7YKVKfvOQzFYjCVK7MV25zqkDsuQWRHLaB10AtlEvelh0bApQq8Dc+U05Ur/Fu7tZQgURFwd7YXgr4ghgdpwq1zYoapJh00NZ7yAtd8R5NZt1kEX4N58KMpoaI=; 4:2PMWxmv5/9DQL50XWaXScmg8G8Mi9+P0wBYHjBbYLfv6eXMhclzEeZvws/zV6fgBf5y5VNk/3ErBJ+Qf0E7cA0doFtWWWWjlfa9FB/pWjVAJ9WH4Y42VCgs2Xjdnz6KMpNca7D8xIDxhg1h0wr65YIuIkmMNYudF3FxOPB8sFg30US8Yd0XkZgd8ywFfn0o163VokG6X5MXPvLwsSFOW2m282K/aQ8NTCeTL9dFMZF1/lJwL/EasEVae8vtG7MbMlxOeTJwefSSLUd6mmnWSJItiSnmJUJjCcZJeVu0sLPl+YZ1BQ4+ip2X2m20o+YZKly/LjdSIOsQBVm7TYSEAB/0KmxbERJZs7Lrg1XLuMOArIG3MKLMoSexA8kIc2ORiA9zzmIQnsTstOgbrd6nZxaX1hNdpij79xytVkB5HPXtF67BO0a04jRKWg7pui9ulnNr7w2g3flhkJ4maBewTxDMrM/sG/50RIYWt2TtuJ3AlpWhWOwmHnIzSBTXjypZ+SgDQPdLv1vWc3r8bld9AsqztsLkKm8fKrx8McnA8U38= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13017025)(13015025)(13023025)(13024025)(13018025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BN6PR03MB2436; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2436; X-Forefront-PRVS: 0058ABBBC7 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR03MB2436; 23:by1alnQWpZf483Md8WVYQebFHNp7EG0i6iHkqwG8g?= =?us-ascii?Q?r+5+AkY9KF2kkKfm2GXQECsKnUeicyDJNykYskciL5Ea6Y7pG1N5hggt/72t?= =?us-ascii?Q?wDYMbHGtjdGRAj1AlYvHN0o3Yy39yIry4wANkOvk609YZgg5WoRuHWg9uZKU?= =?us-ascii?Q?gHgFV0gL1V38tC6p4DPtoi7ov0RNtyTySN6hBONfqtZZkLTEVGX0dkiaoiqs?= =?us-ascii?Q?DGxy0FR6fVjiGe29oGVsZ6fyeHI2o2kZ98WCYQ5z2PxEFa0X8wUbrtOcWT7u?= =?us-ascii?Q?YTyVNdo2VyoWvh54pAEnsWtpk02Dgh1FOMVSdLwf8EB4jfIT8Lfmr6QqUAa3?= =?us-ascii?Q?2umaJo0EsU7nDvqSnPQaea126CV03Pw3aCHzjAvdTm6fvVYLAY5dvO6mmFPo?= =?us-ascii?Q?g7lRyQv/C9zNcxPcm5dS5SsOFWpLhi5b1/kYfPhzMJvk3J/L/S1rGsCX9tL0?= =?us-ascii?Q?zPRXRMXw176mfCQ5Ivs8GNIkoG6LuyFuTSL/QKV2QHMycXjxxuIBXd1C+umY?= =?us-ascii?Q?+0n/g9xv/TJB8h53bbJDc/KcXr8t2GtIoHQvsxqudo4BHAIP8+70auW1uWEy?= =?us-ascii?Q?eiH0BQ2UmL3GbBna4qRW2XoC3duabAiZYHbrjYN2Ch+fienhREuujpxCE1un?= =?us-ascii?Q?D1CSeJQQxRRfS03bTXl8eLs9TnDB3u9jxwzSOKFi3Ucfsu8YQKSs8aWXuYQd?= =?us-ascii?Q?3myv7t4UN3qQH4FUTfFMg4e51h4CnzWLXCnlh/WsVhmOCH/GBAPXXGjjlYGO?= =?us-ascii?Q?ZcqjljxTNem0VllbDuNUSe4PnEyBj8KZXkD/SToX+xGQkM/+reN5J1lOlCJv?= =?us-ascii?Q?MCquOfDg0xmh/BfQvnTT8/KuQGG9ZSnjHKddfNlkS8HWrqha1KvS8cEtV3Ef?= =?us-ascii?Q?p75EE/efZ1kl8iO7GbT/x4wROH3TFo5mdz272wkWCrv28/e/aJr/my77Ikgg?= =?us-ascii?Q?zNUrK4Rj8fMb8j9vF2mk2hPxVehvryuAstmsCOJSysI/UKj34Y6h86fp9reh?= =?us-ascii?Q?aXV8OWxna8r3IA/ALk70tNj0uLZsBv/cI5FywBxwYUf2Qh8np84YszpS8Cof?= =?us-ascii?Q?NM8leXgL8mS/rhMTkGFsmjaHaje6aWGFNR2pP4Uwj6s5dSGHfnmhHXXoxvs4?= =?us-ascii?Q?RbQxGptv4qMYA8dq7xgma1ky+1sOQCWK1rAJxVqrIjydy4hAI0BxA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 6:oUchK+X1e3H9EqAb17or6CbM/b74igAjKCYXN27bQyCmjhLUzNuKpAs10PZ1j6ThEc3XC9iz/0cpssob6II9+04Jg/4T/hTN7SXWHcVcjngX+gk0jkLAQvDNoSofabvDmIQ0x1uBsLn45gdhtxXiFror20RrpYR+juhHZU3YR7ocFoFGsvA2nLL89lzCgfPYZ+g0VPh22QdmIACMe3afiGFlkuu61dxh27wAxHzdum7Yjh9y3iw010SW3sZ/8k03rzbQm804rO3DBPBeiJwYfinqGnTo4LL7ABq94tt3KKg=; 5:pKej5A/vHR48OTteJXizriolGBek9oMUyrozMNoZ4+j7efTGV191G57heRDaiqs5rlPYAbxlV65t1acc6vVUPB5YdAm3P/YiDolr7ZTNclviznvv15CvotW2otNRmSnlPBS9Be1YvAknSf4ar+320YFCSFme9rrQlVl2wAZkAWQ=; 24:3YqxZ33SgreNWxsf3MhT0hnS3CL/CAFb17HWZ79Ufm4vTeOlhGDOb3flgkHcDVeg0+B92W9/5Y1MjXejwJ2/oxABeR47et9tgvTUixuhtJQ=; 7:y/62MMHJtTHD0Yo16MnVPqRWMFp91V09IA5R+dPD2HcAriro/eTqU8P1CzkGpLl0UJTNAy6gL3H2RB+ddzN/u+m4jTU2EQWdcLahT0kseJjkby5L5pI3Jw/sqdd4z/1p8uo0zWgNNip8PDkCH1GF+gm7WI8jCSChhMeEE6oCyVntcH3PAiY20JUTjl5yIFBUH/05fVrSlrEUGuzQynrlrcqjPD1Y1Qs7c42zwS/JJB9r6GgqOaA+zUXHkuSj1GJS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2016 14:10:11.0302 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2436 Subject: [dpdk-dev] [PATCH v9 16/25] eal: Remove PDEV/VDEV unused code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" - Remove checks for VDEV from rte_eal_vdev_(init/uninint) as all devices are inherently virtual here. - PDEVs perform PCI specific inits - rte_eal_dev_init() need not call rte_driver->init(); Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_dev.c | 8 -------- lib/librte_eal/common/eal_common_vdev.c | 6 ------ 2 files changed, 14 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 555e0d9..afa33fa 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -67,7 +67,6 @@ int rte_eal_dev_init(void) { struct rte_devargs *devargs; - struct rte_driver *driver; /* * Note that the dev_driver_list is populated here @@ -89,13 +88,6 @@ rte_eal_dev_init(void) } } - /* Once the vdevs are initalized, start calling all the pdev drivers */ - TAILQ_FOREACH(driver, &dev_driver_list, next) { - if (driver->type != PMD_PDEV) - continue; - /* PDEV drivers don't get passed any parameters */ - driver->init(NULL, NULL); - } return 0; } diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index d225e86..e1ca8e0 100644 --- a/lib/librte_eal/common/eal_common_vdev.c +++ b/lib/librte_eal/common/eal_common_vdev.c @@ -66,9 +66,6 @@ rte_eal_vdev_init(const char *name, const char *args) return -EINVAL; TAILQ_FOREACH(driver, &vdev_driver_list, next) { - if (driver->driver.type != PMD_VDEV) - continue; - /* * search a driver prefix in virtual device name. * For example, if the driver is pcap PMD, driver->name @@ -92,9 +89,6 @@ rte_eal_vdev_uninit(const char *name) return -EINVAL; TAILQ_FOREACH(driver, &vdev_driver_list, next) { - if (driver->driver.type != PMD_VDEV) - continue; - /* * search a driver prefix in virtual device name. * For example, if the driver is pcap PMD, driver->name