[dpdk-dev,v2,1/1] dpdk_procinfo: check for primary process

Message ID 1473244670-154926-1-git-send-email-maryam.tahhan@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Tahhan, Maryam Sept. 7, 2016, 10:37 a.m. UTC
  Add a check to see if the primary process is running and exit gracefully if it
is not.
v2:
* Updated to tone down message and remove unnecessary brackets.

Suggested-by: Patrick Kutch <patrick.g.kutch@intel.com>
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
 app/proc_info/main.c | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Van Haaren, Harry Sept. 8, 2016, 12:31 p.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maryam Tahhan
> Sent: Wednesday, September 7, 2016 11:38 AM
> To: dev@dpdk.org
> Cc: Tahhan, Maryam <maryam.tahhan@intel.com>
> Subject: [dpdk-dev] [PATCH v2 1/1] dpdk_procinfo: check for primary process
> 
> Add a check to see if the primary process is running and exit gracefully if it
> is not.
> v2:
> * Updated to tone down message and remove unnecessary brackets.
> 
> Suggested-by: Patrick Kutch <patrick.g.kutch@intel.com>
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
  
Thomas Monjalon Sept. 23, 2016, 6:44 p.m. UTC | #2
2016-09-08 12:31, Van Haaren, Harry:
> > Add a check to see if the primary process is running and exit gracefully if it
> > is not.
> > v2:
> > * Updated to tone down message and remove unnecessary brackets.
> > 
> > Suggested-by: Patrick Kutch <patrick.g.kutch@intel.com>
> > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied (with tab indent), thanks
  

Patch

diff --git a/app/proc_info/main.c b/app/proc_info/main.c
index 6dc0bbb..9c1eb91 100644
--- a/app/proc_info/main.c
+++ b/app/proc_info/main.c
@@ -329,6 +329,9 @@  main(int argc, char **argv)
 	argc -= ret;
 	argv += (ret - 3);
 
+        if (!rte_eal_primary_proc_alive(NULL))
+                rte_exit(EXIT_FAILURE, "No primary DPDK process is running.\n");
+
 	/* parse app arguments */
 	ret = proc_info_parse_args(argc, argv);
 	if (ret < 0)