diff mbox

[dpdk-dev] dpdk_procinfo: check for primary process

Message ID 1473181925-127253-1-git-send-email-maryam.tahhan@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Tahhan, Maryam Sept. 6, 2016, 5:12 p.m. UTC 
  Add a check to see if the primary process is running and exit gracefully if it
is not.

Suggested-by: Patrick Kutch <patrick.g.kutch@intel.com>
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
 app/proc_info/main.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Panu Matilainen Sept. 7, 2016, 8:42 a.m. UTC | #1 
On 09/06/2016 08:12 PM, Maryam Tahhan wrote:
> Add a check to see if the primary process is running and exit gracefully if it
> is not.
>
> Suggested-by: Patrick Kutch <patrick.g.kutch@intel.com>
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> ---
>  app/proc_info/main.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/app/proc_info/main.c b/app/proc_info/main.c
> index 6dc0bbb..ddc8cf8 100644
> --- a/app/proc_info/main.c
> +++ b/app/proc_info/main.c
> @@ -329,6 +329,11 @@ main(int argc, char **argv)
>  	argc -= ret;
>  	argv += (ret - 3);
>
> +        if (!rte_eal_primary_proc_alive(NULL)) {
> +                rte_exit(EXIT_FAILURE, "NO PRIMARY DPDK PROCESS IS RUNNING\n");

I don't think there'a a need to YELL THAT MESSAGE.

	- Panu -
John McNamara Sept. 7, 2016, 10:40 a.m. UTC | #2 
> -----Original Message-----

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen

> Sent: Wednesday, September 7, 2016 9:43 AM

> To: Tahhan, Maryam <maryam.tahhan@intel.com>; dev@dpdk.org

> Cc: Kutch, Patrick G <patrick.g.kutch@intel.com>

> Subject: Re: [dpdk-dev] [PATCH] dpdk_procinfo: check for primary process

> ...

>

> > @@ -329,6 +329,11 @@ main(int argc, char **argv)

> >  	argc -= ret;

> >  	argv += (ret - 3);

> >

> > +        if (!rte_eal_primary_proc_alive(NULL)) {

> > +                rte_exit(EXIT_FAILURE, "NO PRIMARY DPDK PROCESS IS

> > + RUNNING\n");

> 

> I don't think there'a a need to YELL THAT MESSAGE.


Our labs *are* quite noisy. ;-)
diff mbox

Patch

diff --git a/app/proc_info/main.c b/app/proc_info/main.c
index 6dc0bbb..ddc8cf8 100644
--- a/app/proc_info/main.c
+++ b/app/proc_info/main.c
@@ -329,6 +329,11 @@  main(int argc, char **argv)
 	argc -= ret;
 	argv += (ret - 3);
 
+        if (!rte_eal_primary_proc_alive(NULL)) {
+                rte_exit(EXIT_FAILURE, "NO PRIMARY DPDK PROCESS IS RUNNING\n");
+        }
+
+
 	/* parse app arguments */
 	ret = proc_info_parse_args(argc, argv);
 	if (ret < 0)