[dpdk-dev,29/39] net/ixgbe/base: report autoneg supported for X550

Message ID 1472312902-16963-30-git-send-email-xiao.w.wang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Xiao Wang Aug. 27, 2016, 3:48 p.m. UTC
  Make sure ixgbe_device_supports_autoneg_fc() returns true for the device
IDs of Seabrook and Shady Acres.

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
 drivers/net/ixgbe/base/ixgbe_common.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Ferruh Yigit Sept. 19, 2016, 5:07 p.m. UTC | #1
On 8/27/2016 4:48 PM, Xiao Wang wrote:
> Make sure ixgbe_device_supports_autoneg_fc() returns true for the device
> IDs of Seabrook and Shady Acres.

Is these IDs official public ones?

> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_common.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
> index bc12bc1..9776ab9 100644
> --- a/drivers/net/ixgbe/base/ixgbe_common.c
> +++ b/drivers/net/ixgbe/base/ixgbe_common.c
> @@ -189,6 +189,8 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)
>  		case IXGBE_DEV_ID_X550T1:
>  		case IXGBE_DEV_ID_X550EM_X_10G_T:
>  		case IXGBE_DEV_ID_X550EM_A_10G_T:
> +		case IXGBE_DEV_ID_X550EM_A_1G_T:
> +		case IXGBE_DEV_ID_X550EM_A_1G_T_L:
>  			supported = true;
>  			break;
>  		default:
>
  
Xiao Wang Sept. 23, 2016, 12:59 a.m. UTC | #2
Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, September 20, 2016 1:08 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 29/39] net/ixgbe/base: report autoneg
> supported for X550
> 
> On 8/27/2016 4:48 PM, Xiao Wang wrote:
> > Make sure ixgbe_device_supports_autoneg_fc() returns true for the device
> > IDs of Seabrook and Shady Acres.
> 
> Is these IDs official public ones?

I will remove such name in v2.

> 
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> >  drivers/net/ixgbe/base/ixgbe_common.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c
> b/drivers/net/ixgbe/base/ixgbe_common.c
> > index bc12bc1..9776ab9 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_common.c
> > +++ b/drivers/net/ixgbe/base/ixgbe_common.c
> > @@ -189,6 +189,8 @@ bool ixgbe_device_supports_autoneg_fc(struct
> ixgbe_hw *hw)
> >  		case IXGBE_DEV_ID_X550T1:
> >  		case IXGBE_DEV_ID_X550EM_X_10G_T:
> >  		case IXGBE_DEV_ID_X550EM_A_10G_T:
> > +		case IXGBE_DEV_ID_X550EM_A_1G_T:
> > +		case IXGBE_DEV_ID_X550EM_A_1G_T_L:
> >  			supported = true;
> >  			break;
> >  		default:
> >
>
  

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index bc12bc1..9776ab9 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -189,6 +189,8 @@  bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)
 		case IXGBE_DEV_ID_X550T1:
 		case IXGBE_DEV_ID_X550EM_X_10G_T:
 		case IXGBE_DEV_ID_X550EM_A_10G_T:
+		case IXGBE_DEV_ID_X550EM_A_1G_T:
+		case IXGBE_DEV_ID_X550EM_A_1G_T_L:
 			supported = true;
 			break;
 		default: