From patchwork Tue Aug 9 02:07:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao1, Wei" X-Patchwork-Id: 15161 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D453E3794; Tue, 9 Aug 2016 04:09:27 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3A2453772 for ; Tue, 9 Aug 2016 04:09:26 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 08 Aug 2016 19:09:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,493,1464678000"; d="scan'208"; a="1037610478" Received: from dpdk2.bj.intel.com ([172.16.182.189]) by fmsmga002.fm.intel.com with ESMTP; 08 Aug 2016 19:09:24 -0700 From: Wei Zhao1 To: dev@dpdk.org Cc: Wei Zhao1 Date: Tue, 9 Aug 2016 10:07:52 +0800 Message-Id: <1470708472-39154-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH v3] net/i40e: fix Rx statistic inconsistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rx_good_bytes and rx_good_packets statistic is inconsistent when port stopped,ipackets statistic is minus the discard packets but rx_bytes statistic not,but i40e has no statistic of discard bytes.So we check "dev_started" flag, if the port is started we do the statistic work,if stopped we don't.We can avoid the statistic inconsistent problem by this way. Fixes: 9aace75fc82e ("i40e: fix statistics") Signed-off-by: Wei Zhao1 --- drivers/net/i40e/i40e_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index d0aeb70..47ed6e9 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2315,7 +2315,8 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) unsigned i; /* call read registers - updates values, now write them to struct */ - i40e_read_stats_registers(pf, hw); + if (dev->data->dev_started == 1) + i40e_read_stats_registers(pf, hw); stats->ipackets = pf->main_vsi->eth_stats.rx_unicast + pf->main_vsi->eth_stats.rx_multicast + @@ -2494,7 +2495,8 @@ i40e_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, if (n < count) return count; - i40e_read_stats_registers(pf, hw); + if (dev->data->dev_started == 1) + i40e_read_stats_registers(pf, hw); if (xstats == NULL) return 0;