Message ID | 1469098444-2156-2-git-send-email-hemant.agrawal@nxp.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CF3FE3990; Thu, 21 Jul 2016 07:19:57 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0067.outbound.protection.outlook.com [104.47.36.67]) by dpdk.org (Postfix) with ESMTP id 1849B4A63 for <dev@dpdk.org>; Thu, 21 Jul 2016 07:19:56 +0200 (CEST) Received: from BN3PR0301CA0068.namprd03.prod.outlook.com (10.160.152.164) by BY2PR03MB1926.namprd03.prod.outlook.com (10.164.114.30) with Microsoft SMTP Server (TLS) id 15.1.447.15; Thu, 21 Jul 2016 05:19:52 +0000 Received: from BL2FFO11FD012.protection.gbl (2a01:111:f400:7c09::141) by BN3PR0301CA0068.outlook.office365.com (2a01:111:e400:401e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.544.10 via Frontend Transport; Thu, 21 Jul 2016 05:19:53 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD012.mail.protection.outlook.com (10.173.161.18) with Microsoft SMTP Server (TLS) id 15.1.534.7 via Frontend Transport; Thu, 21 Jul 2016 05:19:52 +0000 Received: from netperf1.ap.freescale.net ([10.232.134.28]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6L5Jia6015876; Wed, 20 Jul 2016 22:19:47 -0700 From: Hemant Agrawal <hemant.agrawal@nxp.com> To: <declan.doherty@intel.com>, <sergio.gonzalez.monroy@intel.com> CC: <dev@dpdk.org> Date: Thu, 21 Jul 2016 16:24:04 +0530 Message-ID: <1469098444-2156-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469098444-2156-1-git-send-email-hemant.agrawal@nxp.com> References: <1469098444-2156-1-git-send-email-hemant.agrawal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131135519932122980; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(8936002)(5001770100001)(105606002)(76176999)(19580395003)(50466002)(81166006)(36756003)(104016004)(81156014)(50226002)(97736004)(77096005)(4326007)(5003940100001)(2950100001)(47776003)(87936001)(229853001)(50986999)(8676002)(48376002)(106466001)(2906002)(6806005)(68736007)(33646002)(86362001)(19580405001)(305945005)(356003)(92566002)(85426001)(7846002)(586003)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB1926; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD012; 1:fUuTkaEQrmuqZZdKVJER8lPxlbo9aeCUNKfkiLlE0a1++iJTEW0yXicJZ/5dnakASWki1vz4I0NLiE+StnDlX7w7EJW5yBJC894BoonC5Ho/sQKgY5vk9IF2BmCVITGDLYmySQysUJ6KVF9ZyxHsEc6fpPOHGQVd5CoiWPYhzOVx2UqYtstkvjUTpIMYyPOecR5cKu6TlclaQtWPHMlOI5Qqv3v/Pjt1aN8we3mb7i27Fb3H40QdeCB1ImgpW3+fjsfTCQEpRajfL4rcnY333gjdlYzocFw4+4iTayBucRg6SZ77L/+0sPlT+T/aCW6lbU0wZSgA85or7na5UGnozccHy+58z6+2lSpUXlETP72anyb6xQxQqBgC56jXoRmMnUKpvzM9wN1FaVhWIjEVc3AOohbQh/iGB0HcNhFNG0aAwZjsJaD6RT4kOHWOT3EIpGLVDRtz7avbXQXCUjfP6DzaGDdlGT+SPD0rlcknggCnjL2GSK+HyWzmEH3BmVDKgKxn93y1H0bv2ymwt93IPBWbjwvDW0w7ce01AcO0Z1kMsD0ZVifiQIc5+rL07fBKlB3d57QpjQPws0az1pkzESvUbe8mVzQcaw+AKL8jGwVhpZTPmr46kxXYrGGQecXm7+WZ9vmNKZGFK7918PLPlZ+/6NqQpChDky9DJIpPpSs= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 5f8fed7a-4efe-4bb3-c4a2-08d3b126a56f X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1926; 2:oCa8Ox0TZk5t+qQPhxiW4Ts9Mb6+2mpelQdNlbODFuZ47m9zpkSKdkrVZyVN75LMtE9V3FWNhyQqwXa0N4/1AaXhKTpFVaD+G+NkPrWtiT5ZMwMnyCcCe/hi79/+Q0W3dXaY4Nnn9MCJEFwq98KkebNCyfdZU1PaoHuTbuXWOREeASmcZ5sVVt4GFKeNIONt; 3:td6wudltH0a9u5w5ZIDKU/vIS1OYUKW6GgBUBr5yde707wrVX0SKCdlJq5HiIUIUhXduhU41+XLhHHTzmIvMSSNjSp8ZDrhVFO/oXfr/2MFqQxy++Wdn4zc2Emwy81YSmZq4/4yqfxTQ/o01cpsUjT55qBpxHjpEAc9orFUGx1PQYvY6QFmGjEzB5jOKLW9DJY27X4JrtwLYf4jGL1y27Ps4x/OOMjDKsv2WUnkM8AQ=; 25:LdlW6i+5czCMar3HraVrY2NGVG5YRobl46CCweVSvXZcbYfX1EfIMQ7mVHxZt2YgL6Q2vIH60bRijHmx/3krJkRJ23hZyjfXGJe+1lhnz4vZdFZR1NJk9g/aDYCqO01eWM4cwEAuPllOiTicggOzqgjK6HXmA96d3OVgi2UOcpXktDqG8vLXeb/82msbHOZ/I/OYpwxewjBi1IwC3bPmHBpzUknMRW3F+nLRlt1giYCcNC5pyKtK4Pa1BzF+BaRt X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB1926; X-Microsoft-Antispam-PRVS: <BY2PR03MB192636EEAEA3C2952457F77489090@BY2PR03MB1926.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(13015025)(13018025)(13017025)(13024025)(13023025)(10201501046)(3002001)(6055026); SRVR:BY2PR03MB1926; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR03MB1926; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1926; 4:Zh/4YlgmxZ+S5JyXfqBE3MDOPb1DxFKtSNm76WnaAlbtnl3T7qTQXMxTEbFmz4aRnOOd1nZ1AUrWj9MMxgzy+Lm9pHgD3L1aahbxzNka0dHx5QOosA2NzECprP1htvqBShfESnZAVtR/HNN5WpGCsqsoja0edo9uzAKnGWELKV9XmZDta954pyG6yYbkC3dVJXd4/7VSoEM8yxgYqsngzz5FxSMsMkPiRA/jIwLfhFRppv+5fQcrk4RKlYqI/OIzzWu+m3JUXdo+mjoSH9+81yRRkZ4O21Gw0Xc0U0U5bSytzETKqZmjaQ/nG5XwPtyRA9d0pEIlqbEbOZlJ82LfZnJcJpaSAMzLpKTR/jZbX3NNQCf5Qo6Vo+qHlzg2Yqr4a0hwn3GosNgXPKhyo3gZGAWxuBtsxF1QFb1RsDauycY5h1GoW16tPPkBen/Rc0cMjG3mwPS8c28V+HeNM07Ouh94GhEeyP0S5o04n25LS/Pn3khRhQ/+IqTc7FR0AeBC6YvYTk8OZJpusH57mjHOuw== X-Forefront-PRVS: 0010D93EFE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR03MB1926; 23:HjOU/AzxYIhOeZ50h3roGaQACak07ZlIutUl6mALW?= =?us-ascii?Q?d+7BBgmJxw/hr3KrwoqQHPhb/sKe67xGfjTjtAlqfbOiyXSzLw6cJDAGVMtA?= =?us-ascii?Q?pc6QQpnNAKLRILTDUjdAqy65PfLTR1wPuEZIUKKVdii2Ms0N1WwJ45Tom8Ru?= =?us-ascii?Q?TXIllhewqfrO5aa1Aq9gwpvTh20O2d6fxkYb4O1/2qq/kfnCVuoMMVdOGkJi?= =?us-ascii?Q?sFXUQuSfF80grLmtQ0eWWwGWTIv5lQK27KNkrDy9w2i2FnerxBJ1L4rUcUlL?= =?us-ascii?Q?q8XNoRgeR8GQpnk+mnYeOeaUmgJoctapvkYcMncd9jhyazRAt0331oEOt2NI?= =?us-ascii?Q?Sp8ngeYgGKRhQfEVHihJ+xUZysMK8obG+GvUxU06aRxB8PAvB6aWJs/R4YtP?= =?us-ascii?Q?cFunIRnc0mKvU/qBA2G2kD4KIQAqmlU3bC26Kz5/WkpN7R8YnqBQViLdK1zD?= =?us-ascii?Q?DcaeJyPy/HnxiXze8XdUGomxD3YkLQ5O8KbCuZq1Q8IgXOye2vdJC/2KQ73r?= =?us-ascii?Q?kxfXIPjONWoXmlu90DF3dfooFybJnHxA+7ScPtLz34c9C7Xy2EstqBBJergj?= =?us-ascii?Q?poBePiDQd6zY+zBteLRPwu69DvAU0w43+YgWNHhNNv7+XGGEtVTHkgi+fAoJ?= =?us-ascii?Q?OvLML+GfJir6Egtzh84zkkx5pPQisPKPU/t1RcPbUZ3sHuNMBWux2FEUD+gZ?= =?us-ascii?Q?4PZ9aGuW/Iu03s/RZtz8RcpQ8KKkVruq9NdncJanbQdFFrq2AT6ogjo8k49f?= =?us-ascii?Q?JVARdZf4RXEZXLRlk5MDhzotmKJxmL/nzi+WMDejUdZronU1KMylwBULPwnM?= =?us-ascii?Q?US1tI7h3UygTnd7tVU/2wmIHxLMV7vsX1CpQcTRDXATw/q498veax3/7WQLT?= =?us-ascii?Q?iWrzLNby5w68LsdbU4V80VC4xs4bepycYpeF5nR+95vNtvmzKkwcjLu4x87X?= =?us-ascii?Q?88qvsoEfpQ+Eu1IG6cmEbaE5tYcgqeLcE0Bj8y2dtQ1FbT0lDO/Yh0vFInua?= =?us-ascii?Q?BcebMZIgXwQ7uY4+LLsxKURTDVm52NLXPiGInfRHsmkAokEuLrsKtMjt7KCB?= =?us-ascii?Q?Gq4t5hVHyAO/lSHIAbd3UeHhKW5iA03d1ceiKZsMpzobGTzPvjKHEwO8wgZg?= =?us-ascii?Q?xkjdady3x4=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB1926; 5:lhe1S56vjvaTq+Kj7OElecuqNCn4hiLVouHH0NMLLI6lTM9YAIL9pucjBqDcw3RjYrEAHEMQYdmUJ4ngEZ7Yi+WtCjRnG8BYmUN07EVO20pPDApaldFqWaN5j4FxzMakbSQcAxT2gBnDjOpLdRN1UUHxBaG5A2tnU8KpCmVL5dc=; 24:URV295hNqsfJRVjgUZEXPqmIkDJgpkbgvlv00BI/eh7+hhxD6xvauW+lQJuwnnB7B+IVFXmvfxcvcNoR03mqiD7nL8dkHWdN8YYQy7i2jkQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2016 05:19:52.8222 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB1926 Subject: [dpdk-dev] [PATCH 2/2] example/ipsec-secgw: add support for cryptodev_start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Hemant Agrawal
July 21, 2016, 10:54 a.m. UTC
The usual device sequence is configure, queue setup and start. Crypto device should be started before use. Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- examples/ipsec-secgw/ipsec-secgw.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
It seems cryptodev_start() calls empty driver functions, and is not called in the example applications. This a v2 of patches from Hemant Agrawal and Akhil Goyal. There are some improvements to make error messages more consistent with existing ones and keep the existing error return. Are they important fixes for 16.07? Please advise. Hemant Agrawal (2): examples/l2fwd-crypto: call start function examples/ipsec-secgw: call start function examples/ipsec-secgw/ipsec-secgw.c | 4 ++++ examples/l2fwd-crypto/main.c | 7 +++++++ 2 files changed, 11 insertions(+)
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, July 22, 2016 10:44 AM > To: Akhil Goyal; Hemant Agrawal; Doherty, Declan; De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: [PATCH v2 0/2] cryptodev_start fixes > > It seems cryptodev_start() calls empty driver functions, > and is not called in the example applications. > > This a v2 of patches from Hemant Agrawal and Akhil Goyal. > There are some improvements to make error messages more > consistent with existing ones and keep the existing error return. > > Are they important fixes for 16.07? Please advise. > > Hemant Agrawal (2): > examples/l2fwd-crypto: call start function > examples/ipsec-secgw: call start function > > examples/ipsec-secgw/ipsec-secgw.c | 4 ++++ > examples/l2fwd-crypto/main.c | 7 +++++++ > 2 files changed, 11 insertions(+) > > -- > 2.7.0 Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
2016-07-22 10:20, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > It seems cryptodev_start() calls empty driver functions, > > and is not called in the example applications. > > > > This a v2 of patches from Hemant Agrawal and Akhil Goyal. > > There are some improvements to make error messages more > > consistent with existing ones and keep the existing error return. > > > > Are they important fixes for 16.07? Please advise. > > > > Hemant Agrawal (2): > > examples/l2fwd-crypto: call start function > > examples/ipsec-secgw: call start function > > Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Applied, thanks
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 1ca144b..302499c 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1273,6 +1273,10 @@ cryptodevs_init(void) &qp_conf, dev_conf.socket_id)) rte_panic("Failed to setup queue %u for " "cdev_id %u\n", 0, cdev_id); + /* Start device */ + if (rte_cryptodev_start(cdev_id)) + rte_panic("Failed to start crypto dev for " + "cdev_id=%u\n", cdev_id); } printf("\n");