diff mbox

[dpdk-dev] net/ena: fix icc compile error

Message ID 1468920783-27136-1-git-send-email-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Ferruh Yigit July 19, 2016, 9:33 a.m. UTC
compile error:
  CC ena_com.o
.../drivers/net/ena/base/ena_com.c(346):
error #3656: variable "dev_node" may be used before its value is set
                ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
                ^

.../drivers/net/ena/base/ena_com.c(399):
error #3656: variable "prev_node" may be used before its value is set
        ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
        ^

Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation NUMA-aware")

Reported-by: Eoin Breen <eoin.breen@intel.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/ena/base/ena_com.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit July 19, 2016, 10:48 a.m. UTC | #1
On 7/19/2016 10:33 AM, Ferruh Yigit wrote:
> compile error:
>   CC ena_com.o
> .../drivers/net/ena/base/ena_com.c(346):
> error #3656: variable "dev_node" may be used before its value is set
>                 ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
>                 ^
> 
> .../drivers/net/ena/base/ena_com.c(399):
> error #3656: variable "prev_node" may be used before its value is set
>         ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
>         ^
> 
> Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation NUMA-aware")
> 
> Reported-by: Eoin Breen <eoin.breen@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Self-Nack
I wasn't aware Jan is already working on this and has a patch. We can
drop this one.

Thanks,
ferruh
Jan Medala July 19, 2016, 11:34 a.m. UTC | #2
Ferruh,

Actually we can stay with this patch. It's ok.

Acked-by: Jan Medala <jan@semihalf.com>

  Jan

2016-07-19 12:48 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:

> On 7/19/2016 10:33 AM, Ferruh Yigit wrote:
> > compile error:
> >   CC ena_com.o
> > .../drivers/net/ena/base/ena_com.c(346):
> > error #3656: variable "dev_node" may be used before its value is set
> >                 ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> >                 ^
> >
> > .../drivers/net/ena/base/ena_com.c(399):
> > error #3656: variable "prev_node" may be used before its value is set
> >         ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> >         ^
> >
> > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> NUMA-aware")
> >
> > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Self-Nack
> I wasn't aware Jan is already working on this and has a patch. We can
> drop this one.
>
> Thanks,
> ferruh
>
>
Thomas Monjalon July 21, 2016, 10:39 p.m. UTC | #3
> > > compile error:
> > >   CC ena_com.o
> > > .../drivers/net/ena/base/ena_com.c(346):
> > > error #3656: variable "dev_node" may be used before its value is set
> > >                 ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > >                 ^
> > >
> > > .../drivers/net/ena/base/ena_com.c(399):
> > > error #3656: variable "prev_node" may be used before its value is set
> > >         ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > >         ^
> > >
> > > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> > NUMA-aware")
> > >
> > > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Self-Nack
> > I wasn't aware Jan is already working on this and has a patch. We can
> > drop this one.
> 
> Actually we can stay with this patch. It's ok.
> 
> Acked-by: Jan Medala <jan@semihalf.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index a3649d8..88053e3 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -329,7 +329,7 @@  static int ena_com_init_io_sq(struct ena_com_dev *ena_dev,
 			      struct ena_com_io_sq *io_sq)
 {
 	size_t size;
-	int dev_node;
+	int dev_node = 0;
 
 	ENA_TOUCH(ctx);
 
@@ -383,7 +383,7 @@  static int ena_com_init_io_cq(struct ena_com_dev *ena_dev,
 			      struct ena_com_io_cq *io_cq)
 {
 	size_t size;
-	int prev_node;
+	int prev_node = 0;
 
 	ENA_TOUCH(ctx);
 	memset(&io_cq->cdesc_addr, 0x0, sizeof(struct ena_com_io_desc_addr));