[dpdk-dev] net/fm10k: fix FTAG mode on multi-queue

Message ID 1468579120-12350-1-git-send-email-xiao.w.wang@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Xiao Wang July 15, 2016, 10:38 a.m. UTC
  In multi-queue + FTAG use case, we need to turn tx_ftag_en on for all
the Tx queues.

Fixes: 7958b1310d5e ("fm10k: enable FTAG based forwarding")

Reported-by: Ricky Li <ricky.li@intel.com>
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
 drivers/net/fm10k/fm10k_ethdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
  

Comments

Thomas Monjalon July 15, 2016, 8:57 p.m. UTC | #1
2016-07-15 18:38, Xiao Wang:
> In multi-queue + FTAG use case, we need to turn tx_ftag_en on for all
> the Tx queues.
> 
> Fixes: 7958b1310d5e ("fm10k: enable FTAG based forwarding")
> 
> Reported-by: Ricky Li <ricky.li@intel.com>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>

Applied, thanks
  

Patch

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 217853f..144b2de 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -2738,10 +2738,8 @@  fm10k_set_tx_function(struct rte_eth_dev *dev)
 		txq = dev->data->tx_queues[i];
 		txq->tx_ftag_en = tx_ftag_en;
 		/* Check if Vector Tx is satisfied */
-		if (fm10k_tx_vec_condition_check(txq)) {
+		if (fm10k_tx_vec_condition_check(txq))
 			use_sse = 0;
-			break;
-		}
 	}
 
 	if (use_sse) {