From patchwork Tue Jul 12 06:01:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 14770 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id F2C2D5582; Tue, 12 Jul 2016 08:01:27 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0058.outbound.protection.outlook.com [104.47.33.58]) by dpdk.org (Postfix) with ESMTP id BAA755582 for ; Tue, 12 Jul 2016 08:01:26 +0200 (CEST) Received: from BN3PR0301CA0004.namprd03.prod.outlook.com (10.160.180.142) by SN1PR0301MB1998.namprd03.prod.outlook.com (10.163.225.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.534.14; Tue, 12 Jul 2016 06:01:25 +0000 Received: from BL2FFO11FD011.protection.gbl (2a01:111:f400:7c09::128) by BN3PR0301CA0004.outlook.office365.com (2a01:111:e400:4000::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.534.14 via Frontend Transport; Tue, 12 Jul 2016 06:01:25 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD011.mail.protection.outlook.com (10.173.161.17) with Microsoft SMTP Server (TLS) id 15.1.534.7 via Frontend Transport; Tue, 12 Jul 2016 06:01:25 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6C60qWi006202; Mon, 11 Jul 2016 23:01:22 -0700 From: Shreyansh Jain To: CC: , , Date: Tue, 12 Jul 2016 11:31:15 +0530 Message-ID: <1468303282-2806-11-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131127768852932475; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(104016004)(47776003)(586003)(6806005)(87936001)(11100500001)(106466001)(189998001)(110136002)(356003)(50226002)(2351001)(2950100001)(86362001)(7846002)(229853001)(305945005)(8936002)(105606002)(68736007)(81156014)(50466002)(81166006)(8676002)(76176999)(50986999)(97736004)(48376002)(85426001)(33646002)(19580405001)(19580395003)(36756003)(2906002)(92566002)(5003940100001)(77096005)(4326007)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB1998; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD011; 1:afFdc4HtCHj22pGAep9lh8UNZjTolUSy67AROz4+XgNzIW91/wrmwmF6hhrCb8fwUTsFLg4nthzQlXl/f365iiOt7lxNfK8CzfYjYFAbt+ibnrncbtxL2O7vE7ktubbKmb9/af+f7ZJMyxu2hguzil/bz6jII+GOh0T7jtSeR/M3PQH6URZhNaj875pYZHLncinmiodIOurflFaVRs1SAcQFjGklWnohaNSG6cZ7/hONnKpgNnyxCcdUcBaM1uFs51JFaFumDAS713dkcn1gx1KErxSgusOmmxW0k9rZ0YTo/Mw7vFiF0LJSaZdvwWXFcO9dn66cgs5p4V/KMzvFn1OppR+EEUJ4yPaWVvaT6qtjkFyW/P2BQ40eKR2PP3SXBsfFssixHXFJLdYccD7N2Xww+QHaAJ02FFhRQPqB91LQvYANJmgzX4u2yRXD6ncTAMXpIauG4zMu6p3GLtf59xBB/iYdjeKZvAB72HUGLrACdnjCdiLO1rzuOEGq4Cw5udAisD8t5/HM0iTFpXUpLTJ0iSgQhONiVePyUc9y5iUBb/QurALMAUaSVILNtWHPWi7jsliyGi4poZKgDB6csQ8hQBvVtaeQKq/29rQjnddXLA+9KKs9rcdIP0w/eY3n MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9a8dad2a-b765-4ebe-c61b-08d3aa19f51f X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1998; 2:D22NTi3F90SGoUR4WVyX6ih3S86VM0+USS+XTfKOlkYlxhpSt61iabD0enXs+U795fQMWy62a7BmMrZmBbJUc6CEsGD1olXd3l+ATFVA3Hmsh+ISPq/NdhF4Yy6p2w3HzQuzWBR6urukm6+vk9QbFk+6HxiRukju3xC6Evmev4lASxNyPOfec2iWO6U7gYGi; 3:SsXS1kdPC7OjTFgr80NSMDPo98cwkhlN0B8HmXCpyrimrBjSKoDoPYWTFpdTX631tz3a3/0YRQ0FDE9MJ2wi6FsqSPF8L7ifamuWuJmwCJGvr52YwFglV+YpHQpd7T8sorZMBh3Vk0MpFVerzEeDe2imGfp4AFIiLB7bJ1qDp3qj9szzaykkWec1U8wAlVO6fvpnsaUDK1TOsWTcqZCrptKBIz6cD0IxPjdQWwQ0Teo=; 25:jiQosjazQpHjrjBn2/HYCaLUd/zGoywufcz7TndhOSplAewf2xs7tS2giOniqQoAlWq0yxhTj844ex2v3956CPqgA73V9eJG+4IGXbIy+fRXr+ozYqW9KPjcgSc1MzA89bFx4ZUoi9+o2G/S9UxvlcAA5c8P3VBlNMubnOJECUvSRue4+d+kMr6L5kelE4Gowytg0OOmvkZ6JhDRmgx5XdTXgUlnSxnk6bgbHpR7Y+WPU6nJYjkPuNflme47tmwp+fU2CJFEk4lIgThrxgHwRIPgcMVyxvYlAnWlKrLlAgzjuZIrcGN0SYtHfjRtFoC4ZCtH2cXh0KV5bu9IbrqQcnZevV/jf0mvC8lY7oasRdC/2mGHuVLngEdf2EjR3gxWYdUb4AOIp+tghLyPm280vIR45LoEtBe0+5iWnd7/osE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1998; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1998; 31:yLpqHGEK9Z5FipAx7Qkzt5HD9086ASN47hUdzToQnzFXt5wKiVUhxvLBMiSmL45EK9rPacpnmwXdHzhDpbpNbHMAaVmc878oVPHT34f7MgW4+XXQg7jVw9QIYbEhnt75dGtg7wFInF2hkzhdeZb0Q3fzBqPhLvNwrpFC0vEH8NbhY9vSxlkDE2gP2PNAbdUvGv2yk6DWMd10RpMOaZl/0w==; 4:ENcEP/MTa5d3pT5eDhGyyNklfVIR3i/OvE7GQJOolkvkq8fp13y7pUAy7zGDAfkdXnufNWzZKUUkQIjlVVxmP7wiiYjuKHx79cIVrUQLQs3Yu8iDU9wkJrHO5hbdhNoTuAvTGc8c3lZf7IUWQlm2vD97yfF4hHAGJCMXUDUMKH3+MImyId7fAGHC/xD40cb8WlLqfYElyZcDowRTCSuBfGOInqbDRf4siCBElZb60ISOUlvJ8UOmpNqVOq5tTSDAjGwphjmxq0WpSqIq7VuZYQcuGlmo7KFRHdZuRS3tTlRTClgzToLHuE8vrWUdnyTfIka7xkNcyHsu1KXc6kGwt5h7OXFzosCR7hZd3x6sSB2v/QOjYF/7g6HGoS49v9qMxe/SBfvOE9C1NF+SbCTW+ncifDJDMxMoh4im1HaXISibbS5eviZnOQzkkgbkbdxTYU2dC6Y5K/CEATkFFkdC/p4L2zv7fUtT58xZv6FplDJsFkUrDUg+o6iUxPAWz8Sf7HJD3dzgtD3vFPVvJeFGoA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13017025)(13023025)(13024025)(13018025)(13015025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:SN1PR0301MB1998; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0301MB1998; X-Forefront-PRVS: 0001227049 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0301MB1998; 23:BbB7xP92+mimkf/FSZ6Xm7+3L0bwba0y2HcZB2r?= =?us-ascii?Q?yRby3yYfM7X403Pn5TA7Cmv5WemTVSTF/JyGjleL48TJ1rbMqd0MYMfsFwbG?= =?us-ascii?Q?+UVV3DoA1LUTvwYXnhNWHZWYIJCGf5yoGvvylUTOIr9YuHrv0q3gFFQQPkjc?= =?us-ascii?Q?U4U3r5rf7TvR66Sm8gb2jyExPr1Nz1QUpgtQmQvTMiU+cGi6zS1RwZJV2ths?= =?us-ascii?Q?GETOZHTgMzx5eLXkQpFXo8rGvN30V8uJW9vQH1+dbj3dfXuDGjF5y9ksVWM8?= =?us-ascii?Q?bhdt8KCS9SV7nkblk40koiaNBe/S3SD4rBEZOBmoBCUjgnstUfaOyLqsVHj1?= =?us-ascii?Q?m8fk44X5AVA0MvoH7El+RgGYlaNZWjBVJkg9c3LfQxyHcp0qnBRr/SJ1xyt6?= =?us-ascii?Q?B4NAoFULvbPf3yzdhyXxCW78rh1y9GguzHifOzZZHdv7ES4oB2tst7STFO14?= =?us-ascii?Q?3A4mYYPj/77UX/G0U7TLQ2yuZQMREdTLL5KMKUgRjLjwJZWSj4zeEHiWemCU?= =?us-ascii?Q?pM0n6cT+C1y6ea+maC1CIz0HHMpODUYs18KFtx6g/LQEzmcfchG/eFo94sUQ?= =?us-ascii?Q?ZDb4dwBjmxVQYbWxO+TDGRkigCv6vJK2k+94Rz2mXZJP6Utx0vTfoCncOuS4?= =?us-ascii?Q?ZzzPo63Kzhd65MImhWqesPWH3WToG61/wCe6v9L73TKUmTKPjXj9Fld+4eVw?= =?us-ascii?Q?8jZN6UilGI4i6NBx5G4S+0SXVnrOZ/Xowc2TMsnfBFNIf8cHUBE25CxXSYQn?= =?us-ascii?Q?f25G/Jk/ek6FGFOQat77m8+5tDA7fHEVl6gxWfHv/Smc1/RChW0g+yj83Mi1?= =?us-ascii?Q?WsqUwTjnBfgslK+GgOzl1LKNl9MPW0M1ttYQSzv4RWWf+n90f/UCsX7FBwbz?= =?us-ascii?Q?nHfymQeexqQpT4+QXvt0AzqTG0U82Yyv2sNZAjKFKDJj8HF1r113KQ90kI/p?= =?us-ascii?Q?8A4y+uxpmpgHtAHB2DpnE2U3bhO3uLaRxqREVp/LPwiA4LXCD8YSfNtl+nOx?= =?us-ascii?Q?IfVxQa7vnj6sJUWegqsNHJ9o+y0tDcVaQyp2SJAUr39w5wVxt2Ktl/CP35VS?= =?us-ascii?Q?9lJR8KR4bPM4fwrejx83nYDf68pjhM1E/3EkQEMnDpBg2czIq4PjWtJumC1i?= =?us-ascii?Q?t50piRdwOKz3BNfczHGUsxLoD8KjexIbM?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1998; 6:+yAx1Fv2+Slzr1WuTQiq7JSKFaiAq2ZmQzbDf8b6AlIq8F14Oo5N99frcgfSx2KH2pg7l8+E8BJyasbh8Ktp727My9mbrqnzl77bvGEbnYjvsiKMwHeoMDWVPMUlJ3BdU4ZxdDeGDXPNGmHzDi7nzLDyDSsuj5dEDdNcdSFj+ppVkc0DIKqq35xzNfWTUY/3+5yyNB3dDjowj/wcvQldTFkCZYlBczMflUaTYueowiKxBKVYBHcO+Cd4PZompCTOt003c0fehvFbAxSj5xYFYHjv9kxCg7keiSh7BJrMx+I=; 5:ck8RRqAX77OXofL5BdUIvg8MSfZ5ml4zRYOVM/fwsQ3AsxR/DXEiY8+FmVa5NGNzq77pEof9jKXIxuvTO2LvuoxBmKjlZFykNvuSkJ1UU1VerPFkvgHKE9Xz8JVzjQsBgrhjCr2TgfA77pa4mB+QhZ1aqET2eRYhQ6cXyXWmizc=; 24:AWUnAxE2RK9zeok18D9ZdILvq5k+H4nyjiXso0J9ojM9x0/pQM7TBbPN9P0cKGC9QgphvEISrtPM1ypJ6ExFqRvSYeu3DzFIBzDC08vzJIs=; 7:V/Hsoq37LNR4FY09kwSguasv4JAUt9huGtqh4uo93kqUqnoL6Um+BByt1NND+fuGPNj05dBC23EQYXIr/+fpqxhQIZoT74Q0tJLQfSNbv+1DODyIcHJNOooKwplwdFmHKmJV7Cap5sUQckJTm9ZcNa5N5SU28g00uIUFzheUTJth5V24hTLMRrqFAcH/w/8WQd4GGdZxZ+rzUjmJRDoxxIQdYN9DudrfaCJHccl83PaAiOTulcjA0HBR/zwTo1Ml SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 06:01:25.1060 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1998 Subject: [dpdk-dev] [PATCH v6 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain Reviewed-by: Jan Viktorin --- lib/librte_ether/rte_ethdev.c | 22 ---------------------- lib/librte_ether/rte_ethdev.h | 12 ------------ lib/librte_ether/rte_ether_version.map | 1 - 3 files changed, 35 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 25eb032..89c7b31 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -340,28 +340,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -/** - * Register an Ethernet [Poll Mode] driver. - * - * Function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver. - * Invokes the rte_eal_pci_register() function to register the *pci_drv* - * structure embedded in the *eth_drv* structure, after having stored the - * address of the rte_eth_dev_init() function in the *devinit* field of - * the *pci_drv* structure. - * During the PCI probing phase, the rte_eth_dev_init() function is - * invoked for each PCI [Ethernet device] matching the embedded PCI - * identifiers provided by the driver. - */ -void -rte_eth_driver_register(struct eth_driver *eth_drv) -{ - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; - rte_eal_pci_register(ð_drv->pci_drv); -} - int rte_eth_dev_is_valid_port(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index a2ec9d1..d2718b5 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1871,18 +1871,6 @@ struct eth_driver { }; /** - * @internal - * A function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver (PMD). - * - * @param eth_drv - * The pointer to the *eth_driver* structure associated with - * the Ethernet driver. - */ -void rte_eth_driver_register(struct eth_driver *eth_drv); - -/** * Convert a numerical speed in Mbps to a bitmap flag that can be used in * the bitmap link_speeds of the struct rte_eth_conf * diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index c5ef869..27d8161 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -78,7 +78,6 @@ DPDK_2.2 { rte_eth_dev_vlan_filter; rte_eth_dev_wd_timeout_store; rte_eth_dma_zone_reserve; - rte_eth_driver_register; rte_eth_led_off; rte_eth_led_on; rte_eth_link;