diff mbox

[dpdk-dev] bnx2x: Call bnx2x_init_rte() later

Message ID 1467130490-21245-1-git-send-email-3chas3@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Chas Williams June 28, 2016, 4:14 p.m. UTC 
  We need sc->igu_sb_cnt determined before calculating the number of queues
we can support.

Fixes: a787538ee754 ("bnx2x: fix MSIX vector and VF resource counts")

Signed-off-by: Chas Williams <3chas3@gmail.com>
---
 drivers/net/bnx2x/bnx2x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Bruce Richardson June 29, 2016, 10:59 a.m. UTC | #1 
On Tue, Jun 28, 2016 at 12:14:50PM -0400, Chas Williams wrote:
> We need sc->igu_sb_cnt determined before calculating the number of queues
> we can support.
> 
> Fixes: a787538ee754 ("bnx2x: fix MSIX vector and VF resource counts")
> 
> Signed-off-by: Chas Williams <3chas3@gmail.com>
> ---

Hi Chas,

we generally try to avoid making the commit titles too technical, so we avoid
using function or variable names in the titles. Since this is a bug fix the
best form of title to be used is "fix <description of bug symptoms>", e.g.
"fix incorrect number of supported queues".

Maintainers, any comments or ack for this patch.

/Bruce
Rasesh Mody June 30, 2016, 8:01 p.m. UTC | #2 
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Wednesday, June 29, 2016 3:59 AM
> 
> On Tue, Jun 28, 2016 at 12:14:50PM -0400, Chas Williams wrote:
> > We need sc->igu_sb_cnt determined before calculating the number of
> > queues we can support.
> >
> > Fixes: a787538ee754 ("bnx2x: fix MSIX vector and VF resource counts")
> >
> > Signed-off-by: Chas Williams <3chas3@gmail.com>
> > ---
> 
> Hi Chas,
> 
> we generally try to avoid making the commit titles too technical, so we avoid
> using function or variable names in the titles. Since this is a bug fix the best
> form of title to be used is "fix <description of bug symptoms>", e.g.
> "fix incorrect number of supported queues".
> 
> Maintainers, any comments or ack for this patch.
> 
> /Bruce

Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>

Thanks!
Rasesh
Bruce Richardson July 4, 2016, 1:32 p.m. UTC | #3 
On Thu, Jun 30, 2016 at 08:01:24PM +0000, Rasesh Mody wrote:
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Wednesday, June 29, 2016 3:59 AM
> > 
> > On Tue, Jun 28, 2016 at 12:14:50PM -0400, Chas Williams wrote:
> > > We need sc->igu_sb_cnt determined before calculating the number of
> > > queues we can support.
> > >
> > > Fixes: a787538ee754 ("bnx2x: fix MSIX vector and VF resource counts")
> > >
> > > Signed-off-by: Chas Williams <3chas3@gmail.com>
> > > ---
> > 
> > Hi Chas,
> > 
> > we generally try to avoid making the commit titles too technical, so we avoid
> > using function or variable names in the titles. Since this is a bug fix the best
> > form of title to be used is "fix <description of bug symptoms>", e.g.
> > "fix incorrect number of supported queues".
> > 
> > Maintainers, any comments or ack for this patch.
> > 
> > /Bruce
> 
> Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>
> 
> Thanks!
> Rasesh

Applied to dpdk_next_net/rel_16_07 with title "net/bnx2x: fix incorrect
number of supported queues".

/Bruce
diff mbox

Patch

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 3095d2b..10859c1 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -9682,9 +9682,6 @@  int bnx2x_attach(struct bnx2x_softc *sc)
 
 	sc->state = BNX2X_STATE_CLOSED;
 
-	/* Init RTE stuff */
-	bnx2x_init_rte(sc);
-
 	pci_write_long(sc, PCICFG_GRC_ADDRESS, PCICFG_VENDOR_ID_OFFSET);
 
 	sc->igu_base_addr = IS_VF(sc) ? PXP_VF_ADDR_IGU_START : BAR_IGU_INTMEM;
@@ -9702,6 +9699,9 @@  int bnx2x_attach(struct bnx2x_softc *sc)
 		sc->igu_sb_cnt = 1;
 	}
 
+	/* Init RTE stuff */
+	bnx2x_init_rte(sc);
+
 	if (IS_PF(sc)) {
 /* get device info and set params */
 		if (bnx2x_get_device_info(sc) != 0) {