diff mbox

[dpdk-dev,1/3] ethdev: remove duplicated symbols from .map

Message ID 1467032551-14979-1-git-send-email-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Ferruh Yigit June 27, 2016, 1:02 p.m. UTC 
  Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_ether/rte_ether_version.map | 1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit June 27, 2016, 1:07 p.m. UTC | #1 
On 6/27/2016 2:02 PM, Ferruh Yigit wrote:
> Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

Hi Thomas,

I got the duplicates with following command [1], does it make sense to
add this into one of the check scripts, -not sure which one?

[1]
# for m in $(find . -name *_version.map); do for l in $(cat $m | sort |
uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";"
-f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l;
fi; done; done
Thomas Monjalon June 30, 2016, 5:58 p.m. UTC | #2 
> Hi Thomas,
> 
> I got the duplicates with following command [1], does it make sense to
> add this into one of the check scripts, -not sure which one?
> 
> [1]
> # for m in $(find . -name *_version.map); do for l in $(cat $m | sort |
> uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";"
> -f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l;
> fi; done; done
> 

I have started to write a script to check symbol export.
Feel free to start a new script scripts/check-symbols.sh with this
check for duplicated symbols in .map.
I will add my checks later in this script.

Thanks
Thomas Monjalon June 30, 2016, 6:03 p.m. UTC | #3 
2016-06-27 14:02, Ferruh Yigit:
> Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type")
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied, thanks
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 97ed0b0..e1ccebe 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -66,7 +66,6 @@  DPDK_2.2 {
 	rte_eth_dev_set_vf_rxmode;
 	rte_eth_dev_set_vf_tx;
 	rte_eth_dev_set_vf_vlan_filter;
-	rte_eth_dev_set_vlan_ether_type;
 	rte_eth_dev_set_vlan_offload;
 	rte_eth_dev_set_vlan_pvid;
 	rte_eth_dev_set_vlan_strip_on_queue;