From patchwork Wed Jun 22 09:06:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 14206 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 78B7DC4D8; Wed, 22 Jun 2016 11:07:48 +0200 (CEST) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0059.outbound.protection.outlook.com [207.46.100.59]) by dpdk.org (Postfix) with ESMTP id 4E925C464 for ; Wed, 22 Jun 2016 11:06:41 +0200 (CEST) Received: from BY2PR03CA008.namprd03.prod.outlook.com (10.255.93.25) by BY2PR0301MB1623.namprd03.prod.outlook.com (10.163.28.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Wed, 22 Jun 2016 09:06:40 +0000 Received: from BY2FFO11FD019.protection.gbl (10.255.93.4) by BY2PR03CA008.outlook.office365.com (10.255.93.25) with Microsoft SMTP Server (TLS) id 15.1.492.11 via Frontend Transport; Wed, 22 Jun 2016 09:06:40 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD019.mail.protection.outlook.com (10.1.14.107) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Wed, 22 Jun 2016 09:06:39 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5M9663j022009; Wed, 22 Jun 2016 02:06:37 -0700 From: Shreyansh Jain To: CC: , Date: Wed, 22 Jun 2016 14:36:29 +0530 Message-ID: <1466586396-22618-11-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131110599999247455; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(97736004)(36756003)(47776003)(106466001)(105606002)(2950100001)(50466002)(85426001)(69596002)(48376002)(19580405001)(19580395003)(5003940100001)(2351001)(68736007)(33646002)(11100500001)(87936001)(50986999)(229853001)(86362001)(76176999)(110136002)(104016004)(81166006)(81156014)(6806005)(50226002)(8936002)(7846002)(4326007)(189998001)(92566002)(356003)(586003)(2906002)(77096005)(8676002)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB1623; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD019; 1:/ih6PeEjrgn9xZVONHsxv9mklzY+QtzaW9BSg30zwZemaKVsJFbdp9HC7ZlPWa4JRQ6rmZfG/L1Ws2WXQj18S7aJiKBO3HhdJ+UdQsijOSCAVElAeOOXP4cT20AwV9cK1mXOjiDvXYL+Y7KBZqUxyJIPfmYUsFAt/9S3YC5nY3bXQSV6d7+l2aMebPDD4SK9Vlxjsqjo1qE/z2Rtt2eJFaXC5zZq7LIH7VBsYpU72wUj6XiWvY0UZduDpoYplQOGRfcix4IRSfqRflOYvAmiMk46QZnxEzL78aKfhwMigY2CoVXbwAdKmbgMdOGSZy2YYoACwiq84n2APJ4ygipaPSkyfYm8QxmGsNdMQdsu4MVqvQfxkQIqRjTmVeQZ/pSs+706gLnRwwqOkkpR8NJ5sa+i/7Vz2QJ/QrMw2w51Cbo8WXzAb5VYvMTiuwucb6X6lT6b7rcBaMKZy3fuZJyWj/ke4qBprE+ImNyMsKRDWFeJgjzazfYmmfvai+FKgbAuWCBWI6tI163UOSHPc3T4xPoq5liW11+WlxPzlCE5RxcJ7icPSpqoCxausD3oXJ4/pkskHxr7Peg5mZkf0BjiYg== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: db2649cc-83c6-482a-545f-08d39a7c85b5 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1623; 2:N4f1tzeRitYcU7zeA7KcZVI+KDSGaeqgZaLbDLChV4EP6R4egbf1wOLfDFM1Ik+W3UJvicrviLFjDBrkOOXjdZLfz5jEr54CJ19yOTIfTiqYr+hMoYajIMqU3Kxtvoh6n1y7t1WZCHJtlcmQvKTWge6gl8956bBo9dy+lrYTojIjvQvw+1wrb6hBVJMY3njr; 3:jSKsfiO9KZ2NnWAHSNn2MMp7aRlDUbGGgfrjlDPHj7erkzOXzI65kC0eHsBolJkLiQG5+mRB8liTrFZshqJhT2RZvZDFL+7tOGaXZyeLLggqK225A9yMk/9DQy5hunLAJu1tYnVYBN4pAzwPIcenr9q0poUAL/GZXvcYvLVg9ZJgJw5bPhCwGORjLo5WfWR5BmLXsXtm3kAnNiLnl8PIO64386+QvBBHZz+FCyjNC+w= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB1623; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1623; 25:mrhsOwCFegM/tVRPQBBMlFs8pZa7zToduEbwHN8/Zx6FA3mZGtXLdB7Z8NlWLNuDPRzgj2V24P0hALvebUHIRUKxlhupayjhavCtC+/uePZyueytHHEbk/y+6y6xX4VrjKCC+RHgB19CKe04MYWW4nm6xkxgTRwAvu++YoqhjWh/ODgJOmDTMtCem4tLjzNrtuL1n1fAJo4GFStWk6kB/4o16NmD23Bri7JeC86N+YFZs+nBI/5dFh/AsqDw3SorTM181S3kV6GbAIL6a5axCFlqJalzj9tjwSsL78SvsbJuq+PIdILhaNnN2jNSQswjtcXHPwPFBvIt50lZBlLtzNN50Up9eRNc1D3f054EYnd/U4Iz0Z8od2gIVeJCL6iLYfptUsA86AdQpOeR312POtPnxmylPFlu4UTAWM8TlDZeTx+lfpqCr/0o/xNpGfSImvlczPK0nAYPEZ6jyuZ9FasCzgi3GsRF4n3V9A1lhNHRp4q0X2SzWC/wNUNAvG/ZrjiaSwlNrLRMqfELWa+/bxc6dRwNb8ynFHnKIU6uJHnyllsryPIbi98TaF8SAr3+gyxLKhhM9WitnZFqBWHdCqk6EaxRPS7MkCUAkGXz4oPsKEdl8sMpu9+6yyPLVxCqRrLaTuajMAE2M4+towxTvkRgQ3DIgPELKpMYrxgjcfESsnDTFPSYARipARFIuU+MiWCppv5wE3N9lZkPCS+8BdeVbS1bXyZkjfJmYAYrbecpJ/2i4nDsYIRp7lJqDw2x X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13017025)(13024025)(13018025)(13015025)(13023025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BY2PR0301MB1623; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB1623; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1623; 4:9qjPZQB1n5LSqyicxAnw5YZeoOGYtIoGY5tazlNY7snqnFxklDEblKXJkR99YzRXbxLfGI1Pi2a7fWbhSxFd/QHY52ekSGIhpakhewE1Q9T4VkgJNiMRCIPemT/yC4x0dqNHp2fgVQD9wgS1buUvXzJlRh1RF89hJXFpxbYteSBF+5FTShjrVG7GzwvuQbBUYYt9ajAIvtx/5lZFnkF571Vhbi0SdqCvY7MwTX3NrYocfPDR0YlMwZUKigjEBXHDVtiGxAlcEGhid3Ylwi+7b1YPCwma3mW9yWK4JFLV7tWU/t87zG1igt1S3WawrBqJiX8wJbK4NBARfI8SCnCrVbJijDsY/JNHu3sTm4s5UlV8pOPdfQL1KzkuFpQgq/sYcA7yIk3lDmfHc71j4cdD9lRsJfVrcEH0DlnGh9rmcS6MU6P9+2sa6j7MEMKT7yiMncI0Q2FSVRc1q7YDFTHc1ZJUhFQgS6cNZFVToA4pISzluR5T6I8mBUH30+B6vzWlv6fSxPsspmww3ZhipqAqQQ== X-Forefront-PRVS: 0981815F2F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB1623; 23:+HFtavXjb+O7IAwAYdjoE6FFHgLGhmmE2EzKCqt?= =?us-ascii?Q?+zFFYC12mTox/hbfHU0ovJOJszds86zs9mua5m2UrWCiXwjBBAiwpR6GBVGi?= =?us-ascii?Q?o+VlCxG2jWC3G7lsQWSbTHcD5TZa6htVYOIWjS/4bg/zvYr0kInvHlo5DfOv?= =?us-ascii?Q?Fh+vCINq6Vq8K0rUpHviyMwXUHXwk2xFlez1N6UHr65JodPzxUdNcs8mwDhN?= =?us-ascii?Q?SiI1SDVwwo6b69D6cBLRYXbFyTL88dprIrDbv0dt4o573zrfB0A4n6Lnk1a4?= =?us-ascii?Q?JsCUfqggoiwKyNEczopP2NuYwe3x2LAGZlVk0ZKV9nTCGw4iNB3KqnCmThuF?= =?us-ascii?Q?fbQplm6C22daCts3Ss0eLszbmrUwI0n1nLnpOwaGOXgFANk6kgXpvU7Otfsa?= =?us-ascii?Q?uskBFj4bVmjeA0fW+vW9KU1hvWwVIOfxNCx4vOhtWrTyZDmEJnn6WhOZl2w4?= =?us-ascii?Q?d+ftMbo5rc9ctTE/eH1oMhnAzE7VCSeTZD3J71rkYgI6qudTtLHQJlsry18+?= =?us-ascii?Q?PGGoceSp94IhJW6zFUNh1R4cc+xazS4flln+D5Ve9BudtrPosolDL7EP0Zt5?= =?us-ascii?Q?XhYmw5VUtgqoZl6RDmsB9vhqvFGXiqfnv6yvAFUB+cRcwXUVCdcznu1+PqsM?= =?us-ascii?Q?omig+JoL/91Fh0QNuKzjCS28LfPrI27Uo29jvBRafk9u1KR21PX9npYjhGHm?= =?us-ascii?Q?08tL7StX7pTRa9uEKP8HtDX0jW2vAMqdMFOcbCteqL1h9e4LemjZ6lkWjYZw?= =?us-ascii?Q?sLNeZB1hxj0WzjqSOB4MKi46nt+2KmDd4sVo0fe5lC8JCmj4PbhhE8mcJgrQ?= =?us-ascii?Q?moRVEmwf2wEFBbOF0cE+o6pYhMOdW14d4hyOGh1qY4ByVMmsQ8CWP7UXO1J8?= =?us-ascii?Q?0lmxVFSzD7fYE2JOR9zjS1Vw9MQTgBHTznyepE4uVTb0wK/Qyk4jb4zBbAWl?= =?us-ascii?Q?ofj1LgUUOtWaGOXib0qQulXE2xkGuZzKXhEX3LJG5ZylU1WBzKw/XmxV0IN9?= =?us-ascii?Q?S/USzIME+OqewiqnDCS0X+238gvos7kejMj4pP7KaCKcQ5DBNeL352+krm25?= =?us-ascii?Q?7GEBqrfpFHstlmziqbc+Pl7x9FfFz53Ab+ARcu+CddztqVt4FAaH/16JTgXX?= =?us-ascii?Q?Ql98DgGwST7/ZnxMeWoEhUTG5xqMd8aUX?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1623; 6:FxWm8FK4qcoNycF888xFtI5HS8aOrSivUn+tH88n2GH79KkzyMagZJBsZTUEBnoPA7fPdQqmKq2Ab3vW17QvzF7EJlDuKn0zvk5pNik4qneDtleaGe8eWaWwWve1KlK64S65KG/8jEekXX6nl5BCuJAczvaSoE9vUgzLD8NHdvIa06rZ/yJ7rCz9Tkfv+OLB9LyAaJd4allgmY2yyinS16i0xouVoMx2/NVV771t7JyinkQNBO3cTXY47L5o/mS9tcTfd+yZKqb/QVedmgh/kWs2qDN1Nk20U2mLbFn1HN4lQm5JbRC74aqc6QFco8tl; 5:89EI0Z75SkNoET73kpsCjTCVXbL1VEpslgl5c1Ucv1tyenWlrrRBSk6wpUM/0495GzlyE5Zyhem5TbjSpKpz/ZKumMfIL0TpVJ4jpzlTC5E9QqVXpq3k4czIOwVNYgbpm3mCEhqvlrNXe22aCDmeoMDXvkOPW6xcHtgRdzajDGc=; 24:Bi0/Ov8SrUhGte8AOxhBzzhldYEtlHLXZSLAjzXqI8Y+P6akJVBkKfslkxVq8PzUZdTo/dYiux4Vbal2ReCg49naELQJLURH8CoVXEMxyn8=; 7:B4+RfBNG19DEHe2iuS3hdX9kMABavYvv0Lg4tuYIhx0HVYcbcq79LSn8lh98GWtlNdHtpwhPce+XpGoQqQ2iGw1xui8n6OsIC9eFRaz2pS61K/XAhvHOQmG5kMOyTcWq/pjzvKOH1YOD/5E2MQ6LfY84eW1s9cus8Lf8lagUyCcvGp/fIlSmOut6051MLZ4sp0JqpWFZ95rTHHrI4V7OFJ/Ytz5fAEoXU+0KexouJjZFxSv8vtzEgnIoUigHN09TQai52nb4Pr2jYclWxUqNIg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 09:06:39.6439 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1623 Subject: [dpdk-dev] [PATCH v5 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 ---------------------- lib/librte_ether/rte_ethdev.h | 12 ------------ lib/librte_ether/rte_ether_version.map | 1 - 3 files changed, 35 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 312c42c..06065fe 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -340,28 +340,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -/** - * Register an Ethernet [Poll Mode] driver. - * - * Function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver. - * Invokes the rte_eal_pci_register() function to register the *pci_drv* - * structure embedded in the *eth_drv* structure, after having stored the - * address of the rte_eth_dev_init() function in the *devinit* field of - * the *pci_drv* structure. - * During the PCI probing phase, the rte_eth_dev_init() function is - * invoked for each PCI [Ethernet device] matching the embedded PCI - * identifiers provided by the driver. - */ -void -rte_eth_driver_register(struct eth_driver *eth_drv) -{ - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; - rte_eal_pci_register(ð_drv->pci_drv); -} - int rte_eth_dev_is_valid_port(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 2249466..ffd24e4 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1862,18 +1862,6 @@ struct eth_driver { }; /** - * @internal - * A function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver (PMD). - * - * @param eth_drv - * The pointer to the *eth_driver* structure associated with - * the Ethernet driver. - */ -void rte_eth_driver_register(struct eth_driver *eth_drv); - -/** * Convert a numerical speed in Mbps to a bitmap flag that can be used in * the bitmap link_speeds of the struct rte_eth_conf * diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index cf4581c..8151007 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -80,7 +80,6 @@ DPDK_2.2 { rte_eth_dev_vlan_filter; rte_eth_dev_wd_timeout_store; rte_eth_dma_zone_reserve; - rte_eth_driver_register; rte_eth_led_off; rte_eth_led_on; rte_eth_link;