From patchwork Tue Jun 21 12:02:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 14158 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 03595C316; Tue, 21 Jun 2016 14:03:10 +0200 (CEST) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0053.outbound.protection.outlook.com [157.56.110.53]) by dpdk.org (Postfix) with ESMTP id F0B70C2FA for ; Tue, 21 Jun 2016 14:03:04 +0200 (CEST) Received: from CH1PR03CA004.namprd03.prod.outlook.com (10.255.156.149) by BLUPR0301MB1620.namprd03.prod.outlook.com (10.162.214.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Tue, 21 Jun 2016 12:03:03 +0000 Received: from BL2FFO11FD044.protection.gbl (10.255.156.132) by CH1PR03CA004.outlook.office365.com (10.255.156.149) with Microsoft SMTP Server (TLS) id 15.1.501.7 via Frontend Transport; Tue, 21 Jun 2016 12:03:03 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD044.mail.protection.outlook.com (10.173.161.140) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Tue, 21 Jun 2016 12:03:02 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5LC2TDQ004076; Tue, 21 Jun 2016 05:03:00 -0700 From: Shreyansh Jain To: CC: , Date: Tue, 21 Jun 2016 17:32:38 +0530 Message-ID: <1466510566-9240-10-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131109841834002048; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(356003)(69596002)(8676002)(76176999)(81156014)(48376002)(50986999)(50466002)(7846002)(19580405001)(104016004)(81166006)(85426001)(19580395003)(87936001)(6806005)(33646002)(2351001)(36756003)(50226002)(92566002)(5003940100001)(2950100001)(229853001)(575784001)(86362001)(8936002)(105606002)(77096005)(106466001)(11100500001)(4326007)(189998001)(110136002)(586003)(97736004)(47776003)(68736007)(2906002)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB1620; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD044; 1:WEcpZoDexlMqDnF2ywHeTtt9qxgpbh/AYQxH108bHofwO4iYquv5CRpbRUjQTzmBQ3nsOpbiljx4MxPH1Cw+H3CwYGBWVmyuEVV16tqq9Fy7Umt/01kYg/HFo5yQkh0kcczXwlw7RbB4bcw5SR4RJniaZztjwm3b1ne/FnVWRQqU2pAeUup9BfPBw7rIbC6ExEZYx0tP9e+gIA8QRlQ0LG1d5sduXyDuU7n+XJ0zDWabv7kwjBgv1htnMYxEzJYuOCNadth4inyH/VQbuNz81YLuk0WmBh13LtaE/drucFTkYfyGJiTuFd6snp0hOq1Mvjn7XQGDtrazA49lNk0pBy0Xfzq8YMOzFqwwR8osSjyvkW4zdcHPuypeLKYJLlndwLyIz+YrwaX30s6GxMA9WaQvJwgsRl2bpkPtOnsNAScU8YmJcYVEcZi1nrzA/9W6R1bwO3Q9K0XOdYsNis7abxc1ePla7VjGL+h5sIJ/xkzQX8yJlkjtYGIx56qvlz0My4d6W9ZyiAu3oFY1VTaQyZ/KSW285yKrLoEW3B8zviJc+1qE7GxbHO0Nq8YpJ3c3VDsGss89UIcZfPvoBBYDkg== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f98eaf3c-0600-4cdc-c680-08d399cbff89 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 2:k2tF1Rmrx5+pOXyuaQ8lqbBKjBt+XfsCX7KU5/FC/4zkpHraAm1/1TITwpgPI1d4hHzNB4KiDts1yzDTLF8arm2x5VmTHPYTbehISN5E4VpizQRElMiyju3QtOnzGw17yK2bGZzbQlSz49SVvCWkGRRAWNoO1XknROg6J8OygB/z8joga3fQPicC5VwYW3DO; 3:xIzRRgbwKzBCZvOvRaB9GK4MkGfe6CSf0EzDOiUQgyCD8WM9laNiSw4eholrySKWHfsX1YskaJ2X4TDnMJxPoVxG9gk/N9mnTm/CYU/YS9UParcP4jUc54hOSLX+RB9ykEYFlSEb9cb+7bOlwpKEvXWWpBDYVNTH4vt4LDpZokVbz1/4rC5JepJK1bIb4tr0S2WG9SIKr7zklhe4a85GMmgyXFhR3zvJZbf7n/AsYjY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1620; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 25:lYccOHvpgk3ypHMmN9uag0f/3hXOXUyrm3qHhdFNiTjtPdgN5hVPSZ3el+dDl0pzOGkO4gfwddk93x//DKJAaPI6EBINhjEclJe7H3Gl1BDROxVGyRdwdAmOnPuX+jBBggJWt0Uwj3vvOlmRig+bl5D73FzRDiHjNFWhNR92a2KOC6fFQ/Vaw/FRJvz6PH0W11dcZWd1lJI1k1PNEcVHWbEU/G7dp6IrCQYCKzNLq/gRFrlk/m8DCv2eMsl5xBXJoZCR3yAsK/vrJXWc3LvleoNo6syj/UM/GvzG5jAVjgXkJb1O7gCmJaA25AQNThZ8LG+U4xQ6PRcVo48hVIoihNNbPLx4fowBomlGZPjNC84Px4ZKQaoj++KR3V4136c8dF9MtBS1NTw8PNUEVzwrHJonfQpTlEPuP1BRLOX4Qq9e1L3ZYVvCZ182GSXXgPhoLTob8BpwsYxom+Kw/RxF28Cim232tphETcmMuFnn6YFA6Q5so1VAqK4kqltcq67CZOdegbZS5yOZ5m1Ip2CnWh7Ghr+jQZqpvbZFf/JNhrusZFtFq5ipYWCUr+lw+ZBboCaiPWXWZSpXaaE4tlJq9Xm5gT+iI9FQCwoOKt21h/rGS995GXfYuZVo/KmGAm8P4GbU3NDt0alq7gDR03z7xqaQ1JsGeZvelauInBgc+HhRz13zUkxF0CaHyufekSfyQonqho5xZTPNY2FpUDBpEil03XTFJP02Sof9YCxRzPdxMFMBCOlv86xj3nlFvgqC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(13017025)(8121501046)(5005006)(13015025)(13024025)(13023025)(10201501046)(3002001)(6055026); SRVR:BLUPR0301MB1620; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB1620; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 4:HP7i+MgMO6xSvi2LwGRPyIdw8tCHmulmaUxJRBq8+khDN1v9VC+uKT7GtndDfyM02r414soZcc99pJ31qo5mZO5ldBTvdsm0rQ2rggi6uU2J2j9c6S28kf8R8n5wzR1Zpsi6H1oGtBo9zwA5p119ukW4OHWILZjRobvHpmEwabgv3fvDaIV/Y1otEnu7hEDWbvYZcrRiempJzhCIdT+i7n/0pAdzSMTwnaFye956btpo0mqX+CTBWRhQdVlA2RQLeOxfzmBg1cJYvaaZ4cqOZS771N66I/XlYa+EBV03X04kDNq0wrEpJEJpYNrFsmk3vDU9jJXZ6I2g3v6Pbyk7COECgivSKrI2WsVfgoHxd9N5y/cjQ9JCwjuMdDG8r6ztwnAIbCEUVxIDgKE8T2If+zDUqb3mizhCwph08fXPubLqp3u98bPkONp44n2w1TOlM/9dDaZSEKMrUGDA0iepfZgv9QxY2XcNrI89YO/8T/iOrmKIDjRQiiNnow3rLePIXNsLBeCI5qokpEwdDZqGgQ== X-Forefront-PRVS: 098076C36C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0301MB1620; 23:RTPIsw/7d7fbHGvrYAHe89Ji+LGvEopqKVSb/Nq?= =?us-ascii?Q?7mVTqxa/ctMIcv39q/Mbp3Kixrfn3c3talnNM90wcHFenb2pwnQtGTSwsXCz?= =?us-ascii?Q?tQWQMb6SEFb9LrtNcUAeDs+PRhHAIIrAbB7x5U1nvPX5RcSlfCYnVtsPPQjF?= =?us-ascii?Q?acVxpveb1tEDAvABo6L6OBW+bxjbbYpiRzKCyxuYm2YKqc1vsEgc/PiLU7NC?= =?us-ascii?Q?Y/2sP1lTWOKc8kE/KuEm6k0sswzoSpdMlRFjAYKoVPSf9SO9vYSNJ33QgpbR?= =?us-ascii?Q?AbLXrjqZ7rfY3s8NjOHlJLxJFMqsQTFzkU4ONjUwue1hC92TuVyEmRFVjIVE?= =?us-ascii?Q?FjZ2yiqbtS7Rp7ziWJCYEsI41zuhVAj5QYpAy/CquEatMd8Vfujre7X8w7X6?= =?us-ascii?Q?r41eGsPnTWdeReskM8kMPBipOGnzuz9MTi5M2WNtfVSZzyyc2+rkH7pLZprg?= =?us-ascii?Q?32+EIxWLVEVta77ty+mf+lUVib5cRNKWzdW93NVCr0wOBQ92oW6V01sPAfor?= =?us-ascii?Q?56UCZGOTxc+3yJK+XsMJxciBnbC3/t/4gMxl1Ox/rLqRH57IZgE1njNiGUb3?= =?us-ascii?Q?zWNt/Eh6vVM7CIqkUkcPsDn8u2/ByPq/5kN+3UbTzKf8hyTRGNxNsWd/wtkC?= =?us-ascii?Q?0/t8SLpwX5OK++O7sXqaTVvUblVySSnbGM/S6RT4e3buW9v90oeVl+AwrFF0?= =?us-ascii?Q?StfNXlPHQYNCwnuzeoEgwGUUSQb8yg51SpEi3UO9/1RMQKwCsjxGRL96upiz?= =?us-ascii?Q?oOyCcIVWW4+kfQahJAdk3u5seXRMByR4hxHyD7rbUF8DXFcSl/X5gxsxO/8S?= =?us-ascii?Q?bXjN7tCTS/UWqVvePvBbGzv7gmbj0BIVG/jHsAa3vVm0NlEQ11QKSsPWDShS?= =?us-ascii?Q?J5MdMGeGXqFEN75DZ7j05PNiK1xailjeXcy7wYgmv2F9hCRlNlBzUrbVfJWF?= =?us-ascii?Q?SIbLYFSgrzJVyzzDeNoHBMbUjIj5EKROMQ+w7WG57hTFEj6tqJb2G0uoM3eR?= =?us-ascii?Q?6eROZ+0+rqIgYTqiahsmWtQZWqHCKI3V6FhF/ShTXsT604saiANI8UkIuqIH?= =?us-ascii?Q?UMcUXmrnGWzBRoc7yksiOgGs3popLAtuxBuUFGJDP4S8IlJcl3M6UtXF2JA9?= =?us-ascii?Q?2cPpKqr5rLhJQXWurb3lqdKWk/J9NkQL49LmcC8jP+enGDWxztg7A6g=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 6:TuRqkb76RbTUxz9tQgp+hRi6Gfj9RTfWl+yeAAM93qveQLkV/wDbK8t/iaPyGYXWVTVGJVqfkpH6AGBlUHPLuekGTPRlyZisaCKuhEM+4Hk9U2UyLhpuH+SszkcBpDw3gdQqbu3mYZ9ZjmZI5a3PGDD3SQSHMzGb9k7hF3anWkGu+nrDKpzt9AZOU3YAhULLs7IhY1abNwPMDTVlFbXicOET1oD5UcW4S5nWy6EuK6YHm32XhJkogVPqTw/rp+o6F2YD+hnXND3gk9ECt4fg0hxcAPV3V58bIGOoAjIJ1gg=; 5:lfZl0is7eXipUALBbUcIjqNXveGrRpkJSjbo7nbqDkGu/dyspyfDwvyuIuCczHZ+Jiip6az/FuN7+lSaFH/pp2pA/khSa7NVFafWoU3dH9TAiy/1CeJH5pOqtJyRcKbhgddW9q1umVpLD4MgvHCjORomp+jgetZeqqeRSQrlRv4=; 24:WV7s8cHcQvXRxG2g+k7oy3JB+u6PrPWO2rmobC+KE1zQhYy8JVZpJuKL4WYMGJfkf3MwEuzqPYJz2r08AsC8IDAGwrL4jVnnoSEizly5oQ4=; 7:FXNMPobJ1ZVrlKB8LN5oiD3JBkXzrabe/+/gbL7VLrjiKXPvX8ttU6XHLMmWvtTBciBAsYF9zvxm0ouA3Y5kMK5yK/fxPBrlSZFtOktSRL9ejTUjWeDUKlzoVeDEDPy3Ue2M+3GKwqgktqdlpv4rx1FbHjIDQF1E/k10x0gzNY2OFE/MPD2Y5ZrFqmlV6gRJW4PdU2xtv8QGxaeA6Ku93vUtrGY7sn0Q4t53Pk+SvoLwPNDkIeVWL2vtIlxFl36C SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 12:03:02.9634 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1620 Subject: [dpdk-dev] [PATCH v4 09/17] crypto: get rid of crypto driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 ------------------- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -------------------------- lib/librte_cryptodev/rte_cryptodev_version.map | 1 - 3 files changed, 53 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 65a2e29..a7cb33a 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -444,28 +444,6 @@ rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *cryptodrv, - enum pmd_type type) -{ - /* Call crypto device initialization directly if device is virtual */ - if (type == PMD_VDEV) - return rte_cryptodev_pci_probe((struct rte_pci_driver *)cryptodrv, - NULL); - - /* - * Register PCI driver for physical device intialisation during - * PCI probing - */ - cryptodrv->pci_drv.devinit = rte_cryptodev_pci_probe; - cryptodrv->pci_drv.devuninit = rte_cryptodev_pci_remove; - - rte_eal_pci_register(&cryptodrv->pci_drv); - - return 0; -} - - uint16_t rte_cryptodev_queue_pair_count(uint8_t dev_id) { diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 3fb7c7c..99fd69e 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -491,36 +491,6 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, extern int rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); - -/** - * Register a Crypto [Poll Mode] driver. - * - * Function invoked by the initialization function of a Crypto driver - * to simultaneously register itself as Crypto Poll Mode Driver and to either: - * - * a - register itself as PCI driver if the crypto device is a physical - * device, by invoking the rte_eal_pci_register() function to - * register the *pci_drv* structure embedded in the *crypto_drv* - * structure, after having stored the address of the - * rte_cryptodev_init() function in the *devinit* field of the - * *pci_drv* structure. - * - * During the PCI probing phase, the rte_cryptodev_init() - * function is invoked for each PCI [device] matching the - * embedded PCI identifiers provided by the driver. - * - * b, complete the initialization sequence if the device is a virtual - * device by calling the rte_cryptodev_init() directly passing a - * NULL parameter for the rte_pci_device structure. - * - * @param crypto_drv crypto_driver structure associated with the crypto - * driver. - * @param type pmd type - */ -extern int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *crypto_drv, - enum pmd_type type); - /** * Executes all the user application registered callbacks for the specific * device. diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map index 8d0edfb..e0a9620 100644 --- a/lib/librte_cryptodev/rte_cryptodev_version.map +++ b/lib/librte_cryptodev/rte_cryptodev_version.map @@ -14,7 +14,6 @@ DPDK_16.04 { rte_cryptodev_info_get; rte_cryptodev_pmd_allocate; rte_cryptodev_pmd_callback_process; - rte_cryptodev_pmd_driver_register; rte_cryptodev_pmd_release_device; rte_cryptodev_pmd_virtual_dev_init; rte_cryptodev_sym_session_create;