From patchwork Thu Jun 16 14:06:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 13915 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 25D6EC726; Thu, 16 Jun 2016 16:06:46 +0200 (CEST) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0098.outbound.protection.outlook.com [65.55.169.98]) by dpdk.org (Postfix) with ESMTP id C01CEC6FC for ; Thu, 16 Jun 2016 16:06:42 +0200 (CEST) Received: from BY2PR03CA006.namprd03.prod.outlook.com (10.255.93.23) by SN1PR0301MB1632.namprd03.prod.outlook.com (10.162.130.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Thu, 16 Jun 2016 14:06:41 +0000 Received: from BY2FFO11FD027.protection.gbl (10.255.93.4) by BY2PR03CA006.outlook.office365.com (10.255.93.23) with Microsoft SMTP Server (TLS) id 15.1.492.11 via Frontend Transport; Thu, 16 Jun 2016 14:06:41 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD027.mail.protection.outlook.com (10.1.15.216) with Microsoft SMTP Server (TLS) id 15.1.511.7 via Frontend Transport; Thu, 16 Jun 2016 14:06:41 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5GE6Xo3026530; Thu, 16 Jun 2016 07:06:38 -0700 From: Shreyansh Jain To: CC: , , David Marchand Date: Thu, 16 Jun 2016 19:36:36 +0530 Message-ID: <1466086011-11920-3-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131105596013501170; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(47776003)(110136002)(586003)(189998001)(48376002)(50466002)(50226002)(8936002)(2351001)(2906002)(4326007)(97736004)(106466001)(6806005)(104016004)(36756003)(5890100001)(19580405001)(92566002)(5008740100001)(69596002)(19580395003)(11100500001)(85426001)(5003940100001)(50986999)(77096005)(2950100001)(81156014)(81166006)(229853001)(8676002)(86362001)(33646002)(356003)(575784001)(76176999)(87936001)(105606002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB1632; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; CAT:NONE; LANG:en; CAT:NONE; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD027; 1:ywry6kiVztlJIMXYLqcHCJh9KMsA7xWF+CzYa863F5zZ9YlqeRdnJkXlrkerI0QaIMgGKmYhZV8sQ2b347tDA3YWJwzP9RcwmJKFygRCPMdz6+NrEFe/Yj1pxYwmIGy1wprQlFAygzswUlyaxx7zNB419hNHKA0XdxAKkWGJkExv1lFPW63+sa37wybVmkvkbFsJqa47r+BhnXGYAqkk3+VKFAp/xIx0QVA6Ay2fdB4Ca3TwhKHOltVGxuoHk/I2qNRBUItP2QParApfgnbnmtC9kNWahFU7kPBFU1YTpcOhEm7Z19uEtKAiCjJtA7V8pU5FtZLYkCEucph6nfTGcCAEC8j9odsBnWHfMwYsC3TxWFRJ18n3pvGGO5j6e4f07Q0Zwt5YN2yR/Tud1Pu3v5ZQjIM1xeE5didm17weHp8BerUKCUjs0Vx4ezcTIs/L1YmB7e7J57aCeeH8I1Z9USYnRCry/2PC4sBtTcySgIWj+Md3C1frlIK3LkHSkdgNetDVuJQ6CBZXmpOqb9nBi8ziRPZNPSwIuniVW9o2L+fNFjG+tXpG7npG64rFaMTGkwhI+wmTvLWzI1aKaXtJtA== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e953be5d-2693-44e6-4fea-08d395ef70d7 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1632; 2:c1zNLb7KjmTiqQ8ey1u7fzVcfNfvAv+RQOivT7igSAKEHDqvJE9C878P6XKVfU/KzcIWCH7qYb6N5mfjBzKv0/7EIucG6pygjswM87M/ZOKrKlxqOslDk+lBOUSvJZlLq2o4bHwWVp/tuwiNtUw0/2kuRlhByq4EIJ5ihUrdsUfCW608Hp9ZNytHNRjs2DUK; 3:h+8vHuReCGAH2kDO6ZT3jDlW05ct8tU013OuRlrk3QMukP9sVIlpSPqfwJZ48h546eg9u8hN7GqxYLYDd0ROrGDZnSRyIG/Kq5CIXjVR5GyVlLhV6Chw8fz6BAIaEn9DO+HFJFY61hPaeY4V5GJns/TeC+yWZTEOno55buwmUdN18Gs7IEZlOb5kbjrMjQ2rMcPoXGycwctg7dxefxt6reg7QB4xbMiVI6SrnSJdpPU= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1632; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1632; 25:fa+++cmlEhlIh+Ha7JHK2LxfifRC+hm9GwST3XvIyTX4fFrREGOgpLHZL/qZDslMFhZDoJXUFj+8dKFKvYE91jyZHyNce/rqH91yAWx5E/p+feXKcznVM8mJNjOZaUTKvYYvVF/DyXkVX6vCLJ1HXFDBREM1626iSXB321uaCN7o+wXjF6XTwZTOkaS89TmTOCXyj0iQghq9iN4+oHEFNUSfbgqe16qWRGMBTpIeTSRz5OJzobTbeqJw70IhOAKUgSDp2gYZGbYi4hzUKbvHyoJWJLT+gdMZ+LtCKm+cW+EYbMyotQIGf8MlrVQepnDTM1zXwOabZPrsV3Z7lk2I6KjVEBEbti510mMU0nX+V35MCy6lSYMJYHGnvavjh5kqGiyGx/YIG4MFV40qgZWF0+pkKbjMfHulSKTnNQq4uEkBFZ2TKadatMShsUidd4yuBGBRZEdT/PzEkFuR0T0iH0ttno7ZqKAZM4PFo7kONNdBUln6Vwop26GlNE7p2Qlsp4u98nKSsiZRTkvoEHq3oYA+22xZvCiHS07Ys5lSE2DU0cIGao4XNN30Q7JgyohYYihHXyYleQpiz83KdqB6CgoBkpucSIg3mLqfFUh9Fe4HmbUNjzd+VCwYCSoTzdJgBJZmkisLyD1qc1BejZq/luqRWczWoRdh/7ekJEmBGtvUXEOo6DE33PUgIUuzxGiaIYXz1FaErdZkg1zMkvL7MjQ/84+b9MgTfxw5HAnBlwkKXVNNnNXsAt8Wsh7RNCYm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13017025)(13015025)(13023025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:SN1PR0301MB1632; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0301MB1632; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1632; 4:3qdq3UCCyW12/X1WjmZLRJNSefHgFg4oi0NijT4nM5Wlh4AlCAPldhf1Sw/3my3TUl7iJCOpLil4hWCpPJgs0d1i6psi5fiN4bexnRd5eVqfAUfvGdrzOoC3wfh8KhsqWT4bsDOCqZWpfofWCRbl7n9q5kixAvMxSnoRchCcvNsAKn4tNi7eIQnzgj+A46rtqypVMeb//FKXL8hoLXKRJ52zxLMpNVznlVIY+xKgCndDufqWDEv6B1TevHyyU7wvlVVgIJw468A3cQ8X2Pnq0/O1UPA+EDTeGR9WuOcxYK4dDjGCXXTGXyKff8iX9Sk++c6gODxRrkBtg/vDWH/woDYk8UQXwLUnJnQIKbwpqJX6lM3HXqXPuDpD1y27GutDOp030rL683dDmkrENWXFVg5zo43bG5SKA9SDAX4XwHHvAKmVI8y+HQXOpGhrcEPmTneeOL+r8eUEBUqH3ZZ4capIbNnafMlhdbPbw8vu6fM= X-Forefront-PRVS: 09752BC779 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0301MB1632; 23:3gfVXEQJmh/tlsvaOpgwwy8EVE781++uVYkocYM?= =?us-ascii?Q?ay04V3Wqb1q3Doq1guGm+Krhl9wTkHoyViLHoTLoQO7ot0WoCcWp6Czifn8k?= =?us-ascii?Q?arZNZ0FNqUYzxnNOZh/WxO64VHaa4k1NIZmWAnHLL3DoOA4S++9YOBWxzCCo?= =?us-ascii?Q?ymzOL9pxLrYDqcJqgiXMhBe5PSEV8vjwGRM/wB4n5KQJ9jCn/E6E4bm7OZWq?= =?us-ascii?Q?VDWlJVQlDgpUVDGttR8lTtPxQYAUvhSBxLE2EDrB2quj49kBnKTD8n2r84/K?= =?us-ascii?Q?Rvd4ZZCnzZEW8EPBskA0OBXD67CAACHhz9cor/bTB2Ha9yUO88EpYUaW8M6l?= =?us-ascii?Q?aTkquFaXKE7g0SjRNvI9rVyBmBhsFYwaExGZOcHKss7bceya+7XCenlRyW1j?= =?us-ascii?Q?ij5TMUabH85RYA7rB1IebN1XTyC2xOVryQ9iheKr3Q6L02euhXzQAovdnlyp?= =?us-ascii?Q?lC9rr/T8TSrErWGkaPtWzAk/lOjam5OUhFOt+AYkAmq6AhV6oH1nzI0Lswqc?= =?us-ascii?Q?qAnDZL8HPzOqZZWkh2nuGIw8M5gReA6boG6vcBUErHQUPplw1CbuQQ4svj8v?= =?us-ascii?Q?3Pnu1xAbHZxTITeGEPPkXZYHVnQxQiE8YRlxwrIh2ms9iR82xmr/j5bEsCBo?= =?us-ascii?Q?T/UKSGw9ZTCTnHVhZ0iLINYH3RzCSK+a8mR7YjG+Uyn16GpIkFVvshHrCB9S?= =?us-ascii?Q?f+iAG6UWP4lUQby4tIYLmJ4Xn4q4AK8shDXL/XTF/jhFxgT7vYQ9YIWcxcPl?= =?us-ascii?Q?/qn7qkH8SHLYVmNqozj64B/DPxm8C+7rUeEbABcKPRTRgqSX4KHd9W43k4ax?= =?us-ascii?Q?uOX2NLzku2AWpdYJ0GGb/RIU3FZ89h3piYQE+wXNkdUSgSBfcmKDVL3SiVX3?= =?us-ascii?Q?5rrncqPT4U+PZaCdcpGf1nomiOjdiWkp2W5LW3JIlLhmVMHLzU6kHVmeDHOP?= =?us-ascii?Q?Jj6GCbxw7NlXYxQBL5aUxuf9lcFNzpqZpRtpIUeOXxcdnNYHKE5jQARdAs4U?= =?us-ascii?Q?mdviixmWUImwqC21HiVswpZ9KlocNEE9ONO1odN+dUNRmSATnZDoy99s1m0i?= =?us-ascii?Q?wjrswPJZVHpfJLA7mt4Lbk5vvIMcNnaW8Rg1oacSneobLt/KeT08FtYFgHuW?= =?us-ascii?Q?0jlDdx47vhpYbjvgC+Akj+O929aVV0xTmechJzOH3uwV9rTnVT5+t4hwqoTF?= =?us-ascii?Q?2vgr5Oa7fg6/s/P8eI6mDbpfMr4gQwD2zSaYm?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1632; 6:Qv3Nfb3jyk287tmgLOF2fdrXkCbT0lR75BpXgA7CCfwgdXf2J1TihPC8rXbVl28WE8+QtoH7slTD7qf6FWjBpGy/alXkk/toqr18cE+A01NczhVHd3dpkzDJZdhxW6zMiy8J5aNlNR9ru37gXEGUXxYMunNd8mmp2seL4vulWv6Zl0nEjx6atxRp0LoDG0exOa0yIKQQGPEn8vYsHWvtsdYyRCZsLjuYmO+nJZjqUs2ho8P82UB5qXbp39+s1o/dUGoQETEDgpZFT9M7jsYnKfXk/FP0YpZ4pPWYSJQfdnA=; 5:GpZVs9UHU0v9Img1KZfSZzam8qbH51ffMPzdEl7ZFczrwHUAFp7pj0Iv+K//ngzhopz5sAV1eWIhdqm6/HMgSqbDudzVwlNeY17WZXdwrwiWDHzmZJGaIxxfdqU6gEl9W2r1jYFgpdnsuOCOmRNmEw/poORY4h4dGoBGA/1EnCk=; 24:dMADCrr/Rtac2RaP/PvxbGZVm7MpqJaODZM/bAVHmf1SlBgLJd5SJK9HpIA69j5HNt5GzZAlT1+pfFEMwAAaE7i/CIz//FlMJzCAaZ6EOVo=; 7:ANoYEQ4zURAUvHRUiRD0Eom4JbM/+hPbbCkOSTdB2nWzdwhjTKoINFExq8cFYQXWqC3XdkfjR2e+cjdbe2Ym+Nk/FRVxGFRL0eDnLeCJSBAf3tXtGPrJ4plK1sMyC31JoZpXirOo+XuxEA7Fd2Nnm3Ouakhi9VKKqxFNc1Or6cx93EK2EnDrbqj7lc05oOmKyjwxeeNdFTxjLiXWogo/JQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 14:06:41.1005 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1632 Subject: [dpdk-dev] [PATCH v3 02/17] crypto: no need for a crypto pmd type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: David Marchand This information is not used and just adds noise. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++----- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 960e2d5..b0d806c 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -230,7 +230,7 @@ rte_cryptodev_find_free_device_index(void) } struct rte_cryptodev * -rte_cryptodev_pmd_allocate(const char *name, enum pmd_type type, int socket_id) +rte_cryptodev_pmd_allocate(const char *name, int socket_id) { struct rte_cryptodev *cryptodev; uint8_t dev_id; @@ -269,7 +269,6 @@ rte_cryptodev_pmd_allocate(const char *name, enum pmd_type type, int socket_id) cryptodev->data->dev_started = 0; cryptodev->attached = RTE_CRYPTODEV_ATTACHED; - cryptodev->pmd_type = type; cryptodev_globals.nb_devs++; } @@ -318,7 +317,7 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, struct rte_cryptodev *cryptodev; /* allocate device structure */ - cryptodev = rte_cryptodev_pmd_allocate(name, PMD_VDEV, socket_id); + cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); if (cryptodev == NULL) return NULL; @@ -360,8 +359,7 @@ rte_cryptodev_init(struct rte_pci_driver *pci_drv, rte_cryptodev_create_unique_device_name(cryptodev_name, sizeof(cryptodev_name), pci_dev); - cryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, PMD_PDEV, - rte_socket_id()); + cryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, rte_socket_id()); if (cryptodev == NULL) return -ENOMEM; diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index d47f1e8..2d0b809 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -697,8 +697,6 @@ struct rte_cryptodev { enum rte_cryptodev_type dev_type; /**< Crypto device type */ - enum pmd_type pmd_type; - /**< PMD type - PDEV / VDEV */ struct rte_cryptodev_cb_list link_intr_cbs; /**< User application callback for interrupts if present */ diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 7d049ea..c977c61 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -454,13 +454,12 @@ struct rte_cryptodev_ops { * to that slot for the driver to use. * * @param name Unique identifier name for each device - * @param type Device type of this Crypto device * @param socket_id Socket to allocate resources on. * @return * - Slot in the rte_dev_devices array for a new device; */ struct rte_cryptodev * -rte_cryptodev_pmd_allocate(const char *name, enum pmd_type type, int socket_id); +rte_cryptodev_pmd_allocate(const char *name, int socket_id); /** * Creates a new virtual crypto device and returns the pointer