From patchwork Thu Jun 16 14:06:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 13922 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id F38EBCB3E; Thu, 16 Jun 2016 16:07:02 +0200 (CEST) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0083.outbound.protection.outlook.com [65.55.169.83]) by dpdk.org (Postfix) with ESMTP id C8AC9C77E for ; Thu, 16 Jun 2016 16:06:58 +0200 (CEST) Received: from CH1PR03CA012.namprd03.prod.outlook.com (10.255.156.157) by CY1PR0301MB1628.namprd03.prod.outlook.com (10.162.166.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.517.8; Thu, 16 Jun 2016 14:06:57 +0000 Received: from BY2FFO11FD056.protection.gbl (10.255.156.132) by CH1PR03CA012.outlook.office365.com (10.255.156.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.511.8 via Frontend Transport; Thu, 16 Jun 2016 14:06:57 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD056.mail.protection.outlook.com (10.1.15.193) with Microsoft SMTP Server (TLS) id 15.1.511.7 via Frontend Transport; Thu, 16 Jun 2016 14:06:57 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5GE6XoA026530; Thu, 16 Jun 2016 07:06:54 -0700 From: Shreyansh Jain To: CC: , , David Marchand Date: Thu, 16 Jun 2016 19:36:43 +0530 Message-ID: <1466086011-11920-10-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131105596174227820; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(189998001)(92566002)(2351001)(87936001)(229853001)(69596002)(106466001)(36756003)(77096005)(5008740100001)(97736004)(2950100001)(48376002)(6806005)(50466002)(105606002)(19580405001)(104016004)(110136002)(5003940100001)(47776003)(586003)(76176999)(8936002)(11100500001)(50226002)(68736007)(575784001)(86362001)(50986999)(81156014)(8676002)(33646002)(81166006)(356003)(2906002)(4326007)(85426001)(19580395003)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB1628; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; CAT:NONE; LANG:en; CAT:NONE; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD056; 1:Jvq/wvrXv9+ke6hJ3W0r1m+E0uVn8qxFDy06gTBGSHzcjqrBI6WWdWMrzYopMmGFjWQV7wg3QeSeL6efvBJsXAQEA91LBrF8GygrypgU63zqzqfDhuc1+uRbDa2KinHECiMBQYHEKUgAoBFdXoeVaO7jDabfbcAVakOa/RobbiEBUdHYZpfFcoJPqKSWUQiPDbsPen3VhJsZgbLmcub1G+dxLe5MnKM2J4WK8iCGz2SMsBvGUPj7HXIe6W+OZPY+wjgvCtUz7HFQAu+BqNO5qnxl4zZ6L6u/wL5Fa+5GDG6fD74+gqOqSwwXIJIhz6S+Urvp/rM1JUa480gGMwqWuo6A9c79CNS9MHGXDeX+VIyHMsMWsanJIn8Vdn6ZBoOBVJMHPBvZhY2OUvARkV7rHuOcoyp6TUg40/o2e+SHkRfY4ZWHWm4ltzVjTWk8DgV3AGCDShhVuE8GXuYAd9P+waR+MMoA2N6fCfSaMz4vBCo18Nza9NZcG0zLlgoH3LYJtU7t8OXXeWE/W5+QxqkPN8FNKdTdV8r+lazjKSuFuIIZR1KuPVIiqJ/4h3cX9igg7DynNz4eKVt1HoBzHBz1QA== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8c6ee36c-74ea-4023-6d15-08d395ef7a69 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1628; 2:7Xd7EOzFmRXPIN41D/SM1KUPaSI+x3KlG6Nxq0n3QeUuQ/loj3OCnYBvGM5yo6N29J/bPiNfJvnkxcC2frbKXdQ5fD/z3aduW8PjDCBX4JBHfaNeFNb9KK13QXlVYifBE9qwz7vHxz+ERpMQCu2rBYROmzJleoPwHv1ZLxVWArvo7v6c7A6CO2R6E/e8x4k0; 3:ahzZooqnEtUKomKiuTH1CFrbbp++E10ukb8SRyTxj3wmc6RAbYqlgIjBh9qX97YBbbpJV7VsH+kmjn7VRR9Rq5v34MxdvK/U8s388AQNsIpVFo+c4UhwJf4Z5DWvT7hZuzom7gnDk/UsWRogAUdDPiXK1RUs0bESkIll8WC2oCLQpLT7Bo9PJoOWqUJrV1toZSP38qjCOs2PTqrp0pUgcBr5Uk/Z0j8cdxA9bxdsJ7o= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1628; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1628; 25:QRGPMRa023Je+b3wUC/TBcLFvP0bGJej43rio68s/ikCRF2hQ32FYfKetv8mrd97IH5mYZYCP8ixpQ0XSzaMEKzilfvkDHIBisQj/AXkUSttehiZmQhTo+i40HuA0Zd2Eyo8TLGKurDsXpWYj7y39X8RsZIqunJdZ5QW5hjuqohb0pgR9QpQvQpQt2GWRYvZsZ35JP5yZ6P76AByAgdXzF/hblFCA1QWrnCvH5NAL1Nul03iz4OxG8dXTX3DI3Of3PVhLHNpLpIOJ/fWqXD4jR2LhAzZVN85VhrrDa1PAvGHn/7fa/TZ/9isHmA+Rp5z//ghRBgKU9JzLRBG40v3kZqxsKu3Y1WT+0BZv5CuWFLFE9PhMlOsmtOpEGUmCG7XEe7cMV+jMCE3oy1R3cu4U9U/eC18OWNaqT0nfVupFmXWDCo2rfrmKyTaMtkj4k9qbqrFro9baAnQ/NoXCFFfCx+l5UiPKMWSNM4p34BTBizcPBdVVR4+XZPKuORBOi5QKWxQ0E7YI5HqAGjBVWRtHTfg5+XvzSONkfbZl7qaDnc4s2wjcCfYtjH1oLC+tRVJXAQg/L3p6ovToBkbDn8V/Xge13iXZ5fTz0QnSS4CxgRnloJIwofOI9ynMhdIybDsotJ6N79Y7T8pkIRFOX/RKLGHoN809mw9R87Or3SOknAUR1P3o79+t2/D+/5klAHQTAM3uOlmaVQMWXmpI5efSAmpnwceVefcAL1Wt0ks22w7rGY8ajgAbX7pHJ4wHFlI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(13023025)(13024025)(13015025)(13017025)(13018025)(3002001)(10201501046)(6055026); SRVR:CY1PR0301MB1628; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB1628; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1628; 4:1i/ymOw3nz44gVK8u4rPv8VIUEOz7z66ddMpJtCUR4Lhk8tA+hWxcJffuAUgDXGU67fN2SKmjeaM7TTKF482IzXTTn6TAdX3Hdr864CCCps+4wSehBazhg28v9UdPpp/38i5XUCBy2NqZrTfXxzu3WKpGEtB+4W7V3Fcuybq9NRBCZZDTGDE0PqfY593+p1D7gv0/61eJwTQCC+KbW0o8PQ3yNWNZQVAyWvpBpHnNant5I6myeWKyjKLV8XM/2pTmPhXJuSZB8eS3bSu6ck5CSvk+4J96f0uwyobwMbZUz3+C0xhEoghmiAtR16idiFsoJShH6Q8ZgJjpAZJKf/E6x2BOm9frzdbd1sW620Qjdoi4Coa5eFOWSRsAGCoMgZi03PO7LCHvW9i4RnQoMBpu5oohKCmbWusAS2ohzzNMUV+byQ1QodQbfvNYVzH5IIWo41AbAfjn+M3Mzvvlgplfof+XdUuEUcWBl/wpYaq14M= X-Forefront-PRVS: 09752BC779 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB1628; 23:tpNQpq/3mnWTXjOcWG981l0OS0mvORHOGcH3/b8?= =?us-ascii?Q?Jafsx4RCJFeWtpW99j0Nb6H2L73GnaKgH3bEbpOhxfaPX4zgn7KF2A9mn+qQ?= =?us-ascii?Q?J7JPKgLHPfFRBOiE1TRy0qVaGFZBcx7wH1rHMfhnUYRC05qcfr1eSQ2/RKZY?= =?us-ascii?Q?rOriZyQZu7CjSwPsLmh3O6wHw7d/9azM8X1uRliS9V3afwKYDrE5bJi/2jEe?= =?us-ascii?Q?l6Lq4jCWESwtuWE+yR5taCJrwJnRSuNF8tMG0SKnl4w6i8F4XrtjO8N2iqte?= =?us-ascii?Q?LQc6Bk89er/q/EhbZXdvRTZEsoWW3wtbH7vR37S7IXcuxzWgafUFL1yVMTvn?= =?us-ascii?Q?Pi1BXEu0kP9IK0u2PgteZu6VuQMSzXe5vdISTG4lCnZBtHG6f13WKKd+8t3q?= =?us-ascii?Q?YgoJJF4H1TQAkmFDZG02Eb2bICwCRn5IRPeCe4W9TgTKzE9XPsQcML0esHSf?= =?us-ascii?Q?dlFx5JrugYhGDkiGYdCN097skhw6PXczpSsgAPRucQ6mJA/xTXStxdnaMm39?= =?us-ascii?Q?XbJ8Q9mSDqYjbYVzrDAzn0Y8I1VgWmnOWyw18QjnOLQ/EkUZ7nfUD7vZEYms?= =?us-ascii?Q?9Oq9e/rhDAV1aL2vx4jUmoTypKBX1n420NuZGkw5nbCq9rrbsnJ1qB5Lbx3M?= =?us-ascii?Q?UBo9lqqHwGpLqLfLYD/stVBTharXJa6lJmRI3VCm+jEZ5TpwrABD0N66I+/z?= =?us-ascii?Q?+Ps6ej0nRqL/ndqxxqXP+Zt1CDmsrOezpa2iPUtCHj2kVxd08HOCZvgtFLXv?= =?us-ascii?Q?1JdYLhAg5Qoom/Kz0jYjO/bfyxpXolKdSgmCVqNjtscfiajkDHNM9tWOEao/?= =?us-ascii?Q?hjm2iwnMSHBYhPFqGohBpKz71McbZwMI1Z+SLbqaZy/WuqHzmbO1BlaJSnef?= =?us-ascii?Q?4YHZEUIkzuJyGPbeuDEPeqCVm6dGW/xXKSOdvPdNhfJOZoNDe0BNfwFOHNAV?= =?us-ascii?Q?cNuvlctt6KmX+YEUNuiilUE5wuk/YIo3AKfN6Hj+jDDtvWeSyUXWrlA81LBg?= =?us-ascii?Q?DNipiu4M3JE6wSxaXiyNRAt2f//8htMilewFKWTN7ckAHhZqeYU0TVx/qxSG?= =?us-ascii?Q?SbuFLzw5Z/u/O2YVvSeJONtObLdQSsScrfi94HcTbb03oLrVqgYJ5ZiWcZfj?= =?us-ascii?Q?JHLjrjMbxTfCTZLCDG0utcRe0GqSveQ5Ks+5VmqP8Cy2ZDdtRfla5pRfEWXh?= =?us-ascii?Q?YjVLdzxiu8F7tQIJ6gxP2qK5ASPisGLKcOqf9?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1628; 6:azFpUbsjQ0pJ552yu9KnVWnkozzh2gRRASLIV8ZinLaa5+sGV6ItEIaMHGbriE5NJ6T7qBoZNVO1VgkBbs0s5rWKwnRrWo4sWcwnWcgztEqqevGQQrMYDGcpgmynOYoxuREVdvWTrAGxB2pKHTRVJSr4x2O8hiKedS3JMmdwX8Wr9tJ7DfzifPV9JT+tTviS2BzHLW/yS+GHSEJcN1i2o5r4ehFhLvV8qi2p4eX/YR6WO8LN+crIteXh2Da2u4aaaPdyN3/grfwpyv113GTsuZgbKnpaRZTr//uIOA8fl/c=; 5:urdGLjzlkM17enGs4qPJHhMyPrdttx8NvPNTiVe1A+1bKm2P8Veu+BTiI9bgZVSgs3VaNgdfr/eTQ7hRBLWAH1QnqhYvny0evf8HXbgxHAKFrDwb3ZSJpKaid8JVhiFCj9A+4sV8CzhUl1tWnjF3K6BkVyUxzLRYccQA4B3gH78=; 24:L56KjFGIi1M1PSUQdgFsI8eH7ngsnmjE2mUGg/QQVOKiKI8TB0a4AXqKomBh+NQMIO86rmwTtDW1hJTe2pGhkC5bkVtpLO/NhrAFjPFx66U=; 7:7Vjzji/OOtE5KAJZzjPnkTsZtUlGLAhF6xZUjW2P6u11Gi182anX6sUdE3Yq/mHQa95X6n+seKgymFjY4snzSHsn+matmaKrZP/8ZSOVJBwpd10MSGnQwOV4dvxFcq6aTXAV/cRqXWr+AgUG/oGHljNutYayBIiQICquacxX+XvvYsa9awCaeIiwknshUjC5nnhHV4jHRF28z2tC4PcJ9w== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 14:06:57.1575 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1628 Subject: [dpdk-dev] [PATCH v3 09/17] crypto: get rid of crypto driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: David Marchand Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 22 ------------------- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -------------------------- lib/librte_cryptodev/rte_cryptodev_version.map | 1 - 3 files changed, 53 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 65a2e29..a7cb33a 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -444,28 +444,6 @@ rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *cryptodrv, - enum pmd_type type) -{ - /* Call crypto device initialization directly if device is virtual */ - if (type == PMD_VDEV) - return rte_cryptodev_pci_probe((struct rte_pci_driver *)cryptodrv, - NULL); - - /* - * Register PCI driver for physical device intialisation during - * PCI probing - */ - cryptodrv->pci_drv.devinit = rte_cryptodev_pci_probe; - cryptodrv->pci_drv.devuninit = rte_cryptodev_pci_remove; - - rte_eal_pci_register(&cryptodrv->pci_drv); - - return 0; -} - - uint16_t rte_cryptodev_queue_pair_count(uint8_t dev_id) { diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 3fb7c7c..99fd69e 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -491,36 +491,6 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, extern int rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); - -/** - * Register a Crypto [Poll Mode] driver. - * - * Function invoked by the initialization function of a Crypto driver - * to simultaneously register itself as Crypto Poll Mode Driver and to either: - * - * a - register itself as PCI driver if the crypto device is a physical - * device, by invoking the rte_eal_pci_register() function to - * register the *pci_drv* structure embedded in the *crypto_drv* - * structure, after having stored the address of the - * rte_cryptodev_init() function in the *devinit* field of the - * *pci_drv* structure. - * - * During the PCI probing phase, the rte_cryptodev_init() - * function is invoked for each PCI [device] matching the - * embedded PCI identifiers provided by the driver. - * - * b, complete the initialization sequence if the device is a virtual - * device by calling the rte_cryptodev_init() directly passing a - * NULL parameter for the rte_pci_device structure. - * - * @param crypto_drv crypto_driver structure associated with the crypto - * driver. - * @param type pmd type - */ -extern int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *crypto_drv, - enum pmd_type type); - /** * Executes all the user application registered callbacks for the specific * device. diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map index 8d0edfb..e0a9620 100644 --- a/lib/librte_cryptodev/rte_cryptodev_version.map +++ b/lib/librte_cryptodev/rte_cryptodev_version.map @@ -14,7 +14,6 @@ DPDK_16.04 { rte_cryptodev_info_get; rte_cryptodev_pmd_allocate; rte_cryptodev_pmd_callback_process; - rte_cryptodev_pmd_driver_register; rte_cryptodev_pmd_release_device; rte_cryptodev_pmd_virtual_dev_init; rte_cryptodev_sym_session_create;