[dpdk-dev,v5,3/3] mbuf: get default mempool handler from configuration

By default, the mempool handler used for mbuf allocations is a multi
producer and multi consumer ring. We could imagine a target (maybe some
network processors?) that provides an hardware-assisted pool
mechanism. In this case, the default configuration for this architecture
would contain a different value for RTE_MBUF_DEFAULT_MEMPOOL_HANDLER.

Signed-off-by: David Hunt <david.hunt@intel.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 config/common_base         |  1 +
 lib/librte_mbuf/rte_mbuf.c | 21 +++++++++++++++++----
 2 files changed, 18 insertions(+), 4 deletions(-)
  

On Thu, 19 May 2016 14:45:01 +0100
David Hunt <david.hunt@intel.com> wrote:

> By default, the mempool handler used for mbuf allocations is a multi
> producer and multi consumer ring. We could imagine a target (maybe some
> network processors?) that provides an hardware-assisted pool
> mechanism. In this case, the default configuration for this architecture
> would contain a different value for RTE_MBUF_DEFAULT_MEMPOOL_HANDLER.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> ---
> config/common_base         |  1 +
>  lib/librte_mbuf/rte_mbuf.c | 21 +++++++++++++++++----
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/config/common_base b/config/common_base
> index 3535c6e..5cf5e52 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -394,6 +394,7 @@ CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG=n
>  #
>  CONFIG_RTE_LIBRTE_MBUF=y
>  CONFIG_RTE_LIBRTE_MBUF_DEBUG=n
> +CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_HANDLER="ring_mp_mc"
>  CONFIG_RTE_MBUF_REFCNT_ATOMIC=y
>  CONFIG_RTE_PKTMBUF_HEADROOM=128
>  
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index eec1456..5dcdc05 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -153,6 +153,7 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,
>  	unsigned cache_size, uint16_t priv_size, uint16_t data_room_size,
>  	int socket_id)
>  {
> +	struct rte_mempool *mp;
>  	struct rte_pktmbuf_pool_private mbp_priv;
>  	unsigned elt_size;
>  
> @@ -167,10 +168,22 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,
>  	mbp_priv.mbuf_data_room_size = data_room_size;
>  	mbp_priv.mbuf_priv_size = priv_size;
>  
> -	return rte_mempool_create(name, n, elt_size,
> -		cache_size, sizeof(struct rte_pktmbuf_pool_private),
> -		rte_pktmbuf_pool_init, &mbp_priv, rte_pktmbuf_init, NULL,
> -		socket_id, 0);
> +	mp = rte_mempool_create_empty(name, n, elt_size, cache_size,
> +		 sizeof(struct rte_pktmbuf_pool_private), socket_id, 0);
> +	if (mp == NULL)
> +		return NULL;
> +
> +	rte_mempool_set_handler(mp, RTE_MBUF_DEFAULT_MEMPOOL_HANDLER);

Check for a failure is missing here. Especially -EEXIST.

> +	rte_pktmbuf_pool_init(mp, &mbp_priv);
> +
> +	if (rte_mempool_populate_default(mp) < 0) {
> +		rte_mempool_free(mp);
> +		return NULL;
> +	}
> +
> +	rte_mempool_obj_iter(mp, rte_pktmbuf_init, NULL);
> +
> +	return mp;
>  }
>  
>  /* do some sanity checks on a mbuf: panic if it fails */
  

On 5/23/2016 1:40 PM, Jan Viktorin wrote:
> On Thu, 19 May 2016 14:45:01 +0100
> David Hunt <david.hunt@intel.com> wrote:

--snip--

>> +	mp = rte_mempool_create_empty(name, n, elt_size, cache_size,
>> +		 sizeof(struct rte_pktmbuf_pool_private), socket_id, 0);
>> +	if (mp == NULL)
>> +		return NULL;
>> +
>> +	rte_mempool_set_handler(mp, RTE_MBUF_DEFAULT_MEMPOOL_HANDLER);
> Check for a failure is missing here. Especially -EEXIST.

Done.

--snip--


Thanks,
Dave.