From patchwork Wed Apr 20 11:44:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 12124 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 733C247D0; Wed, 20 Apr 2016 13:44:28 +0200 (CEST) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 29FD72C4B for ; Wed, 20 Apr 2016 13:44:25 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id u206so76776328wme.1 for ; Wed, 20 Apr 2016 04:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lkrkVrslaJ/0C/ZLj9qUAFax5rtRHxZyZBQBK/FfJFI=; b=zmQhxHcHy5zZq/9jLaBUKM1nGR6+rMlfLtQjCCqtbZ82k/6NEMjuFk5fRTH29QubNl bTo1ijUhUoECeWjHBzzCmw5Y8P24ZI6EnO62dlu1V0caRJA44qjToN5MhtFPja1QRJ4U GZ7RSbb8LiPejFJIJLcvA0Q9Es6alJsfa4vb3VYRqW3Eb5hdJfBpQrvUksVGcTYJe37m hJH5+YbQxn1O64j2i0gRE5uRKq2HjpVs7CekBi3YA4VtAwuKMn7Scn5/ORyfFLUB/bgN l73zgV92OUFc5tcMe3Lg7pSgNTPFJhVQXBZSuA2V2EK3je6dPoltmXWKK98fVleRQ6yn dJHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lkrkVrslaJ/0C/ZLj9qUAFax5rtRHxZyZBQBK/FfJFI=; b=LZJUcu9Z6RnUePM4DZNIcz8tWy66pKH1/4xW/ot1HBUYbqDXhceW/VL/v6Z2ZGiejf LYhgFkZOVML77vCdDpfX5+xiPZKjxJp7bIcPNXYLSLlmfwBB7w7uiqUkqbeiMOYUAESu bcmEXTuZP60FJFPu5L/04jSM3HS8szxee4MYKMuvju1PpjGo46lJ1VSno/oINJS1lA5B yUnUhEGW79ra41EPTxDXRBtFGV7cmG41eZAo28037PfqjX9RxtwC6K91eoxDTfKlESMJ yOKddBUj0b/gHwSlQaNZin3l7Y2ld8LEP3U8ppQ+67PgbcDXsgeMcjAyFPDgtOPYt/wA xvSQ== X-Gm-Message-State: AOPr4FUYYBtboRdoO485j6oJY8ErmB5rjgT3voXhDOPb06ZbQC8hXbMA1UABgXr0e5kqgMdD X-Received: by 10.28.100.132 with SMTP id y126mr30201198wmb.91.1461152664938; Wed, 20 Apr 2016 04:44:24 -0700 (PDT) Received: from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net. [78.126.77.144]) by smtp.gmail.com with ESMTPSA id m6sm5195708wje.21.2016.04.20.04.44.23 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 20 Apr 2016 04:44:24 -0700 (PDT) From: David Marchand To: dev@dpdk.org Cc: thomas.monjalon@6wind.com, viktorin@rehivetech.com Date: Wed, 20 Apr 2016 13:44:02 +0200 Message-Id: <1461152657-19969-3-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461152657-19969-1-git-send-email-david.marchand@6wind.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-1-git-send-email-david.marchand@6wind.com> Subject: [dpdk-dev] [PATCH v2 02/17] crypto: no need for a crypto pmd type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This information is not used and just adds noise. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++----- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index aa4ea42..bf35df0 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -230,7 +230,7 @@ rte_cryptodev_find_free_device_index(void) } struct rte_cryptodev * -rte_cryptodev_pmd_allocate(const char *name, enum pmd_type type, int socket_id) +rte_cryptodev_pmd_allocate(const char *name, int socket_id) { struct rte_cryptodev *cryptodev; uint8_t dev_id; @@ -269,7 +269,6 @@ rte_cryptodev_pmd_allocate(const char *name, enum pmd_type type, int socket_id) cryptodev->data->dev_started = 0; cryptodev->attached = RTE_CRYPTODEV_ATTACHED; - cryptodev->pmd_type = type; cryptodev_globals.nb_devs++; } @@ -318,7 +317,7 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, struct rte_cryptodev *cryptodev; /* allocate device structure */ - cryptodev = rte_cryptodev_pmd_allocate(name, PMD_VDEV, socket_id); + cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); if (cryptodev == NULL) return NULL; @@ -360,8 +359,7 @@ rte_cryptodev_init(struct rte_pci_driver *pci_drv, rte_cryptodev_create_unique_device_name(cryptodev_name, sizeof(cryptodev_name), pci_dev); - cryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, PMD_PDEV, - rte_socket_id()); + cryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, rte_socket_id()); if (cryptodev == NULL) return -ENOMEM; diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index d47f1e8..2d0b809 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -697,8 +697,6 @@ struct rte_cryptodev { enum rte_cryptodev_type dev_type; /**< Crypto device type */ - enum pmd_type pmd_type; - /**< PMD type - PDEV / VDEV */ struct rte_cryptodev_cb_list link_intr_cbs; /**< User application callback for interrupts if present */ diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 7d049ea..c977c61 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -454,13 +454,12 @@ struct rte_cryptodev_ops { * to that slot for the driver to use. * * @param name Unique identifier name for each device - * @param type Device type of this Crypto device * @param socket_id Socket to allocate resources on. * @return * - Slot in the rte_dev_devices array for a new device; */ struct rte_cryptodev * -rte_cryptodev_pmd_allocate(const char *name, enum pmd_type type, int socket_id); +rte_cryptodev_pmd_allocate(const char *name, int socket_id); /** * Creates a new virtual crypto device and returns the pointer