From patchwork Tue Apr 19 20:47:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 12121 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 894BE2C6A; Tue, 19 Apr 2016 22:47:38 +0200 (CEST) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id DD42B2C5A for ; Tue, 19 Apr 2016 22:47:36 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id e201so28120559wme.0 for ; Tue, 19 Apr 2016 13:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=WPwhKAg25nYQzX/TCy/3SHi8SuATLcrkIB3+7htGWKY=; b=uDUtOx2QKAgNeOmYWjItxWW13YrqFtmkbQDkAEjiSqMrA0FzoY593bv8VdCQErA3JL 8yPquj8UOWzzWIvBpE6LlZxiUg3eylbd7F+y/yzf5h2Ie9HwejrdtFVlIpsgtBPI4dJq hSpFwQtf1IBN68J8iMu4iI1Q0PqzkCdXtLHUjO/dNshnZZ50W+wWI2N/nzfD897XiRrF Y8hqTfgNFle8WrXJmmHwBUefLiFhsFDLsjBU9EbJCluoN0UYfKy8OBcfRMpPbShX+rjq DrLCmJa3N8q8pFYXOSZiylln8mjsLBAH4lEaG0R8MlZBJQlCP4KOB1AyyHMYelIMwmsO Rq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WPwhKAg25nYQzX/TCy/3SHi8SuATLcrkIB3+7htGWKY=; b=QysVFCx1HT46x4yslidOlHgI6Lni0kOYu8tdm+/BYMxvGetNB3DZnn8gcRMmmOoGzp dtcMrI6X9k92vPNzw1JhttpqaFMXgp0wDjyRXFbJOfr6okUl+6Dyd7D8xXczyVXdB1v7 VOye8U81mX0p/fGY2SdNtS/wtHS1nE9m8d5VVx0xVCrxXcA0eO1HWVjr6S4/OBXKXMZO 5+DRa3Bo8E53509vEEv+g0sgeH/y96DkjrPM0IQqH9xcpjwmGzlEYp4KRuQgcuHJbWo9 B1h1nRQBPZ8MqiMiOAa08w+gz6oWU+IauA5HOYZc+umTzEcCOh+VQqwHvhrtTZk4gzc5 Bl8w== X-Gm-Message-State: AOPr4FXBk82fzZdiOdIRXnRpoaFTc2XF3aX7lWzoYQji5JZD/9cBp0tAkMyfYHtjo+3WQwl5 X-Received: by 10.28.24.80 with SMTP id 77mr25229792wmy.16.1461098856708; Tue, 19 Apr 2016 13:47:36 -0700 (PDT) Received: from XPS13.localdomain (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id u192sm6094762wmd.11.2016.04.19.13.47.35 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2016 13:47:36 -0700 (PDT) From: Thomas Monjalon To: david.marchand@6wind.com Cc: dev@dpdk.org Date: Tue, 19 Apr 2016 22:47:05 +0200 Message-Id: <1461098825-21640-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH] eal: remove useless internal function from memcpy headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function rte_memcpy_func() is used in ARM and PPC implementations of rte_memcpy(). There are some useless copies in Tile and some ARM branches. It was also declared without doxygen comment in the generic header. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 6 ------ lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h | 6 ------ lib/librte_eal/common/include/arch/tile/rte_memcpy.h | 6 ------ lib/librte_eal/common/include/generic/rte_memcpy.h | 7 ------- 4 files changed, 25 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h b/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h index 988125b..da6c233 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h @@ -323,12 +323,6 @@ rte_memcpy(void *dst, const void *src, size_t n) return memcpy(dst, src, n); } -static inline void * -rte_memcpy_func(void *dst, const void *src, size_t n) -{ - return memcpy(dst, src, n); -} - #endif /* RTE_ARCH_ARM_NEON_MEMCPY */ #ifdef __cplusplus diff --git a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h index 917cdc1..5db66b6 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h @@ -80,12 +80,6 @@ rte_mov256(uint8_t *dst, const uint8_t *src) #define rte_memcpy(d, s, n) memcpy((d), (s), (n)) -static inline void * -rte_memcpy_func(void *dst, const void *src, size_t n) -{ - return memcpy(dst, src, n); -} - #ifdef __cplusplus } #endif diff --git a/lib/librte_eal/common/include/arch/tile/rte_memcpy.h b/lib/librte_eal/common/include/arch/tile/rte_memcpy.h index 9b5b37e..e606957 100644 --- a/lib/librte_eal/common/include/arch/tile/rte_memcpy.h +++ b/lib/librte_eal/common/include/arch/tile/rte_memcpy.h @@ -80,12 +80,6 @@ rte_mov256(uint8_t *dst, const uint8_t *src) #define rte_memcpy(d, s, n) memcpy((d), (s), (n)) -static inline void * -rte_memcpy_func(void *dst, const void *src, size_t n) -{ - return memcpy(dst, src, n); -} - #ifdef __cplusplus } #endif diff --git a/lib/librte_eal/common/include/generic/rte_memcpy.h b/lib/librte_eal/common/include/generic/rte_memcpy.h index 03e8477..afb0afe 100644 --- a/lib/librte_eal/common/include/generic/rte_memcpy.h +++ b/lib/librte_eal/common/include/generic/rte_memcpy.h @@ -134,11 +134,4 @@ rte_memcpy(void *dst, const void *src, size_t n); #endif /* __DOXYGEN__ */ -/* - * memcpy() function used by rte_memcpy macro - */ -static inline void * -rte_memcpy_func(void *dst, const void *src, size_t n) __attribute__((always_inline)); - - #endif /* _RTE_MEMCPY_H_ */