From patchwork Tue Mar 8 18:49:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 11219 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9DCE42935; Tue, 8 Mar 2016 19:49:37 +0100 (CET) Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id CFBAC2142 for ; Tue, 8 Mar 2016 19:49:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1117; q=dns/txt; s=iport; t=1457462975; x=1458672575; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=SwdqxQYEpmL3oOcuBbSkSGfk+yRukia2kYsRXRA/+X0=; b=bC8tYN+h02YV1gn8z18oSmIHqQakSYpsrWuRglOyZKuznvs5oG8+r5BY +Sc/0AiRYtAvlv0qCuQjYWFjIRvbXky1khkKfg9L5z7X3y8EDeCyzz2Jh vMAncJvmozAYVsFqxTvDJAewVoD9bJAMtM3wPveJCh/nmDefZhtDhOvX8 c=; X-IronPort-AV: E=Sophos;i="5.22,557,1449532800"; d="scan'208";a="247001935" Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Mar 2016 18:49:35 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id u28InYL7000312; Tue, 8 Mar 2016 18:49:35 GMT Received: by cisco.com (Postfix, from userid 392789) id C0D333FAADAF; Tue, 8 Mar 2016 10:49:34 -0800 (PST) From: John Daley To: dev@dpdk.org Date: Tue, 8 Mar 2016 10:49:07 -0800 Message-Id: <1457462947-22845-1-git-send-email-johndale@cisco.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1456105516-520-1-git-send-email-johndale@cisco.com> References: <1456105516-520-1-git-send-email-johndale@cisco.com> Cc: johndale Subject: [dpdk-dev] [PATCH v4] enic: fix last packet being not sent bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: johndale The last packet of the tx burst function array was not being emitted until the subsequent call. The nic descriptor index was being set to the current tx descriptr instead of one past the the descriptor as required by nic. Fixes: d739ba4c6abf ("enic: improve Tx packet rate") Signed-off-by: John Daley --- Use full nime in 'Signed-off-by', add 'Fixes:'. drivers/net/enic/base/enic_vnic_wq.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enic/base/enic_vnic_wq.h b/drivers/net/enic/base/enic_vnic_wq.h index e3ea574..b019109 100644 --- a/drivers/net/enic/base/enic_vnic_wq.h +++ b/drivers/net/enic/base/enic_vnic_wq.h @@ -69,11 +69,11 @@ static inline void enic_vnic_post_wq(struct vnic_wq *wq, buf->wr_id = wrid; buf = buf->next; - if (cq_entry) - enic_vnic_post_wq_index(wq); + wq->ring.desc_avail -= desc_skip_cnt; wq->to_use = buf; - wq->ring.desc_avail -= desc_skip_cnt; + if (cq_entry) + enic_vnic_post_wq_index(wq); } #endif /* _ENIC_VNIC_WQ_H_ */