diff mbox

[dpdk-dev,v2,01/16] fm10k: use default mailbox message handler for pf

Message ID 1453866647-16215-2-git-send-email-xiao.w.wang@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Xiao Wang Jan. 27, 2016, 3:50 a.m. UTC 
  The new share code makes fm10k_msg_update_pvid_pf function static, so we can
not refer to it now in fm10k_ethdev.c. The registered pf handler is almost the
same as the default pf handler, removing it has no impact on mailbox.

Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
---
 drivers/net/fm10k/fm10k_ethdev.c | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

Comments

Bruce Richardson Feb. 16, 2016, 10:50 a.m. UTC | #1 
On Wed, Jan 27, 2016 at 11:50:32AM +0800, Wang Xiao W wrote:
> The new share code makes fm10k_msg_update_pvid_pf function static, so we can
> not refer to it now in fm10k_ethdev.c. The registered pf handler is almost the
> same as the default pf handler, removing it has no impact on mailbox.
> 
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>

While the patch itself looks ok, checkpatch gives a warning about the commit
message being too long.

  WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a
  maximum 75 chars per line)
  #6:
  The new share code makes fm10k_msg_update_pvid_pf function static, so we can

  total: 0 errors, 1 warnings, 0 checks, 31 lines checked

Since the next patch breaks compilation, a V3 will be needed, so please fix this
warning in the process. I'd also ask that you run checkpatch on all patches
before submitting and fix any issue raised.

Thanks,
/Bruce
Xiao Wang Feb. 18, 2016, 10:25 a.m. UTC | #2 
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, February 16, 2016 6:50 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> <shaopeng.he@intel.com>
> Subject: Re: [PATCH v2 01/16] fm10k: use default mailbox message handler for
> pf
> 
> On Wed, Jan 27, 2016 at 11:50:32AM +0800, Wang Xiao W wrote:
> > The new share code makes fm10k_msg_update_pvid_pf function static, so
> > we can not refer to it now in fm10k_ethdev.c. The registered pf
> > handler is almost the same as the default pf handler, removing it has no
> impact on mailbox.
> >
> > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> 
> While the patch itself looks ok, checkpatch gives a warning about the commit
> message being too long.
> 
>   WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit
> description (prefer a
>   maximum 75 chars per line)
>   #6:
>   The new share code makes fm10k_msg_update_pvid_pf function static, so we
> can
> 
>   total: 0 errors, 1 warnings, 0 checks, 31 lines checked
> 
> Since the next patch breaks compilation, a V3 will be needed, so please fix this
> warning in the process. I'd also ask that you run checkpatch on all patches
> before submitting and fix any issue raised.

Thanks for the comment, I used an old checkpatch.pl to check the patches, it gave
no warning. I have updated the checkpatch.pl and got the above warning.
I will rework the patch set, thanks again.

> 
> Thanks,
> /Bruce
Xiao Wang Feb. 19, 2016, 11:06 a.m. UTC | #3 
v3:
* Fixed checkpatch.pl warning about long commit message.
* Fixed the issue of compile failure about part of patches applied.
* Split the misc-small-fixes patch into several patches.

v2:
* Put the two extra fix patches ahead of the base code patches.

This patch set has passed regression test.

Wang Xiao W (18):
  fm10k: use default mailbox message handler for PF
  fm10k/base: correct typecast in fm10k_update_xc_addr_pf
  fm10k/base: cleanup namespace pollution
  fm10k/base: use bitshift for itr_scale
  fm10k/base: reset max_queues on init_hw_vf failure
  fm10k/base: document ITR scale workaround in VF TDLEN register
  fm10k/base: cleanup lines over 80 characters
  fm10k/base: cleanup useless else
  fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
  fm10k/base: do not use CamelCase
  fm10k/base: use memcpy for mac addr copy
  fm10k/base: allow removal of is_slot_appropriate function
  fm10k/base: consistently use VLAN ID when referencing vid variables
  fm10k/base: imporve comment per upstream review changes
  fm10k/base: fix TLV structures alignment
  fm10k/base: move constants to the right of binary operators
  fm10k/base: minor cleanups
  fm10k/base: remove unused struct element

 drivers/net/fm10k/base/fm10k_api.c   |   2 +
 drivers/net/fm10k/base/fm10k_api.h   |   2 +
 drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
 drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
 drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
 drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
 drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
 drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
 drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
 drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++----------------------------
 drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
 drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
 12 files changed, 222 insertions(+), 298 deletions(-)
Heng Ding Feb. 29, 2016, 2:30 a.m. UTC | #4 
Tested-by: Heng Ding <hengx.ding@intel.com>

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang Xiao W
Sent: Friday, February 19, 2016 7:07 PM
To: Chen, Jing D
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code

v3:
* Fixed checkpatch.pl warning about long commit message.
* Fixed the issue of compile failure about part of patches applied.
* Split the misc-small-fixes patch into several patches.

v2:
* Put the two extra fix patches ahead of the base code patches.

This patch set has passed regression test.

Wang Xiao W (18):
  fm10k: use default mailbox message handler for PF
  fm10k/base: correct typecast in fm10k_update_xc_addr_pf
  fm10k/base: cleanup namespace pollution
  fm10k/base: use bitshift for itr_scale
  fm10k/base: reset max_queues on init_hw_vf failure
  fm10k/base: document ITR scale workaround in VF TDLEN register
  fm10k/base: cleanup lines over 80 characters
  fm10k/base: cleanup useless else
  fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
  fm10k/base: do not use CamelCase
  fm10k/base: use memcpy for mac addr copy
  fm10k/base: allow removal of is_slot_appropriate function
  fm10k/base: consistently use VLAN ID when referencing vid variables
  fm10k/base: imporve comment per upstream review changes
  fm10k/base: fix TLV structures alignment
  fm10k/base: move constants to the right of binary operators
  fm10k/base: minor cleanups
  fm10k/base: remove unused struct element

 drivers/net/fm10k/base/fm10k_api.c   |   2 +
 drivers/net/fm10k/base/fm10k_api.h   |   2 +
 drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
 drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
 drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
 drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
 drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
 drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
 drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
 drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++----------------------------
 drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
 drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
 12 files changed, 222 insertions(+), 298 deletions(-)
Bruce Richardson March 8, 2016, 1:24 p.m. UTC | #5 
On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> v3:
> * Fixed checkpatch.pl warning about long commit message.
> * Fixed the issue of compile failure about part of patches applied.
> * Split the misc-small-fixes patch into several patches.
> 
> v2:
> * Put the two extra fix patches ahead of the base code patches.
> 
> This patch set has passed regression test.
> 
> Wang Xiao W (18):
>   fm10k: use default mailbox message handler for PF
>   fm10k/base: correct typecast in fm10k_update_xc_addr_pf
>   fm10k/base: cleanup namespace pollution
>   fm10k/base: use bitshift for itr_scale
>   fm10k/base: reset max_queues on init_hw_vf failure
>   fm10k/base: document ITR scale workaround in VF TDLEN register
>   fm10k/base: cleanup lines over 80 characters
>   fm10k/base: cleanup useless else
>   fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
>   fm10k/base: do not use CamelCase
>   fm10k/base: use memcpy for mac addr copy
>   fm10k/base: allow removal of is_slot_appropriate function
>   fm10k/base: consistently use VLAN ID when referencing vid variables
>   fm10k/base: imporve comment per upstream review changes
>   fm10k/base: fix TLV structures alignment
>   fm10k/base: move constants to the right of binary operators
>   fm10k/base: minor cleanups
>   fm10k/base: remove unused struct element
> 
>  drivers/net/fm10k/base/fm10k_api.c   |   2 +
>  drivers/net/fm10k/base/fm10k_api.h   |   2 +
>  drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
>  drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
>  drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
>  drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
>  drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
>  drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
>  drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
>  drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++----------------------------
>  drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
>  drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
>  12 files changed, 222 insertions(+), 298 deletions(-)
> 
> -- 
> 1.9.3
> 
Hi Mark,

Can we get fm10k maintainer review and/or ack on this patchset please.

Thanks,
/Bruce
Xiao Wang March 8, 2016, 2:15 p.m. UTC | #6 
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, March 8, 2016 9:24 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> <shaopeng.he@intel.com>
> Subject: Re: [PATCH v3 00/18] fm10k: update shared code
> 
> On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> > v3:
> > * Fixed checkpatch.pl warning about long commit message.
> > * Fixed the issue of compile failure about part of patches applied.
> > * Split the misc-small-fixes patch into several patches.
> >
> > v2:
> > * Put the two extra fix patches ahead of the base code patches.
> >
> > This patch set has passed regression test.
> >
> > Wang Xiao W (18):
> >   fm10k: use default mailbox message handler for PF
> >   fm10k/base: correct typecast in fm10k_update_xc_addr_pf
> >   fm10k/base: cleanup namespace pollution
> >   fm10k/base: use bitshift for itr_scale
> >   fm10k/base: reset max_queues on init_hw_vf failure
> >   fm10k/base: document ITR scale workaround in VF TDLEN register
> >   fm10k/base: cleanup lines over 80 characters
> >   fm10k/base: cleanup useless else
> >   fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
> >   fm10k/base: do not use CamelCase
> >   fm10k/base: use memcpy for mac addr copy
> >   fm10k/base: allow removal of is_slot_appropriate function
> >   fm10k/base: consistently use VLAN ID when referencing vid variables
> >   fm10k/base: imporve comment per upstream review changes
> >   fm10k/base: fix TLV structures alignment
> >   fm10k/base: move constants to the right of binary operators
> >   fm10k/base: minor cleanups
> >   fm10k/base: remove unused struct element
> >
> >  drivers/net/fm10k/base/fm10k_api.c   |   2 +
> >  drivers/net/fm10k/base/fm10k_api.h   |   2 +
> >  drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
> >  drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
> >  drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
> >  drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
> >  drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
> >  drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
> >  drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
> >  drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++----------------------------
> >  drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
> >  drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
> >  12 files changed, 222 insertions(+), 298 deletions(-)
> >
> > --
> > 1.9.3
> >
> Hi Mark,
> 
> Can we get fm10k maintainer review and/or ack on this patchset please.
> 
> Thanks,
> /Bruce

Hi Bruce,

Mark has reviewed and acked the patch set in v2, and I put the "Acked-by " in the v3 01/18 patch.
It's the same for my FTAG patch.

Best Regards,
Xiao
Chen, Jing D March 8, 2016, 2:25 p.m. UTC | #7 
Hi, Xiao

> -----Original Message-----
> From: Wang, Xiao W
> Sent: Tuesday, March 8, 2016 8:15 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> <shaopeng.he@intel.com>
> Subject: RE: [PATCH v3 00/18] fm10k: update shared code
> 
> 
> 
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Tuesday, March 8, 2016 9:24 PM
> > To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> > <jing.d.chen@intel.com>
> > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > <shaopeng.he@intel.com>
> > Subject: Re: [PATCH v3 00/18] fm10k: update shared code
> >
> > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> > > v3:
> > > * Fixed checkpatch.pl warning about long commit message.
> > > * Fixed the issue of compile failure about part of patches applied.
> > > * Split the misc-small-fixes patch into several patches.
> > >
> > > v2:
> > > * Put the two extra fix patches ahead of the base code patches.
> > >
> > > This patch set has passed regression test.
> > >
> > > Wang Xiao W (18):
> > >   fm10k: use default mailbox message handler for PF
> > >   fm10k/base: correct typecast in fm10k_update_xc_addr_pf
> > >   fm10k/base: cleanup namespace pollution
> > >   fm10k/base: use bitshift for itr_scale
> > >   fm10k/base: reset max_queues on init_hw_vf failure
> > >   fm10k/base: document ITR scale workaround in VF TDLEN register
> > >   fm10k/base: cleanup lines over 80 characters
> > >   fm10k/base: cleanup useless else
> > >   fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
> > >   fm10k/base: do not use CamelCase
> > >   fm10k/base: use memcpy for mac addr copy
> > >   fm10k/base: allow removal of is_slot_appropriate function
> > >   fm10k/base: consistently use VLAN ID when referencing vid variables
> > >   fm10k/base: imporve comment per upstream review changes
> > >   fm10k/base: fix TLV structures alignment
> > >   fm10k/base: move constants to the right of binary operators
> > >   fm10k/base: minor cleanups
> > >   fm10k/base: remove unused struct element
> > >
> > >  drivers/net/fm10k/base/fm10k_api.c   |   2 +
> > >  drivers/net/fm10k/base/fm10k_api.h   |   2 +
> > >  drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
> > >  drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
> > >  drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
> > >  drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
> > >  drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
> > >  drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
> > >  drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
> > >  drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++---------------------
> -------
> > >  drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
> > >  drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
> > >  12 files changed, 222 insertions(+), 298 deletions(-)
> > >
> > > --
> > > 1.9.3
> > >
> > Hi Mark,
> >
> > Can we get fm10k maintainer review and/or ack on this patchset please.
> >
> > Thanks,
> > /Bruce
> 
> Hi Bruce,
> 
> Mark has reviewed and acked the patch set in v2, and I put the "Acked-by "
> in the v3 01/18 patch.
> It's the same for my FTAG patch.
> 

It's better to add acked-by in both patch set and cover letter, this may be more
helpful for maintainers. 

> Best Regards,
> Xiao
Xiao Wang March 8, 2016, 2:32 p.m. UTC | #8 
Hi Mark,

> -----Original Message-----
> From: Chen, Jing D
> Sent: Tuesday, March 8, 2016 10:25 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; He, Shaopeng <shaopeng.he@intel.com>
> Subject: RE: [PATCH v3 00/18] fm10k: update shared code
> 
> Hi, Xiao
> 
> > -----Original Message-----
> > From: Wang, Xiao W
> > Sent: Tuesday, March 8, 2016 8:15 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; Chen, Jing D
> > <jing.d.chen@intel.com>
> > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > <shaopeng.he@intel.com>
> > Subject: RE: [PATCH v3 00/18] fm10k: update shared code
> >
> >
> >
> > > -----Original Message-----
> > > From: Richardson, Bruce
> > > Sent: Tuesday, March 8, 2016 9:24 PM
> > > To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> > > <jing.d.chen@intel.com>
> > > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > > <shaopeng.he@intel.com>
> > > Subject: Re: [PATCH v3 00/18] fm10k: update shared code
> > >
> > > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> > > > v3:
> > > > * Fixed checkpatch.pl warning about long commit message.
> > > > * Fixed the issue of compile failure about part of patches applied.
> > > > * Split the misc-small-fixes patch into several patches.
> > > >
> > > > v2:
> > > > * Put the two extra fix patches ahead of the base code patches.
> > > >
> > > > This patch set has passed regression test.
> > > >
> > > > Wang Xiao W (18):
> > > >   fm10k: use default mailbox message handler for PF
> > > >   fm10k/base: correct typecast in fm10k_update_xc_addr_pf
> > > >   fm10k/base: cleanup namespace pollution
> > > >   fm10k/base: use bitshift for itr_scale
> > > >   fm10k/base: reset max_queues on init_hw_vf failure
> > > >   fm10k/base: document ITR scale workaround in VF TDLEN register
> > > >   fm10k/base: cleanup lines over 80 characters
> > > >   fm10k/base: cleanup useless else
> > > >   fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
> > > >   fm10k/base: do not use CamelCase
> > > >   fm10k/base: use memcpy for mac addr copy
> > > >   fm10k/base: allow removal of is_slot_appropriate function
> > > >   fm10k/base: consistently use VLAN ID when referencing vid variables
> > > >   fm10k/base: imporve comment per upstream review changes
> > > >   fm10k/base: fix TLV structures alignment
> > > >   fm10k/base: move constants to the right of binary operators
> > > >   fm10k/base: minor cleanups
> > > >   fm10k/base: remove unused struct element
> > > >
> > > >  drivers/net/fm10k/base/fm10k_api.c   |   2 +
> > > >  drivers/net/fm10k/base/fm10k_api.h   |   2 +
> > > >  drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
> > > >  drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
> > > >  drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
> > > >  drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
> > > >  drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
> > > >  drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
> > > >  drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
> > > >  drivers/net/fm10k/base/fm10k_type.h  | 182
> > > > +++++++---------------------
> > -------
> > > >  drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
> > > >  drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
> > > >  12 files changed, 222 insertions(+), 298 deletions(-)
> > > >
> > > > --
> > > > 1.9.3
> > > >
> > > Hi Mark,
> > >
> > > Can we get fm10k maintainer review and/or ack on this patchset please.
> > >
> > > Thanks,
> > > /Bruce
> >
> > Hi Bruce,
> >
> > Mark has reviewed and acked the patch set in v2, and I put the "Acked-by "
> > in the v3 01/18 patch.
> > It's the same for my FTAG patch.
> >
> 
> It's better to add acked-by in both patch set and cover letter, this may be more
> helpful for maintainers.
> 
> > Best Regards,
> > Xiao

OK, I've realized this.

Thanks,
Xiao
Bruce Richardson March 8, 2016, 2:53 p.m. UTC | #9 
On Tue, Mar 08, 2016 at 02:25:27PM +0000, Chen, Jing D wrote:
> Hi, Xiao
> 
> > -----Original Message-----
> > From: Wang, Xiao W
> > Sent: Tuesday, March 8, 2016 8:15 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; Chen, Jing D
> > <jing.d.chen@intel.com>
> > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > <shaopeng.he@intel.com>
> > Subject: RE: [PATCH v3 00/18] fm10k: update shared code
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: Richardson, Bruce
> > > Sent: Tuesday, March 8, 2016 9:24 PM
> > > To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> > > <jing.d.chen@intel.com>
> > > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > > <shaopeng.he@intel.com>
> > > Subject: Re: [PATCH v3 00/18] fm10k: update shared code
> > >
> > > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> > > > v3:
> > > > * Fixed checkpatch.pl warning about long commit message.
> > > > * Fixed the issue of compile failure about part of patches applied.
> > > > * Split the misc-small-fixes patch into several patches.
> > > >
> > > > v2:
> > > > * Put the two extra fix patches ahead of the base code patches.
> > > >
> > > > This patch set has passed regression test.
> > > >
> > > > Wang Xiao W (18):
> > > >   fm10k: use default mailbox message handler for PF
> > > >   fm10k/base: correct typecast in fm10k_update_xc_addr_pf
> > > >   fm10k/base: cleanup namespace pollution
> > > >   fm10k/base: use bitshift for itr_scale
> > > >   fm10k/base: reset max_queues on init_hw_vf failure
> > > >   fm10k/base: document ITR scale workaround in VF TDLEN register
> > > >   fm10k/base: cleanup lines over 80 characters
> > > >   fm10k/base: cleanup useless else
> > > >   fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
> > > >   fm10k/base: do not use CamelCase
> > > >   fm10k/base: use memcpy for mac addr copy
> > > >   fm10k/base: allow removal of is_slot_appropriate function
> > > >   fm10k/base: consistently use VLAN ID when referencing vid variables
> > > >   fm10k/base: imporve comment per upstream review changes
> > > >   fm10k/base: fix TLV structures alignment
> > > >   fm10k/base: move constants to the right of binary operators
> > > >   fm10k/base: minor cleanups
> > > >   fm10k/base: remove unused struct element
> > > >
> > > >  drivers/net/fm10k/base/fm10k_api.c   |   2 +
> > > >  drivers/net/fm10k/base/fm10k_api.h   |   2 +
> > > >  drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
> > > >  drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
> > > >  drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
> > > >  drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
> > > >  drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
> > > >  drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
> > > >  drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
> > > >  drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++---------------------
> > -------
> > > >  drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
> > > >  drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
> > > >  12 files changed, 222 insertions(+), 298 deletions(-)
> > > >
> > > > --
> > > > 1.9.3
> > > >
> > > Hi Mark,
> > >
> > > Can we get fm10k maintainer review and/or ack on this patchset please.
> > >
> > > Thanks,
> > > /Bruce
> > 
> > Hi Bruce,
> > 
> > Mark has reviewed and acked the patch set in v2, and I put the "Acked-by "
> > in the v3 01/18 patch.
> > It's the same for my FTAG patch.
> > 
> 
> It's better to add acked-by in both patch set and cover letter, this may be more
> helpful for maintainers. 
> 
An earlier ack should be reflected by putting the ack on all patches of the set
in later revisions. If it's only on patch 1, that implies that only that one patch
has been acked. If the ack is included in the cover letter only, then it's likely
to be missed, as a series ack is expected as a reply to the cover letter (because
as stated above, subsequent revs should include the ack in each patch itself)

/Bruce
Bruce Richardson March 8, 2016, 4:27 p.m. UTC | #10 
On Mon, Feb 29, 2016 at 02:30:45AM +0000, Ding, HengX wrote:
> Tested-by: Heng Ding <hengx.ding@intel.com>
> 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang Xiao W
> Sent: Friday, February 19, 2016 7:07 PM
> To: Chen, Jing D
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code
> 
> v3:
> * Fixed checkpatch.pl warning about long commit message.
> * Fixed the issue of compile failure about part of patches applied.
> * Split the misc-small-fixes patch into several patches.
> 
> v2:
> * Put the two extra fix patches ahead of the base code patches.
> 
Applied to dpdk-next-net/rel_16_04

/Bruce
diff mbox

Patch

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index e4aed94..2c38ce9 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -2367,29 +2367,16 @@  static const struct fm10k_msg_data fm10k_msgdata_vf[] = {
 	FM10K_TLV_MSG_ERROR_HANDLER(fm10k_tlv_msg_error),
 };
 
-/* Mailbox message handler in PF */
-static const struct fm10k_msg_data fm10k_msgdata_pf[] = {
-	FM10K_PF_MSG_ERR_HANDLER(XCAST_MODES, fm10k_msg_err_pf),
-	FM10K_PF_MSG_ERR_HANDLER(UPDATE_MAC_FWD_RULE, fm10k_msg_err_pf),
-	FM10K_PF_MSG_LPORT_MAP_HANDLER(fm10k_msg_lport_map_pf),
-	FM10K_PF_MSG_ERR_HANDLER(LPORT_CREATE, fm10k_msg_err_pf),
-	FM10K_PF_MSG_ERR_HANDLER(LPORT_DELETE, fm10k_msg_err_pf),
-	FM10K_PF_MSG_UPDATE_PVID_HANDLER(fm10k_msg_update_pvid_pf),
-	FM10K_TLV_MSG_ERROR_HANDLER(fm10k_tlv_msg_error),
-};
-
 static int
 fm10k_setup_mbx_service(struct fm10k_hw *hw)
 {
-	int err;
+	int err = 0;
 
 	/* Initialize mailbox lock */
 	fm10k_mbx_initlock(hw);
 
 	/* Replace default message handler with new ones */
-	if (hw->mac.type == fm10k_mac_pf)
-		err = hw->mbx.ops.register_handlers(&hw->mbx, fm10k_msgdata_pf);
-	else
+	if (hw->mac.type == fm10k_mac_vf)
 		err = hw->mbx.ops.register_handlers(&hw->mbx, fm10k_msgdata_vf);
 
 	if (err) {