diff mbox

[dpdk-dev] fm10k: fix vlan flag bug in scattered RX

Message ID 1450408158-29206-1-git-send-email-xiao.w.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Xiao Wang Dec. 18, 2015, 3:09 a.m. UTC 
  In fm10k_recv_scattered_pkts function, a packet is stored in a linked list,
offload flags such as PKT_RX_VLAN_PKT should be set in the first segment.

Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
---
 drivers/net/fm10k/fm10k_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

He, Shaopeng Dec. 18, 2015, 5:35 a.m. UTC | #1 
> -----Original Message-----
> From: Wang, Xiao W
> Sent: Friday, December 18, 2015 11:09 AM
> To: Chen, Jing D
> Cc: He, Shaopeng; dev@dpdk.org; Wang, Xiao W
> Subject: [PATCH] fm10k: fix vlan flag bug in scattered RX
> 
> In fm10k_recv_scattered_pkts function, a packet is stored in a linked list,
> offload flags such as PKT_RX_VLAN_PKT should be set in the first segment.
> 
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>

Thanks for the catch.

Acked-by: Shaopeng He <shaopeng.he@intel.com>
Bruce Richardson Feb. 2, 2016, 5:41 p.m. UTC | #2 
On Fri, Dec 18, 2015 at 05:35:35AM +0000, He, Shaopeng wrote:
> 
> > -----Original Message-----
> > From: Wang, Xiao W
> > Sent: Friday, December 18, 2015 11:09 AM
> > To: Chen, Jing D
> > Cc: He, Shaopeng; dev@dpdk.org; Wang, Xiao W
> > Subject: [PATCH] fm10k: fix vlan flag bug in scattered RX
> > 
> > In fm10k_recv_scattered_pkts function, a packet is stored in a linked list,
> > offload flags such as PKT_RX_VLAN_PKT should be set in the first segment.
> > 
> > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> 
> Thanks for the catch.
> 
> Acked-by: Shaopeng He <shaopeng.he@intel.com>

First commit applied to dpdk-next-net tree.

Applied to dpdk-next-net/rel_16_04 with added fixes line:
	Fixes: 6b59a3bc82b1 ("fm10k: fix VLAN in Rx mbuf")

I hope to apply more patches that are ready in the coming days.

Regards,
/Bruce
diff mbox

Patch

diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c
index e958865..de31cad 100644
--- a/drivers/net/fm10k/fm10k_rxtx.c
+++ b/drivers/net/fm10k/fm10k_rxtx.c
@@ -305,7 +305,7 @@  fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 		 * So, always PKT_RX_VLAN_PKT flag is set and vlan_tci
 		 * is valid for each RX packet's mbuf.
 		 */
-		mbuf->ol_flags |= PKT_RX_VLAN_PKT;
+		first_seg->ol_flags |= PKT_RX_VLAN_PKT;
 		first_seg->vlan_tci = desc.w.vlan;
 
 		/* Prefetch data of first segment, if configured to do so. */