diff mbox

[dpdk-dev,v1,2/2] examples/l2fwd-keepalive: Fix integer overflow

Message ID 1449741007-1022-3-git-send-email-remy.horton@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Remy Horton Dec. 10, 2015, 9:50 a.m. UTC 
  Fix Coverity warning with potential 32-bit integer multiplication overflow
where final result is expected to be 64-bit.

>>> CID 120144 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 examples/l2fwd-keepalive/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John McNamara Dec. 10, 2015, 10:20 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Thursday, December 10, 2015 9:50 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: Fix integer
> overflow
> 
> Fix Coverity warning with potential 32-bit integer multiplication overflow
> where final result is expected to be 64-bit.
> 
> >>> CID 120144 (#1 of 1): Unintentional integer overflow
> >>> (OVERFLOW_BEFORE_WIDEN)
> 
> Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
diff mbox

Patch

diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c
index 8d7b09e..f4d52f2 100644
--- a/examples/l2fwd-keepalive/main.c
+++ b/examples/l2fwd-keepalive/main.c
@@ -471,7 +471,7 @@  l2fwd_parse_args(int argc, char **argv)
 		/* timer period */
 		case 'T':
 			timer_period = l2fwd_parse_timer_period(optarg)
-				* 1000 * TIMER_MILLISECOND;
+				* (int64_t)(1000 * TIMER_MILLISECOND);
 			if (timer_period < 0) {
 				printf("invalid timer period\n");
 				l2fwd_usage(prgname);