diff mbox

[dpdk-dev] bnx2x: check sc->state to prevent double init

Message ID 1449586104-9977-1-git-send-email-3chas3@gmail.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Chas Williams Dec. 8, 2015, 2:48 p.m. UTC 
  If the link is up, then the driver cannot be stopped and started
successfully.  Instead of checking the link status, use the driver's
state.

Signed-off-by: Chas Williams <3chas3@gmail.com>
---
 drivers/net/bnx2x/bnx2x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Dec. 9, 2015, 8:24 p.m. UTC | #1 
2015-12-08 09:48, Chas Williams:
> If the link is up, then the driver cannot be stopped and started
> successfully.  Instead of checking the link status, use the driver's
> state.
> 
> Signed-off-by: Chas Williams <3chas3@gmail.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 294711f..2dc2a47 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -7430,7 +7430,7 @@  int bnx2x_init(struct bnx2x_softc *sc)
 	int rc;
 
 	/* Check if the driver is still running and bail out if it is. */
-	if (sc->link_vars.link_up) {
+	if (sc->state != BNX2X_STATE_CLOSED) {
 		PMD_DRV_LOG(DEBUG, "Init called while driver is running!");
 		rc = 0;
 		goto bnx2x_init_done;