diff mbox

[dpdk-dev] test: fix crash in pmd_perf_test

Message ID 1448279148-14283-1-git-send-email-david.hunt@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Hunt, David Nov. 23, 2015, 11:45 a.m. UTC 
  Fix crash in pmd_perf_test autotest (div by 0) when no packets received
Also fixes the fact that the test passes even if exec_burst fails

To repeat the issue:
  The system must be incorrectly set up so that all packets will be lost, 
  i.e. no loopback cable, etc. This is an edge case, but still the test
  should not crash or pass when failing.
  run the test app
  RTE>> set_rxtx_sc poll_before_xmit
  RTE>> pmd_perf_autotest 
  --snip--
  > Generate 4096 packets @socket 1
  > start to receive total expect 4096
  > 4096 packets lost, IDLE 10000 times
  > Floating point exception (core dumped)

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 app/test/test_pmd_perf.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comments

Thomas Monjalon Dec. 7, 2015, 2:41 a.m. UTC | #1 
2015-11-23 11:45, David Hunt:
> Fix crash in pmd_perf_test autotest (div by 0) when no packets received
> Also fixes the fact that the test passes even if exec_burst fails
> 
> To repeat the issue:
>   The system must be incorrectly set up so that all packets will be lost, 
>   i.e. no loopback cable, etc. This is an edge case, but still the test
>   should not crash or pass when failing.
>   run the test app
>   RTE>> set_rxtx_sc poll_before_xmit
>   RTE>> pmd_perf_autotest 
>   --snip--
>   > Generate 4096 packets @socket 1
>   > start to receive total expect 4096
>   > 4096 packets lost, IDLE 10000 times
>   > Floating point exception (core dumped)
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
index 8f55640..25b4d09 100644
--- a/app/test/test_pmd_perf.c
+++ b/app/test/test_pmd_perf.c
@@ -626,7 +626,10 @@  timeout:
 
 	rte_free(pkts_burst);
 
-	return diff_tsc / total;
+	if (total > 0)
+		return diff_tsc / total;
+	else
+		return -1;
 }
 
 static int
@@ -673,8 +676,10 @@  exec_burst(uint32_t flags, int lcore)
 
 	/* wait for polling finished */
 	diff_tsc = rte_eal_wait_lcore(lcore);
-	if (diff_tsc < 0)
+	if (diff_tsc < 0) {
+		printf("exec_burst: Failed to measure cycles per packet\n");
 		return -1;
+	}
 
 	printf("Result: %d cycles per packet\n", diff_tsc);
 
@@ -811,7 +816,8 @@  test_pmd_perf(void)
 			return -1;
 	} else if (sc_flag == SC_BURST_POLL_FIRST ||
 		   sc_flag == SC_BURST_XMIT_FIRST)
-		exec_burst(sc_flag, slave_id);
+		if (exec_burst(sc_flag, slave_id) < 0)
+			return -1;
 
 	/* port tear down */
 	for (portid = 0; portid < nb_ports; portid++) {