diff mbox

[dpdk-dev] app/testpmd: fix icmp echo tx queues

Message ID 1446108423-14231-1-git-send-email-david.marchand@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

David Marchand Oct. 29, 2015, 8:47 a.m. UTC 
  icmp echo forward engine relies on the core rank rather than the number of
queues available.
This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
an invalid txq, but with this, we are aligned on other fwd engines.

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Nov. 10, 2015, 3:27 p.m. UTC | #1 
2015-10-29 09:47, David Marchand:
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> -			fs->tx_queue = lc_id;
> +			fs->tx_queue = rxq;

Pablo, any opinion?
De Lara Guarch, Pablo Nov. 10, 2015, 4:10 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: David Marchand [mailto:david.marchand@6wind.com]
> Sent: Thursday, October 29, 2015 8:47 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: fix icmp echo tx queues
> 
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index cf2aa6e..314215c 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1278,7 +1278,7 @@ icmp_echo_config_setup(void)
>  			fs->rx_port = fwd_ports_ids[rxp];
>  			fs->rx_queue = rxq;
>  			fs->tx_port = fs->rx_port;
> -			fs->tx_queue = lc_id;
> +			fs->tx_queue = rxq;
>  			fs->peer_addr = fs->tx_port;
>  			if (verbose_level > 0)
>  				printf("  stream=%d port=%d rxq=%d
> txq=%d\n",
> --
> 1.9.1

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Thomas Monjalon Nov. 10, 2015, 4:23 p.m. UTC | #3 
> > icmp echo forward engine relies on the core rank rather than the number of
> > queues available.
> > This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> > an invalid txq, but with this, we are aligned on other fwd engines.
> > 
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index cf2aa6e..314215c 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1278,7 +1278,7 @@  icmp_echo_config_setup(void)
 			fs->rx_port = fwd_ports_ids[rxp];
 			fs->rx_queue = rxq;
 			fs->tx_port = fs->rx_port;
-			fs->tx_queue = lc_id;
+			fs->tx_queue = rxq;
 			fs->peer_addr = fs->tx_port;
 			if (verbose_level > 0)
 				printf("  stream=%d port=%d rxq=%d txq=%d\n",