diff mbox

[dpdk-dev,2/2] eal: remove useless header inclusion

Message ID 1437635732-29113-3-git-send-email-david.marchand@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

David Marchand July 23, 2015, 7:15 a.m. UTC 
  Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 app/test-pmd/cmdline.c                    | 1 -
 lib/librte_eal/bsdapp/eal/eal_pci.c       | 1 -
 lib/librte_eal/linuxapp/eal/eal_pci.c     | 1 -
 lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 1 -
 4 files changed, 4 deletions(-)

Comments

Thomas Monjalon July 26, 2015, 10:18 p.m. UTC | #1 
2015-07-23 09:15, David Marchand:
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -84,7 +84,6 @@
>  #include <cmdline_parse_etheraddr.h>
>  #include <cmdline_socket.h>
>  #include <cmdline.h>
> -#include <rte_pci_dev_ids.h>

This one is "needed" to check bypass support.
The bypass support should be managed inside the ixgbe driver, and the
specific code in testpmd must be removed.
Waiting this cleanup, the inclusion will be moved in the #ifdef BYPASS.

Note: this ugly bypass code was already signaled few times.
If it's not reworked soon (without ifdef), it could be dropped.
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 8ab4687..f516b84 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -84,7 +84,6 @@ 
 #include <cmdline_parse_etheraddr.h>
 #include <cmdline_socket.h>
 #include <cmdline.h>
-#include <rte_pci_dev_ids.h>
 #ifdef RTE_LIBRTE_PMD_BOND
 #include <rte_eth_bond.h>
 #endif
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index ed31222..524c153 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -67,7 +67,6 @@ 
 #include <rte_debug.h>
 #include <rte_devargs.h>
 
-#include "rte_pci_dev_ids.h"
 #include "eal_filesystem.h"
 #include "eal_private.h"
 
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 9a28ede..5ac1571 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -41,7 +41,6 @@ 
 #include <rte_devargs.h>
 #include <rte_memcpy.h>
 
-#include "rte_pci_dev_ids.h"
 #include "eal_filesystem.h"
 #include "eal_private.h"
 #include "eal_pci_init.h"
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
index c35feb4..8bbcef0 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
@@ -45,7 +45,6 @@ 
 #include <rte_common.h>
 #include <rte_malloc.h>
 
-#include "rte_pci_dev_ids.h"
 #include "eal_filesystem.h"
 #include "eal_pci_init.h"