[dpdk-dev] doc: announce ABI change for librte_sched

Message ID 1437081699-2246-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger July 16, 2015, 9:21 p.m. UTC
  Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 doc/guides/rel_notes/abi.rst | 9 +++++++++
 1 file changed, 9 insertions(+)
  

Comments

Cristian Dumitrescu July 16, 2015, 9:25 p.m. UTC | #1
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, July 16, 2015 10:22 PM
> To: Dumitrescu, Cristian
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH] doc: announce ABI change for librte_sched
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  doc/guides/rel_notes/abi.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
> index 9e98d62..a4d100b 100644
> --- a/doc/guides/rel_notes/abi.rst
> +++ b/doc/guides/rel_notes/abi.rst
> @@ -34,3 +34,12 @@ Deprecation Notices
>    creates a dummy/empty malloc library to fulfill binaries with dynamic linking
>    dependencies on librte_malloc.so. Such dummy library will not be created
> from
>    release 2.2 so binaries will need to be rebuilt.
> +
> +* librte_sched (rte_sched.h): The scheduler hierarchy structure
> +  (rte_sched_port_hierarchy) will change to allow for a larger number of
> subport
> +  entries. The number of available traffic_classes and queues may also
> change.
> +  The mbuf structure element for sched hierarchy will also change from a
> single
> +  32 bit to a 64 bit structure.
> +
> +* librte_sched (rte_sched.h): The scheduler statistics structure will change
> +  to allow keeping track of RED actions.
> --
> 2.1.4

Hi Stephen,

Agree with both, how about the new clear flag to the stats read function, shall we add a separate note on this as well?

Thanks,
Cristian
  
Neil Horman July 16, 2015, 9:28 p.m. UTC | #2
On Thu, Jul 16, 2015 at 02:21:39PM -0700, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  doc/guides/rel_notes/abi.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
> index 9e98d62..a4d100b 100644
> --- a/doc/guides/rel_notes/abi.rst
> +++ b/doc/guides/rel_notes/abi.rst
> @@ -34,3 +34,12 @@ Deprecation Notices
>    creates a dummy/empty malloc library to fulfill binaries with dynamic linking
>    dependencies on librte_malloc.so. Such dummy library will not be created from
>    release 2.2 so binaries will need to be rebuilt.
> +
> +* librte_sched (rte_sched.h): The scheduler hierarchy structure
> +  (rte_sched_port_hierarchy) will change to allow for a larger number of subport
> +  entries. The number of available traffic_classes and queues may also change.
> +  The mbuf structure element for sched hierarchy will also change from a single
> +  32 bit to a 64 bit structure.
> +
> +* librte_sched (rte_sched.h): The scheduler statistics structure will change
> +  to allow keeping track of RED actions.
> -- 
> 2.1.4
> 
> 
ACK
  
Cristian Dumitrescu July 23, 2015, 10:18 a.m. UTC | #3
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
  
Thomas Monjalon Aug. 15, 2015, 8:58 a.m. UTC | #4
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

> > +* librte_sched (rte_sched.h): The scheduler hierarchy structure
> > +  (rte_sched_port_hierarchy) will change to allow for a larger number of subport
> > +  entries. The number of available traffic_classes and queues may also change.
> > +  The mbuf structure element for sched hierarchy will also change from a single
> > +  32 bit to a 64 bit structure.
> > +
> > +* librte_sched (rte_sched.h): The scheduler statistics structure will change
> > +  to allow keeping track of RED actions.
> ACK

Applied, thanks
  

Patch

diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 9e98d62..a4d100b 100644
--- a/doc/guides/rel_notes/abi.rst
+++ b/doc/guides/rel_notes/abi.rst
@@ -34,3 +34,12 @@  Deprecation Notices
   creates a dummy/empty malloc library to fulfill binaries with dynamic linking
   dependencies on librte_malloc.so. Such dummy library will not be created from
   release 2.2 so binaries will need to be rebuilt.
+
+* librte_sched (rte_sched.h): The scheduler hierarchy structure
+  (rte_sched_port_hierarchy) will change to allow for a larger number of subport
+  entries. The number of available traffic_classes and queues may also change.
+  The mbuf structure element for sched hierarchy will also change from a single
+  32 bit to a 64 bit structure.
+
+* librte_sched (rte_sched.h): The scheduler statistics structure will change
+  to allow keeping track of RED actions.