From patchwork Mon Jul 13 09:02:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 6342 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id EAE345A44; Mon, 13 Jul 2015 11:03:57 +0200 (CEST) Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id D229C5934 for ; Mon, 13 Jul 2015 11:03:55 +0200 (CEST) Received: by wgjx7 with SMTP id x7so290448502wgj.2 for ; Mon, 13 Jul 2015 02:03:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s5Z8FJCdSjnnxShLwywHDFU9/JVMqCCF+9dB2Iiu/X8=; b=aoiQ7hisUQEcTrGismYhxJTX+KNNgudsF7pyU0Cnewe9UI5jFV81Dkb0B/DXIl6YtZ nGOQ2YbO63WdNVdNxswY9+9oL6m4Pd5JBX2ZIsPXFiRUeoCv/T+sLltOVb6JGYmrKrVK Btv6YAFwYXNeLBAwSAFHJ2epPbFukziaIWYoHEyR5kTw9abkLrpaVjtnk8Tg1ALRYGlh V4Kjl8dGjGkB1zExZQ5AbxsxYNTTMaH9P7cPemJVfDX8HLwHCWln70D1DTKUbrZ/m0nE G28wpKNv5JQWpsE9154S8CKZkys08vHgwMH83h+2yc7YSTCg5zGrab4f90BkmZUO9HPO 9YXA== X-Gm-Message-State: ALoCoQl3Ny5feG6SvJw91qkwQMLtZRMzqWX3kFhF3Pa51bSEtJH+ir+otA4F74JgeRPfCWdBfrwJ X-Received: by 10.180.88.196 with SMTP id bi4mr21365671wib.70.1436778235669; Mon, 13 Jul 2015 02:03:55 -0700 (PDT) Received: from localhost.localdomain (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id da5sm13406045wib.6.2015.07.13.02.03.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Jul 2015 02:03:54 -0700 (PDT) From: Thomas Monjalon To: John McNamara Date: Mon, 13 Jul 2015 11:02:29 +0200 Message-Id: <1436778149-18811-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.4.2 In-Reply-To: <1531097.HZDUsMDq83@xps13> References: <1531097.HZDUsMDq83@xps13> Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] mk: fix shared lib build with stable abi X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When next ABI is enabled, the shared lib extension is .so.x.1. That's why a double basename was introduced. But the "ifeq NEXT_ABI" was forgotten, removing the .so extension when NEXT_ABI is disabled. It was preventing the linker from finding the .so libraries. Fixes: 506f51cc0da7 ("mk: enable next abi preview") Reported-by: John McNamara Signed-off-by: Thomas Monjalon Acked-by: John McNamara --- mk/rte.lib.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index f15de9b..9ff5cce 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -173,7 +173,11 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB) @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) +ifeq ($(CONFIG_RTE_NEXT_ABI),y) $(Q)ln -s -f $< $(basename $(basename $@)) +else + $(Q)ln -s -f $< $(basename $@) +endif endif #