[dpdk-dev] tools: remove chmod absolute path in setup.sh

Message ID 1426180680-5350-1-git-send-email-andre.o.richter@gmail.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Andre Richter March 12, 2015, 5:18 p.m. UTC
  setup.sh uses /usr/bin/chmod, but depending on distribution, it is not always there.
For example, Ubuntu has /bin/chmod. Fix this by removing the absolute path, like it is
done e.g. with grep.
---
 tools/setup.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Thomas Monjalon March 17, 2015, 9:25 p.m. UTC | #1
2015-03-12 18:18, Andre Richter:
> setup.sh uses /usr/bin/chmod, but depending on distribution, it is not always there.
> For example, Ubuntu has /bin/chmod. Fix this by removing the absolute path, like it is
> done e.g. with grep.

Applied, thanks
  

Patch

diff --git a/tools/setup.sh b/tools/setup.sh
index 245900f..ac438c2 100755
--- a/tools/setup.sh
+++ b/tools/setup.sh
@@ -220,7 +220,7 @@  load_vfio_module()
 
 	# make sure regular users can read /dev/vfio
 	echo "chmod /dev/vfio"
-	sudo /usr/bin/chmod a+x /dev/vfio
+	sudo chmod a+x /dev/vfio
 	if [ $? -ne 0 ] ; then
 		echo "FAIL"
 		quit
@@ -278,7 +278,7 @@  set_vfio_permissions()
 {
 	# make sure regular users can read /dev/vfio
 	echo "chmod /dev/vfio"
-	sudo /usr/bin/chmod a+x /dev/vfio
+	sudo chmod a+x /dev/vfio
 	if [ $? -ne 0 ] ; then
 		echo "FAIL"
 		quit
@@ -287,7 +287,7 @@  set_vfio_permissions()
 
 	# make sure regular user can access everything inside /dev/vfio
 	echo "chmod /dev/vfio/*"
-	sudo /usr/bin/chmod 0666 /dev/vfio/*
+	sudo chmod 0666 /dev/vfio/*
 	if [ $? -ne 0 ] ; then
 		echo "FAIL"
 		quit