From patchwork Wed Mar 11 07:23:10 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Marvin Liu <yong.liu@intel.com>
X-Patchwork-Id: 3968
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id 4460A9A94;
	Wed, 11 Mar 2015 08:23:20 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
	by dpdk.org (Postfix) with ESMTP id C08BE9A91
	for <dev@dpdk.org>; Wed, 11 Mar 2015 08:23:18 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
	by orsmga103.jf.intel.com with ESMTP; 11 Mar 2015 00:20:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,380,1422950400"; d="scan'208";a="696986777"
Received: from shvmail01.sh.intel.com ([10.239.29.42])
	by orsmga002.jf.intel.com with ESMTP; 11 Mar 2015 00:23:17 -0700
Received: from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com
	[10.239.29.90])
	by shvmail01.sh.intel.com with ESMTP id t2B7NF38026329;
	Wed, 11 Mar 2015 15:23:15 +0800
Received: from shecgisg003.sh.intel.com (localhost [127.0.0.1])
	by shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP
	id t2B7NCrH015216; Wed, 11 Mar 2015 15:23:14 +0800
Received: (from yliu84x@localhost)
	by shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t2B7NCg8015212;
	Wed, 11 Mar 2015 15:23:12 +0800
From: Yong Liu <yong.liu@intel.com>
To: dev@dpdk.org
Date: Wed, 11 Mar 2015 15:23:10 +0800
Message-Id: <1426058590-15180-1-git-send-email-yong.liu@intel.com>
X-Mailer: git-send-email 1.7.4.1
Subject: [dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

testpmd parameter "nb-port" mean the number of forwarding port.
It's incorrect to use function port_id_is_invalid to check number of ports.

Signed-off-by: Marvin Liu <yong.liu@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 11d9af0..f1daa6e 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
 #endif
 			if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
 				n = atoi(optarg);
-				if (n > 0 &&
-				    !port_id_is_invalid(n, DISABLED_WARN))
+				if (n > 0 && n <= nb_ports)
 					nb_fwd_ports = (uint8_t) n;
 				else
 					rte_exit(EXIT_FAILURE,