diff mbox

[dpdk-dev] virtio: Fix compilation issue on freebsd

Message ID 1425004210-4044-1-git-send-email-changchun.ouyang@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Ouyang Changchun Feb. 27, 2015, 2:30 a.m. UTC 
  This patch fixes the compilation issue on freebsd:

/root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function 'virtio_resource_init':
/root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error: unused parameter 'pci_dev' [-Werror=unused-parameter]  static int virtio_resource_init(struct rte_pci_device *pci_dev)
                                                        ^
cc1: all warnings being treated as errors

Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
 lib/librte_pmd_virtio/virtio_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cunming Liang Feb. 27, 2015, 5:11 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Ouyang, Changchun
> Sent: Friday, February 27, 2015 10:30 AM
> To: dev@dpdk.org
> Cc: Liang, Cunming; Cao, Waterman; Ouyang, Changchun
> Subject: [PATCH] virtio: Fix compilation issue on freebsd
> 
> This patch fixes the compilation issue on freebsd:
> 
> /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function
> 'virtio_resource_init':
> /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error:
> unused parameter 'pci_dev' [-Werror=unused-parameter]  static int
> virtio_resource_init(struct rte_pci_device *pci_dev)
>                                                         ^
> cc1: all warnings being treated as errors
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
>  lib/librte_pmd_virtio/virtio_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
> b/lib/librte_pmd_virtio/virtio_ethdev.c
> index 9eb0217..88ecd57 100644
> --- a/lib/librte_pmd_virtio/virtio_ethdev.c
> +++ b/lib/librte_pmd_virtio/virtio_ethdev.c
> @@ -1068,7 +1068,7 @@ virtio_has_msix(const struct rte_pci_addr *loc
> __rte_unused)
>  	return 0;
>  }
> 
> -static int virtio_resource_init(struct rte_pci_device *pci_dev)
> +static int virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
>  {
>  	/* no setup required */
>  	return 0;
> --
> 1.8.4.2

Acked-by:  Cunming Liang <cunming.liang@intel.com>
Thomas Monjalon Feb. 27, 2015, 11:13 p.m. UTC | #2 
> > This patch fixes the compilation issue on freebsd:
> > 
> > /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function
> > 'virtio_resource_init':
> > /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error:
> > unused parameter 'pci_dev' [-Werror=unused-parameter]  static int
> > virtio_resource_init(struct rte_pci_device *pci_dev)
> >                                                         ^
> > cc1: all warnings being treated as errors
> > 
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> 
> Acked-by:  Cunming Liang <cunming.liang@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c
index 9eb0217..88ecd57 100644
--- a/lib/librte_pmd_virtio/virtio_ethdev.c
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c
@@ -1068,7 +1068,7 @@  virtio_has_msix(const struct rte_pci_addr *loc __rte_unused)
 	return 0;
 }
 
-static int virtio_resource_init(struct rte_pci_device *pci_dev)
+static int virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
 {
 	/* no setup required */
 	return 0;