| Message ID | 1424449505.129655495@f327.i.mail.ru (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2D21EB783; Fri, 20 Feb 2015 17:25:08 +0100 (CET) Received: from f327.i.mail.ru (f327.i.mail.ru [217.69.140.223]) by dpdk.org (Postfix) with ESMTP id 98111B75D for <dev@dpdk.org>; Fri, 20 Feb 2015 17:25:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bk.ru; s=mail; h=Content-Type:Message-ID:Reply-To:Date:MIME-Version:Subject:To:From; bh=0fxzP7UXy2IGuelSxkl20gIELUkk0uYM8ofC+lkXg8A=; b=nCIG44znu5ZWXPDfDiIomK8JDOnI9Hk362591uzOiARuITrgJre9nvjbuVmjMxQxuCqiVLKr7n6lSqcsdwx8lEOYQZgJI0jp0t/MRiqc6O/kVGsHCgD1+Uga8FQldAZHn0OwI/jfI3IhXs936uejiLcchxhvB6pJEGlVDauFiy4=; Received: from [91.246.83.84] (ident=mail) by f327.i.mail.ru with local (envelope-from <imustafin@bk.ru>) id 1YOqO1-0002XT-AY for dev@dpdk.org; Fri, 20 Feb 2015 19:25:06 +0300 Received: from [91.246.83.84] by e.mail.ru with HTTP; Fri, 20 Feb 2015 19:25:05 +0300 From: =?UTF-8?B?0JjQu9GM0LTQsNGAINCc0YPRgdGC0LDRhNC40L0=?= <imustafin@bk.ru> To: dev@dpdk.org MIME-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [91.246.83.84] Date: Fri, 20 Feb 2015 19:25:05 +0300 X-Priority: 3 (Normal) Message-ID: <1424449505.129655495@f327.i.mail.ru> X-Mras: Ok X-Spam: undefined Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] =?utf-8?q?RTE=5FPIPELINE=5FACTION=5FPORT=5FMETA_doesn?= =?utf-8?q?=27t_work_properly?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: =?UTF-8?B?0JjQu9GM0LTQsNGAINCc0YPRgdGC0LDRhNC40L0=?= <imustafin@bk.ru> List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Ильдар Мустафин
Feb. 20, 2015, 4:25 p.m. UTC
Hi, list! RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library doesn't work for non-default table entries. Is this bug or correct behaviour? This is my patch, that changes this behaviour: Thanks, Ildar
Comments
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of ?????? ???????? > Sent: Friday, February 20, 2015 4:25 PM > To: dev@dpdk.org > Subject: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > properly > > Hi, list! > > RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library doesn't > work for non-default table entries. Is this bug or correct behaviour? > > This is my patch, that changes this behaviour: > > --- a/lib/librte_pipeline/rte_pipeline.c > +++ b/lib/librte_pipeline/rte_pipeline.c > @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct rte_pipeline > *p, uint64_t pkts_mask) > { > p->action_mask1[RTE_PIPELINE_ACTION_DROP] = 0; > p->action_mask1[RTE_PIPELINE_ACTION_PORT] = 0; > + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] = 0; > p->action_mask1[RTE_PIPELINE_ACTION_TABLE] = 0; > > + > if ((pkts_mask & (pkts_mask + 1)) == 0) { > uint64_t n_pkts = __builtin_popcountll(pkts_mask); > uint32_t i; > @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p) > pkts_mask = RTE_LEN2MASK(n_pkts, uint64_t); > p->action_mask0[RTE_PIPELINE_ACTION_DROP] = 0; > p->action_mask0[RTE_PIPELINE_ACTION_PORT] = 0; > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] = 0; > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] = 0; > > /* Input port user actions */ > @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p) > p->action_mask0[RTE_PIPELINE_ACTION_PORT] |= > p->action_mask1[ > RTE_PIPELINE_ACTION_PORT]; > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |= > + p->action_mask1[ > + RTE_PIPELINE_ACTION_PORT_META]; > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] |= > p->action_mask1[ > RTE_PIPELINE_ACTION_TABLE]; > > > > > > Thanks, Ildar Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Thank you, Ildar! -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
2015-02-20 19:26, Dumitrescu, Cristian: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of ?????? ???????? > > Sent: Friday, February 20, 2015 4:25 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > > properly > > > > Hi, list! > > > > RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library doesn't > > work for non-default table entries. Is this bug or correct behaviour? > > > > This is my patch, that changes this behaviour: > > > > --- a/lib/librte_pipeline/rte_pipeline.c > > +++ b/lib/librte_pipeline/rte_pipeline.c > > @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct rte_pipeline > > *p, uint64_t pkts_mask) > > { > > p->action_mask1[RTE_PIPELINE_ACTION_DROP] = 0; > > p->action_mask1[RTE_PIPELINE_ACTION_PORT] = 0; > > + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] = 0; > > p->action_mask1[RTE_PIPELINE_ACTION_TABLE] = 0; > > > > + > > if ((pkts_mask & (pkts_mask + 1)) == 0) { > > uint64_t n_pkts = __builtin_popcountll(pkts_mask); > > uint32_t i; > > @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p) > > pkts_mask = RTE_LEN2MASK(n_pkts, uint64_t); > > p->action_mask0[RTE_PIPELINE_ACTION_DROP] = 0; > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] = 0; > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] = 0; > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] = 0; > > > > /* Input port user actions */ > > @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p) > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] |= > > p->action_mask1[ > > RTE_PIPELINE_ACTION_PORT]; > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |= > > + p->action_mask1[ > > + RTE_PIPELINE_ACTION_PORT_META]; > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] |= > > p->action_mask1[ > > RTE_PIPELINE_ACTION_TABLE]; > > > > > > > > > > > > Thanks, Ildar > > Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> No Cristian, you cannot ack this patch, even if it fixes the problem. The format is not OK: indent is wrong and it's not signed. Please Ildar, check http://dpdk.org/dev#send to know how to submit a patch. > Thank you, Ildar!
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, February 20, 2015 8:47 PM > To: Dumitrescu, Cristian; imustafin@bk.ru > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > properly > > 2015-02-20 19:26, Dumitrescu, Cristian: > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of ?????? > ???????? > > > Sent: Friday, February 20, 2015 4:25 PM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > > > properly > > > > > > Hi, list! > > > > > > RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library > doesn't > > > work for non-default table entries. Is this bug or correct behaviour? > > > > > > This is my patch, that changes this behaviour: > > > > > > --- a/lib/librte_pipeline/rte_pipeline.c > > > +++ b/lib/librte_pipeline/rte_pipeline.c > > > @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct > rte_pipeline > > > *p, uint64_t pkts_mask) > > > { > > > p->action_mask1[RTE_PIPELINE_ACTION_DROP] = 0; > > > p->action_mask1[RTE_PIPELINE_ACTION_PORT] = 0; > > > + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] = 0; > > > p->action_mask1[RTE_PIPELINE_ACTION_TABLE] = 0; > > > > > > + > > > if ((pkts_mask & (pkts_mask + 1)) == 0) { > > > uint64_t n_pkts = __builtin_popcountll(pkts_mask); > > > uint32_t i; > > > @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p) > > > pkts_mask = RTE_LEN2MASK(n_pkts, uint64_t); > > > p->action_mask0[RTE_PIPELINE_ACTION_DROP] = 0; > > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] = 0; > > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] = 0; > > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] = 0; > > > > > > /* Input port user actions */ > > > @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p) > > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] |= > > > p->action_mask1[ > > > RTE_PIPELINE_ACTION_PORT]; > > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |= > > > + p->action_mask1[ > > > + RTE_PIPELINE_ACTION_PORT_META]; > > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] |= > > > p->action_mask1[ > > > RTE_PIPELINE_ACTION_TABLE]; > > > > > > > > > > > > > > > > > > Thanks, Ildar > > > > Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > No Cristian, you cannot ack this patch, even if it fixes the problem. > The format is not OK: indent is wrong and it's not signed. > Please Ildar, check http://dpdk.org/dev#send to know how to submit a > patch. > > > Thank you, Ildar! Sorry, Thomas. Ildar, please fix the signature (currently it the above signature is: On Behalf Of ??????) and the indentation and resubmit. Regards, Cristian -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
--- a/lib/librte_pipeline/rte_pipeline.c +++ b/lib/librte_pipeline/rte_pipeline.c @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct rte_pipeline *p, uint64_t pkts_mask) { p->action_mask1[RTE_PIPELINE_ACTION_DROP] = 0; p->action_mask1[RTE_PIPELINE_ACTION_PORT] = 0; + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] = 0; p->action_mask1[RTE_PIPELINE_ACTION_TABLE] = 0; + if ((pkts_mask & (pkts_mask + 1)) == 0) { uint64_t n_pkts = __builtin_popcountll(pkts_mask); uint32_t i; @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p) pkts_mask = RTE_LEN2MASK(n_pkts, uint64_t); p->action_mask0[RTE_PIPELINE_ACTION_DROP] = 0; p->action_mask0[RTE_PIPELINE_ACTION_PORT] = 0; + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] = 0; p->action_mask0[RTE_PIPELINE_ACTION_TABLE] = 0; /* Input port user actions */ @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p) p->action_mask0[RTE_PIPELINE_ACTION_PORT] |= p->action_mask1[ RTE_PIPELINE_ACTION_PORT]; + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |= + p->action_mask1[ + RTE_PIPELINE_ACTION_PORT_META]; p->action_mask0[RTE_PIPELINE_ACTION_TABLE] |= p->action_mask1[ RTE_PIPELINE_ACTION_TABLE];