diff mbox

[dpdk-dev] Add Q variable to external builds to be quite

Message ID 1423937607-35845-1-git-send-email-keith.wiles@intel.com (mailing list archive)
State Rejected, archived
Headers

Commit Message

Wiles, Keith Feb. 14, 2015, 6:13 p.m. UTC 
  Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
 mk/rte.extvars.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Olivier Matz Feb. 16, 2015, 2:15 p.m. UTC | #1 
Hi Keith,

On 02/14/2015 07:13 PM, Keith Wiles wrote:
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  mk/rte.extvars.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk
> index 3e5a990..83a5721 100644
> --- a/mk/rte.extvars.mk
> +++ b/mk/rte.extvars.mk
> @@ -66,6 +66,10 @@ endif
>  RTE_OUTPUT ?= $(RTE_SRCDIR)/build
>  export RTE_OUTPUT
>  
> +# define Q to '@' or not. $(Q) is used to prefix all shell commands to
> +# be executed silently.
> +Q=@
> +
>  # if we are building an external application, include SDK
>  # configuration and include project configuration if any
>  include $(RTE_SDK_BIN)/.config
> 

In the examples/ directory, rte.extvars.mk is never included directly.
They use rte.vars.mk, which already properly defines the $(Q) variable
(its value depends on V= argument).

So I think we don't need this patch.

Regards,
Olivier
diff mbox

Patch

diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk
index 3e5a990..83a5721 100644
--- a/mk/rte.extvars.mk
+++ b/mk/rte.extvars.mk
@@ -66,6 +66,10 @@  endif
 RTE_OUTPUT ?= $(RTE_SRCDIR)/build
 export RTE_OUTPUT
 
+# define Q to '@' or not. $(Q) is used to prefix all shell commands to
+# be executed silently.
+Q=@
+
 # if we are building an external application, include SDK
 # configuration and include project configuration if any
 include $(RTE_SDK_BIN)/.config